Re: [PATCH] unix.7: Add a description for ENFILE.

Alejandro Colomar (man-pages)
2021-10-02T18:10:36Z

Hi, Kuniyuki!

On 10/2/21 7:56 PM, Kuniyuki Iwashima wrote:
> From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
> Date: Sat, 2 Oct 2021 19:44:52 +0200
>> Hello Kuniyuki,
>>
>> On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
>>> When creating UNIX domain sockets, the kernel used to return -ENOMEM on
>>> error where it should return -ENFILE. The behaviour has been wrong since
>>> 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
>>> instead of NULL in unix_create1().").
>>>
>>> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
>>> ---
>>> Note to maintainers of man-pages, the commit is merged in the net tree [0]
>>> but not in the Linus' tree yet.
>>>
>>> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
>>
>> Thanks!
>>
>> The patch looks good to me, so could you ping back when this is merged
>> in Linus's tree?
>
> Thanks, sure!
> Is that -stable?
> The pull-request from net-next hit the Linus' 5.14-rc4 tree few days ago.
> https://lore.kernel.org/linux-kernel/20210930163002.4159171-1-kuba@kernel.org/
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4de593fb965fc2bd11a0b767e0c65ff43540a6e4

Ahh, if it already is in Linus's tree, I'll merge your patch.

Thanks,

Alex

>
> Best regards,
> Kuniyuki
>
>
>>
>> Cheers,
>>
>> Alex
>>
>>> ---
>>> man7/unix.7 | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/man7/unix.7 b/man7/unix.7
>>> index 6d30b25cd..2dc96fea1 100644
>>> --- a/man7/unix.7
>>> +++ b/man7/unix.7
>>> @@ -721,6 +721,9 @@ invalid state for the applied operation.
>>> called on an already connected socket or a target address was
>>> specified on a connected socket.
>>> .TP
>>> +.B ENFILE
>>> +The system-wide limit on the total number of open files has been reached.
>>> +.TP
>>> .B ENOENT
>>> The pathname in the remote address specified to
>>> .BR connect (2)
>>>
>>
>>
>> --
>> Alejandro Colomar
>> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
>> http://www.alejandro-colomar.es/