Re: [PATCH 01/10] fanotify_init.2: tfix

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1641 bytes --]

Hi Jakub,

On 8/22/22 20:21, Jakub Wilk wrote:
> * Alejandro Colomar <alx.manpages@gmail.com>, 2022-08-20 01:28:
>> BTW, I noticed you find a lot of typos.  I'm curious: do you find them 
>> when reading, or you run a tool that finds them?
> 
> I have two unconventional spellcheckers in my toolbox:
> 
> https://jwilk.net/software/mwic
> https://jwilk.net/software/anorack
> 
> I usually run them on diffs, like this:
> 
>    $ git pull
>    ...
>    $ git diff @{1} | grep ^+ | mwic
>    [wade through the jungle of false positives]
> 

Interesting.  I run both through the entire repo.

anorack(1) seems to be reasonable, in that it runs in under 1 second, 
and only has 138 matches.  Many of them are false positives, but it's 
not unreasonable to go through them all.

$ time find man* -type f | xargs anorack | wc -l
138

real	0m0.971s
user	0m0.691s
sys	0m0.024s


I could add a `make lint-spell-anorack` target to run it from time to 
time.  Maybe you could special-case some of those false positives to 
make it even better?

mwick(1) seems to have an unreasonably huge number of false positives:

$ time find man* -type f | xargs  mwic | wc -l
139760

real	0m38.862s
user	0m38.653s
sys	0m0.224s

It seems it could get some help of understanding man(7) syntax to limit 
itself to text.  I'm definitely not adding this one for now.

Also, it would be nice if both of them had a way of reporting errors to 
make(1) through an EXIT STATUS, which could also be documented in their 
manual pages.


Cheers,

Alex

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]