Re: [PATCH 19/24] pthread_setname_np.3: ffix

Michael Kerrisk (man-pages)
2020-09-11T11:13:01Z

Hi Alex,

On 9/11/20 10:32 AM, Alejandro Colomar wrote:
> Hi Michael,
>
> The indentation in the original code was a bit weird (specifically, the
> 'do {' part had one more indentation level than the closing '} while'),
> so I simply chose something nice. See the original page, and if you
> think it's ok keep it, else find something nice :)

Sorry -- I was being a bit slow. Now I see what you mean.
I've fixed it, but in a different way.

Thanks,

Michael

> On 2020-09-11 09:58, Michael Kerrisk (man-pages) wrote:
>> Hi Alex,
>>
>> On 9/10/20 11:13 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>>> ---
>>> man3/pthread_setname_np.3 | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> What's the rationale for this patch?
>>
>> Thanks,
>>
>> Michael
>>>
>>> diff --git a/man3/pthread_setname_np.3 b/man3/pthread_setname_np.3
>>> index b206f66c0..4dc4960cd 100644
>>> --- a/man3/pthread_setname_np.3
>>> +++ b/man3/pthread_setname_np.3
>>> @@ -164,8 +164,9 @@ THREADFOO
>>>
>>> #define NAMELEN 16
>>>
>>> -#define errExitEN(en, msg) \e
>>> - do { errno = en; perror(msg); exit(EXIT_FAILURE); \e
>>> +#define errExitEN(en, msg) do \e
>>> + { \
>>> + errno = en; perror(msg); exit(EXIT_FAILURE); \e
>>> } while (0)
>>>
>>> static void *
>>>
>>
>>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/