From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] setfsgid.2: tfix
Date: Mon, 15 Feb 2021 20:55:43 +0100 [thread overview]
Message-ID: <e2560966-a299-f8f7-b008-7a73ffaf679f@gmail.com> (raw)
In-Reply-To: <20210215131522.450666-4-alx.manpages@gmail.com>
Hi Alex,
On 2/15/21 2:15 PM, Alejandro Colomar wrote:
> The type of fsgid is git_t, and not uid_t. Fix it.
Cute. That mistake has been present for about 25 years!
Patch applied.
Thanks,
Michael
> ......
>
> .../glibc$ grep_glibc_prototype setfsgid
> sysdeps/unix/sysv/linux/sys/fsuid.h:31:
> extern int setfsgid (__gid_t __gid) __THROW;
> .../glibc$
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
> man2/setfsgid.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/setfsgid.2 b/man2/setfsgid.2
> index e2d4d09f3..3fd22f3a5 100644
> --- a/man2/setfsgid.2
> +++ b/man2/setfsgid.2
> @@ -36,7 +36,7 @@ setfsgid \- set group identity used for filesystem checks
> .nf
> .B #include <sys/fsuid.h>
> .PP
> -.BI "int setfsgid(uid_t " fsgid );
> +.BI "int setfsgid(gid_t " fsgid );
> .fi
> .SH DESCRIPTION
> On Linux, a process has both a filesystem group ID and an effective group ID.
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2021-02-15 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 13:15 [PATCH] setfsgid.2: tfix Alejandro Colomar
2021-02-15 19:55 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2560966-a299-f8f7-b008-7a73ffaf679f@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox