Re: [PATCH 0/4] mount_setattr.2: updates

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2507 bytes --]

Hi, Christian!

On 6/7/22 15:38, Christian Brauner wrote:
> From: "Christian Brauner (Microsoft)" <brauner@kernel.org>
> 
> Hey everyone,
> 
> Here's a set of updates for the mount_setattr.2 man page.
> I would really appreciate it if groff syntax could be fixed up by
> maintainers. I tried my best to remember the guidelines though. :)

Sure!  Mostly looks good.  Applied; and I applied a small patch on top 
of them.

Just a small reminder from man(7):
        .B  Bold

        .BI Bold alternating with italic

        .BR Bold  alternating  with  Roman

I fixed the current pages to have a consistent style.  You can check out 
the alx/main branch from the official kernel.org repo.

Thanks,
Alex


> 
> Thanks!
> Christian
> 
> Christian Brauner (4):
>    mount_setattr.2: add and explain missing EBUSY error
>    mount_setattr.2: update conditions to create ID-mapped mounts
>    mount_setattr.2: update list of supported filesystems
>    mount_setattr.2: ffix
> 
>   man2/mount_setattr.2 | 64 +++++++++++++++++++++++++++++++++++---------
>   1 file changed, 52 insertions(+), 12 deletions(-)
> 
> 
> base-commit: ae6b221882ce71ba82fcdbe02419a225111502f0

diff --git a/man2/mount_setattr.2 b/man2/mount_setattr.2
index 718a4adae..352c8e852 100644
--- a/man2/mount_setattr.2
+++ b/man2/mount_setattr.2
@@ -414,7 +414,7 @@ but the mount still holds files open for writing.
  .TP
  .B EBUSY
  The caller tried to create an ID-mapped mount raising
-.BR MOUNT_ATTR_IDMAP
+.B MOUNT_ATTR_IDMAP
  and specifying
  .I userns_fd
  but the mount still holds files open for writing.
@@ -651,26 +651,26 @@ Currently, the following filesystems support 
ID-mapped mounts:
  .BR ext4 (5)
  (since Linux 5.12)
  .IP \(bu
-.BR FAT
+.B FAT
  (since Linux 5.12)
  .IP \(bu
  .BR btrfs (5)
  (since Linux 5.15)
  .\" commit 5b9b26f5d0b88b74001dcfe4ab8a8f2f4e744112
  .IP \(bu
-.BR ntfs3
+.B ntfs3
  (since Linux 5.15)
  .\" commit 82cae269cfa953032fbb8980a7d554d60fb00b17
  .IP \(bu
-.BR f2fs
+.B f2fs
  (since Linux 5.18)
  .\" commit 984fc4e76d63345499f01c0c198a4b44860cf027
  .IP \(bu
-.BR erofs
+.B erofs
  (since Linux 5.19)
  .\" commit 6c459b78d4793afbba6d864c466cc5cd2932459d
  .IP \(bu
-.BR overlayfs
+.B overlayfs
  (ID-mapped lower and upper layers supported since Linux 5.19)
  .PD
  .RE


-- 
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]