public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: Helge Kreutzmann <debian@helgefjell.de>,
	mario.blaettermann@gmail.com, linux-man@vger.kernel.org
Subject: Re: Issue in man page PR_SET_SECUREBITS.2const
Date: Mon, 25 Aug 2025 16:00:58 -0400	[thread overview]
Message-ID: <f076ae23-e4b2-4294-9038-8a234aa009a8@redhat.com> (raw)
In-Reply-To: <j2ramfsczn2lparyohabohs5lslb2neyxgp73c23bq6vzqsn6w@t7hw5mdvt4q4>

On 8/25/25 3:41 PM, Alejandro Colomar wrote:
> Hi Carlos,
> 
> On Mon, Aug 25, 2025 at 01:52:03PM -0400, Carlos O'Donell wrote:
>> On 8/24/25 3:21 PM, Alejandro Colomar wrote:
>>> Hi Helge,
>>>
>>>> Subject: Re: Issue in man page PR_SET_SECUREBITS.2const
>>>
>>> You probably meant PR_SET_THP_DISABLE.2const.  The text you quoted is
>>> there:
>>>
>>> 	$ grep -rn THP.disable
>>> 	man/man2const/PR_SET_THP_DISABLE.2const:9:set the state of the "THP disable" flag for the calling thread
>>> 	man/man2const/PR_SET_THP_DISABLE.2const:21:Set the state of the "THP disable" flag for the calling thread.
>>> 	man/man2const/PR_SET_THP_DISABLE.2const:32:The setting of the "THP disable" flag is inherited by a child created via
>>> 	man/man2const/PR_GET_THP_DISABLE.2const:9:get the state of the "THP disable" flag for the calling thread
>>> 	man/man2const/PR_GET_THP_DISABLE.2const:22:the "THP disable" flag for the calling thread:
>>>
>>> On Sun, Aug 24, 2025 at 02:48:48PM +0000, Helge Kreutzmann wrote:
>>>> Without further ado, the following was found:
>>>>
>>>> Issue:    malloc → B<malloc>(3) ?
>>>
>>> Maybe, but we should probably add a reference to malloc_hook(3) instead?
>>
>> In a modern system you care about malloc not malloc_hook.
>>
>> The hooks have been removed and glibc has directly integrated THP usage in malloc instead.
>>
>> https://sourceware.org/glibc/manual/2.42/html_node/Memory-Allocation-Tunables.html
> 
> Thanks!  Do we need a more thorough rewrite of this page is needed?
> Or just replace malloc by malloc(3)?

Yes, the existing text is only correct for < 2.34 glibc system.

A > 2.34 system has THP support with the tunable to support THP (for legacy libhugetlbfs users).

And a glibc == 2.34 system lacks this feature and doesn't support such hook + interposer deployments.

The quickest fix is to reference malloc(3) for now.

-- 
Cheers,
Carlos.


  reply	other threads:[~2025-08-25 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-24 14:48 Issue in man page PR_SET_SECUREBITS.2const Helge Kreutzmann
2025-08-24 19:21 ` Alejandro Colomar
2025-08-25 16:11   ` Helge Kreutzmann
2025-08-25 17:52   ` Carlos O'Donell
2025-08-25 19:41     ` Alejandro Colomar
2025-08-25 20:00       ` Carlos O'Donell [this message]
2025-08-31  9:19         ` Alejandro Colomar
  -- strict thread matches above, loose matches on Subject: below --
2025-08-24 14:48 Helge Kreutzmann
2025-08-24 19:25 ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f076ae23-e4b2-4294-9038-8a234aa009a8@redhat.com \
    --to=carlos@redhat.com \
    --cc=alx@kernel.org \
    --cc=debian@helgefjell.de \
    --cc=linux-man@vger.kernel.org \
    --cc=mario.blaettermann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox