From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, "Pali Rohár" <pali@kernel.org>,
linux-man@vger.kernel.org
Subject: Re: [PATCH 14/23] ioctl_tty.2: Update DTR example
Date: Sun, 8 Aug 2021 22:12:51 +0200 [thread overview]
Message-ID: <f233528f-d91c-23a8-05ea-d9e299f84da3@gmail.com> (raw)
In-Reply-To: <20210808084133.734274-15-alx.manpages@gmail.com>
Hello Pali and Alex,
On 8/8/21 10:41 AM, Alejandro Colomar wrote:
> From: Pali Rohár <pali@kernel.org>
>
> Do not include unused (and incompatible) header file termios.h and include
> required header files for puts() and close() functions.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Thanks. Patch applied.
Cheers,
Michael
> ---
> man2/ioctl_tty.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2
> index 967b5c4c7..519e4606f 100644
> --- a/man2/ioctl_tty.2
> +++ b/man2/ioctl_tty.2
> @@ -730,7 +730,8 @@ Insufficient permission.
> Check the condition of DTR on the serial port.
> .PP
> .EX
> -#include <termios.h>
> +#include <stdio.h>
> +#include <unistd.h>
> #include <fcntl.h>
> #include <sys/ioctl.h>
>
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2021-08-08 20:12 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 8:41 [PATCH 00/23] More patches from others Alejandro Colomar
2021-08-08 8:41 ` [PATCH 01/23] pipe.7: also mention writev(2) in atomicity section Alejandro Colomar
2021-08-08 13:20 ` Alejandro Colomar (man-pages)
2021-08-08 20:06 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 02/23] sigaction.2: Document SA_EXPOSE_TAGBITS and the flag support detection protocol Alejandro Colomar
2021-08-09 0:29 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 03/23] sigaction.2: Apply minor tweaks to Peter's patch Alejandro Colomar
2021-08-09 0:34 ` Michael Kerrisk (man-pages)
2021-08-09 6:36 ` Alejandro Colomar (man-pages)
2021-08-08 8:41 ` [PATCH 04/23] namespaces.7: ffix Alejandro Colomar
2021-08-08 20:08 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 05/23] unix.7: tfix Alejandro Colomar
2021-08-08 20:23 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 06/23] futex.2: Document FUTEX_LOCK_PI2 Alejandro Colomar
2021-08-09 0:06 ` Michael Kerrisk (man-pages)
2021-08-09 8:14 ` Kurt Kanzenbach
2021-08-09 9:01 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 07/23] futex.2: Minor tweaks to Kurt's patch Alejandro Colomar
2021-08-09 0:05 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 08/23] man2: new page describing memfd_secret() system call Alejandro Colomar
2021-08-09 2:00 ` Michael Kerrisk (man-pages)
2021-08-10 8:53 ` Mike Rapoport
2021-08-08 8:41 ` [PATCH 09/23] termios.3: Document missing baudrate constants Alejandro Colomar
2021-08-08 20:30 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 10/23] getopt.3: Further clarification of optstring Alejandro Colomar
2021-08-08 22:11 ` Michael Kerrisk (man-pages)
2021-08-09 6:40 ` Alejandro Colomar (man-pages)
2021-08-08 8:41 ` [PATCH 11/23] getopt.3: Minor tweak to James's patch Alejandro Colomar
2021-08-08 22:12 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 12/23] termios.3: Use bold style for Bnn and EXTn macro constants Alejandro Colomar
2021-08-08 20:31 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 13/23] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2, TCSETSF2 Alejandro Colomar
2021-08-08 20:37 ` Michael Kerrisk (man-pages)
2021-08-08 20:56 ` Michael Kerrisk (man-pages)
2021-08-08 21:15 ` Pali Rohár
2021-08-08 21:30 ` Michael Kerrisk (man-pages)
2021-08-10 19:11 ` Pali Rohár
2021-08-10 20:40 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 14/23] ioctl_tty.2: Update DTR example Alejandro Colomar
2021-08-08 20:12 ` Michael Kerrisk (man-pages) [this message]
2021-08-08 8:41 ` [PATCH 15/23] termios.3: Add information how to set baud rate to any other value Alejandro Colomar
2021-08-08 20:34 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 16/23] man-pages.7: wfix Alejandro Colomar
2021-08-08 20:09 ` Michael Kerrisk (man-pages)
2021-10-17 19:42 ` Alejandro Colomar (man-pages)
2021-08-08 8:41 ` [PATCH 17/23] termios.3: ffix Alejandro Colomar
2021-08-08 20:35 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 18/23] termios.3: SPARC architecture has 4 different Bnnn constants Alejandro Colomar
2021-08-08 20:36 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 19/23] regex.3: wfix Alejandro Colomar
2021-08-08 20:11 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 20/23] mount_setattr.2: New manual page documenting the mount_setattr() system call Alejandro Colomar
2021-08-10 1:34 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 21/23] mount_setattr.2: Minor tweaks to Chirstian's patch Alejandro Colomar
2021-08-10 1:35 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 22/23] ldd.1: Fix example command Alejandro Colomar
2021-08-08 22:32 ` Michael Kerrisk (man-pages)
2021-08-08 8:41 ` [PATCH 23/23] close_range.2: Glibc added a wrapper recently Alejandro Colomar
2021-08-08 20:58 ` Michael Kerrisk (man-pages)
2021-08-10 1:39 ` [PATCH 00/23] More patches from others Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f233528f-d91c-23a8-05ea-d9e299f84da3@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox