Re: [PATCH] mmap.2: ffix

["Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>]

Hi, Branden!

On 2/27/22 19:57, G. Branden Robinson wrote:
> Hi, Alex!
> 
> At 2022-02-27T18:09:51+0100, Alejandro Colomar wrote:
>>> @@ -289,8 +289,7 @@ Note that older kernels which do not recognize the
>>>  .BR MAP_FIXED_NOREPLACE
>>>  flag will typically (upon detecting a collision with a preexisting mapping)
>>>  fall back to a "non-\c
>>> -.B MAP_FIXED\c
>>> -" type of behavior:
>>
>> Branden, why is that?  Is a leading '"' special here?
> 
> Nope.  I think you correctly surmised what the original input was doing.

Then, should I report a bug in groff?

I could reproduce the incorrect formatted output with
GNU groff version 1.23.0.rc1.1931-35c9b

> 
>>> +.BR MAP_FIXED "\(dq type of behavior:"
>>
>> I'll apply a slightly simpler patch (removing \c):
> [...]
>> -fall back to a "non-\c
>> -.B MAP_FIXED\c
>> -" type of behavior:
>> +fall back to a
>> +.RB \(dqnon- MAP_FIXED \(dq
>> +type of behavior:
> 
> This is indeed an improvement.  your change should make no _visible_
> change to the rendered document.
> 
> I wouldn't use \(dq, though--these quotation marks are for prose, not
> code.  I would use left and right double quotation marks.
> 
> fall back to a
> .RB \(lqnon- MAP_FIXED \(rq
> type of behavior:

Okay, I'll fix that.

Cheers,

Alex

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/