Re: [PATCH (2) 31/34] fanotify.7: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T15:38:57Z

Hello Alex,

On 9/4/20 5:05 PM, Alejandro Colomar wrote:
>>From 75af70465a8e60aa1d96b32d843b074966b7a878 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:58:14 +0200
> Subject: [PATCH 31/33] fanotify.7: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

Thanks. Patch applied.

Cheers,

Michael

> ---
> man7/fanotify.7 | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/man7/fanotify.7 b/man7/fanotify.7
> index a7d60b2b9..29c818027 100644
> --- a/man7/fanotify.7
> +++ b/man7/fanotify.7
> @@ -808,8 +808,7 @@ handle_events(int fd)
>
> response.fd = metadata\->fd;
> response.response = FAN_ALLOW;
> - write(fd, &response,
> - sizeof(struct fanotify_response));
> + write(fd, &response, sizeof(response));
> }
>
> /* Handle closing of writable file event */
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/