Re: [PATCH (2) 29/34] tsearch.3: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-05T14:22:43Z

Hello Alex,

On 9/4/20 5:03 PM, Alejandro Colomar wrote:
>>From ff3fe9cdfd280fce97e9289e9a91fb6cc2c1c368 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:56:52 +0200
> Subject: [PATCH 29/34] tsearch.3: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

Patch applied.

Cheers,

Michael

> ---
> man3/tsearch.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/tsearch.3 b/man3/tsearch.3
> index 452395d6b..f0ff80e8c 100644
> --- a/man3/tsearch.3
> +++ b/man3/tsearch.3
> @@ -327,7 +327,7 @@ main(void)
>
> srand(time(NULL));
> for (i = 0; i < 12; i++) {
> - ptr = xmalloc(sizeof(int));
> + ptr = xmalloc(sizeof(*ptr));
> *ptr = rand() & 0xff;
> val = tsearch((void *) ptr, &root, compare);
> if (val == NULL)
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/