Re: [PATCH (2) 22/34] pthread_create.3: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-05T14:21:57Z

Hello Alex,

On 9/4/20 4:48 PM, Alejandro Colomar wrote:
>>From 03783d811fad4783b394c01a4ac68ca6d92b6c58 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:52:22 +0200
> Subject: [PATCH 22/34] pthread_create.3: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory

Patch applied.

Cheers,

Michael

> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man3/pthread_create.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/pthread_create.3 b/man3/pthread_create.3
> index d86188e6b..5ffb14586 100644
> --- a/man3/pthread_create.3
> +++ b/man3/pthread_create.3
> @@ -361,7 +361,7 @@ main(int argc, char *argv[])
>
> /* Allocate memory for pthread_create() arguments */
>
> - tinfo = calloc(num_threads, sizeof(struct thread_info));
> + tinfo = calloc(num_threads, sizeof(*tinfo));
> if (tinfo == NULL)
> handle_error("calloc");
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/