Re: [PATCH (2) 25/34] rtnetlink.3: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T16:59:16Z

Hello Alex,

On 9/4/20 4:52 PM, Alejandro Colomar wrote:
>>From eca0c1500aa4db77c8c8d079798fe080e83e9935 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:55:00 +0200
> Subject: [PATCH 25/34] rtnetlink.3: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man3/rtnetlink.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/rtnetlink.3 b/man3/rtnetlink.3
> index 07bb1fbf9..2d9fa05a2 100644

Patch applied.

Thanks,

Michael

> --- a/man3/rtnetlink.3
> +++ b/man3/rtnetlink.3
> @@ -105,7 +105,7 @@ unsigned int mtu = 1000;
> int rtnetlink_sk = socket(AF_NETLINK, SOCK_DGRAM, NETLINK_ROUTE);
>
> memset(&req, 0, sizeof(req));
> -req.nh.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifinfomsg));
> +req.nh.nlmsg_len = NLMSG_LENGTH(sizeof(req.if));
> req.nh.nlmsg_flags = NLM_F_REQUEST;
> req.nh.nlmsg_type = RTM_NEWLINK;
> req.if.ifi_family = AF_UNSPEC;
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/