Re: [PATCH (2) 07/34] perf_event_open.2: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T12:25:11Z

Hello ALex,

On 9/4/20 12:57 PM, Alejandro Colomar wrote:
>>From ec1f70a162b0f4ea7a191baf8c098d7872dedce6 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:29:33 +0200
> Subject: [PATCH 07/34] perf_event_open.2: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory

Thanks. Patch applied.

Cheers,

Michael

> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man2/perf_event_open.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/perf_event_open.2 b/man2/perf_event_open.2
> index ea5ee725f..aea825706 100644
> --- a/man2/perf_event_open.2
> +++ b/man2/perf_event_open.2
> @@ -3439,7 +3439,7 @@ main(int argc, char **argv)
> printf("Measuring instruction count for this printf\en");
>
> ioctl(fd, PERF_EVENT_IOC_DISABLE, 0);
> - read(fd, &count, sizeof(long long));
> + read(fd, &count, sizeof(count));
>
> printf("Used %lld instructions\en", count);
>
Hello

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/