Re: [PATCH (2) 26/34] rtnetlink.3: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T18:10:30Z

Hello Alex,

On 9/4/20 4:54 PM, Alejandro Colomar wrote:
>>From 2b7a02916c24af8cbb0cbb071a7223fe48a52571 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:55:11 +0200
> Subject: [PATCH 26/34] rtnetlink.3: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

Thanks. Patch applied.

Cheers,

Michael

> ---
> man3/rtnetlink.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/rtnetlink.3 b/man3/rtnetlink.3
> index 2d9fa05a2..f8b6c255a 100644
> --- a/man3/rtnetlink.3
> +++ b/man3/rtnetlink.3
> @@ -114,7 +114,7 @@ req.if.ifi_change = 0xffffffff; /* ??? */
> rta = (struct rtattr *)(((char *) &req) +
> NLMSG_ALIGN(req.nh.nlmsg_len));
> rta\->rta_type = IFLA_MTU;
> -rta\->rta_len = RTA_LENGTH(sizeof(unsigned int));
> +rta\->rta_len = RTA_LENGTH(sizeof(mtu));
> req.nh.nlmsg_len = NLMSG_ALIGN(req.nh.nlmsg_len) +
> RTA_LENGTH(sizeof(mtu));
> memcpy(RTA_DATA(rta), &mtu, sizeof(mtu));
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/