Issue in man page motd.5

Issue in man page motd.5

[Helge Kreutzmann]

Without further ado, the following was found:

Issue:    B<pam_motd>(8)  B<login>(1) → B<pam_motd>(8) from B<login>(1)

"The contents of I</etc/motd> are displayed by B<pam_motd>(8)  B<login>(1)  "
"after a successful login but just before it executes the login shell."

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 888 bytes --]

Hi Helge,

On 1/22/23 20:31, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    B<pam_motd>(8)  B<login>(1) → B<pam_motd>(8) from B<login>(1)

Sorry, I can't reproduce.  The current upstream manual page has the following 
text (ignoring formatting):


DESCRIPTION
        The  contents of /etc/motd are displayed by login(1) after a successful
        login but just before it executes the login shell.

        The abbreviation "motd" stands for "message of the day", and this  file
        has  been  traditionally  used  for exactly that (it requires much less
        disk space than mail to all users).


> 
> "The contents of I</etc/motd> are displayed by B<pam_motd>(8)  B<login>(1)"
> "after a successful login but just before it executes the login shell."

Cheers,

Alex

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Helge Kreutzmann]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hello Alex,
On Sun, Jan 22, 2023 at 09:07:49PM +0100, Alejandro Colomar wrote:
> On 1/22/23 20:31, Helge Kreutzmann wrote:
> > Without further ado, the following was found:
> > 
> > Issue:    B<pam_motd>(8)  B<login>(1) → B<pam_motd>(8) from B<login>(1)
> 
> Sorry, I can't reproduce.  The current upstream manual page has the
> following text (ignoring formatting):

As comment, I see below the following:
#.  Patched in Debian, maybe other distribs
#.  End of patch

(Again, in our representation, not groff!)

So probably a Debian patch, marked as such.

Please ignore this and the following report then.

Greetings

        Helge



-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Issue in man page motd.5

[Helge Kreutzmann]

Without further ado, the following was found:

Issue:    double space before "after"

"The contents of I</etc/motd> are displayed by B<login>(1)  after a "
"successful login but just before it executes the login shell."

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi Helge,

On Sun, Aug 24, 2025 at 02:48:45PM +0000, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    double space before "after"

I can't see that.  Can you please check?


Cheers,
Alex

> 
> "The contents of I</etc/motd> are displayed by B<login>(1)  after a "
> "successful login but just before it executes the login shell."

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Helge Kreutzmann]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

Hello Alejandro,
Am Sun, Aug 31, 2025 at 01:33:46PM +0200 schrieb Alejandro Colomar:
> On Sun, Aug 24, 2025 at 02:48:45PM +0000, Helge Kreutzmann wrote:
> > Without further ado, the following was found:
> > 
> > Issue:    double space before "after"
> 
> I can't see that.  Can you please check?

> > "The contents of I</etc/motd> are displayed by B<login>(1)  after a "
> > "successful login but just before it executes the login shell."

I see the double space in our po file, but I cannot deduce how it is
created there, maybe a po4a artefact?

So please disregard this issue, I mark it accordingly for our
translator.

Greetings

           Helge

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Hi Helge,

On Sun, Aug 31, 2025 at 11:42:49AM +0000, Helge Kreutzmann wrote:
> Hello Alejandro,
> Am Sun, Aug 31, 2025 at 01:33:46PM +0200 schrieb Alejandro Colomar:
> > On Sun, Aug 24, 2025 at 02:48:45PM +0000, Helge Kreutzmann wrote:
> > > Without further ado, the following was found:
> > > 
> > > Issue:    double space before "after"
> > 
> > I can't see that.  Can you please check?
> 
> > > "The contents of I</etc/motd> are displayed by B<login>(1)  after a "
> > > "successful login but just before it executes the login shell."
> 
> I see the double space in our po file, but I cannot deduce how it is
> created there, maybe a po4a artefact?

Possibly; if you report a bug to the po4a, feel free to CC me.

> So please disregard this issue, I mark it accordingly for our
> translator.
> 
> Greetings
> 
>            Helge

Cheers,
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Mario Blättermann]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Hello,

Am So., 31. Aug. 2025 um 14:11 Uhr schrieb Alejandro Colomar <alx@kernel.org>:
>
> Hi Helge,
>
> On Sun, Aug 31, 2025 at 11:42:49AM +0000, Helge Kreutzmann wrote:
> > Hello Alejandro,
> > Am Sun, Aug 31, 2025 at 01:33:46PM +0200 schrieb Alejandro Colomar:
> > > On Sun, Aug 24, 2025 at 02:48:45PM +0000, Helge Kreutzmann wrote:
> > > > Without further ado, the following was found:
> > > >
> > > > Issue:    double space before "after"
> > >
> > > I can't see that.  Can you please check?
> >
> > > > "The contents of I</etc/motd> are displayed by B<login>(1)  after a "
> > > > "successful login but just before it executes the login shell."
> >
> > I see the double space in our po file, but I cannot deduce how it is
> > created there, maybe a po4a artefact?
>
> Possibly; if you report a bug to the po4a, feel free to CC me.
>
> > So please disregard this issue, I mark it accordingly for our
> > translator.
> >
> > Greetings
> >
> >            Helge
>
> Cheers,
> Alex
>
Yes, maybe a bug in po4a… Currently, the line break after ".BR login
(1)" obviously causes the double space. Without further digging into
the Po4a sources, I found a workaround for this. See the attached
patch. But it is based on the Git repo of manpages-l10n, so it cannot
be applied directly. It's quite simple; you'll see what I mean.

Cheers,
Mario

[-- Attachment #2: motd-patch --]
[-- Type: application/octet-stream, Size: 659 bytes --]

diff --git a/upstream/fedora-rawhide/man5/motd.5 b/upstream/fedora-rawhide/man5/motd.5
index deb24cec070..f409c7d39df 100644
--- a/upstream/fedora-rawhide/man5/motd.5
+++ b/upstream/fedora-rawhide/man5/motd.5
@@ -11,9 +11,7 @@ motd \- message of the day
 .SH DESCRIPTION
 The contents of
 .I /etc/motd
-are displayed by
-.BR login (1)
-after a successful login but just before it executes the login shell.
+are displayed by \fBlogin\fP(1) after a successful login but just before it executes the login shell.
 .P
 The abbreviation "motd" stands for "message of the day", and this file
 has been traditionally used for exactly that (it requires much less disk

Re: Issue in man page motd.5

[Alejandro Colomar]

Hi Mario,

On Sun, Aug 31, 2025 at 02:56:18PM +0200, Mario Blättermann wrote:
> Yes, maybe a bug in po4a… Currently, the line break after ".BR login
> (1)" obviously causes the double space. Without further digging into
> the Po4a sources, I found a workaround for this. See the attached
> patch. But it is based on the Git repo of manpages-l10n, so it cannot
> be applied directly. It's quite simple; you'll see what I mean.

> -are displayed by
> -.BR login (1)
> -after a successful login but just before it executes the login shell.
> +are displayed by \fBlogin\fP(1) after a successful login but just before it executes the login shell.

Yup, I see what you mean.  However, I certainly dislike that approach.
I've done a lot of work removing that kind of pattern in existing manual
pages, and don't want to reintroduce it.  Please fix po4a instead.


Have a lovely day!
Alex

P.S.:  Sorry; no time to PGP-sign this email.

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

Re: Issue in man page motd.5

[G. Branden Robinson]

[-- Attachment #1: Type: text/plain, Size: 2465 bytes --]

At 2025-08-31T14:56:18+0200, Mario Blättermann wrote:
> Yes, maybe a bug in po4a… Currently, the line break after ".BR login
> (1)" obviously causes the double space. Without further digging into
> the Po4a sources, I found a workaround for this. See the attached
> patch. But it is based on the Git repo of manpages-l10n, so it cannot
> be applied directly. It's quite simple; you'll see what I mean.

Unfortunately this proposed patch regresses progress toward using only
man(7) macro calls for rendering man page cross references.

The idea is that we can then automatically rewrite the thousands of `BR`
calls to use groff 1.23.0 man(7)'s `MR` macro, which enables hyperlinked
man page cross references.

groff_man(7):
     .MR topic [manual‐section [trailing‐text]]
            (since groff 1.23) Set a man page cross reference as
            “topic(manual‐section)”.  If manual‐section is absent, the
            package omits the surrounding parentheses.  If trailing‐text
            (typically punctuation) is specified, it follows the closing
            parenthesis without intervening space.  Hyphenation is
            disabled while the cross reference is set.  topic is set in
            the font specified by the MF string.  If manual‐section is
            present, the cross reference hyperlinks to a URI of the form
            “man:topic(manual‐section)”.

(Alex is still waiting on me for a revised submission of heavy
sed(1)-lifting to automatically rewrite (primarily) the syscalls(2)
page, which is gigantic and contains many cross references inside a
tbl(1) region.[1])

Regards,
Branden

[1] I think Alex and I left off here...

    https://lore.kernel.org/linux-man/eogsohjuaxoouiod2ijvkmc2oiipcv3eefjgxj4xeajecu6rdl@wwjfk5i3hgtv/

    But there's some good news--as of about 2 weeks ago, groff 1.23.0 is
    now in Debian's stable release, so groff 1.22.4 and the
    approximately 434 bugs in it are truly starting to fade away.

    https://savannah.gnu.org/bugs/index.php?go_report=Apply&group=groff&func=browse&set=custom&msort=0&report_id=225&advsrch=0&bug_id=&submitted_by=0&category_id=0&severity=0&bug_group_id=0&resolution_id=0&assigned_to=0&status_id=3&plan_release_id=103&summary=&history_search=0&history_field=0&history_event=modified&history_date_dayfd=31&history_date_monthfd=8&history_date_yearfd=2025&max_rows=50&spamscore=5&boxoptionwanted=1#options

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Helge Kreutzmann]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

Hello Branden,
Am Sun, Aug 31, 2025 at 08:30:55AM -0500 schrieb G. Branden Robinson:
> At 2025-08-31T14:56:18+0200, Mario Blättermann wrote:
> (Alex is still waiting on me for a revised submission of heavy
> sed(1)-lifting to automatically rewrite (primarily) the syscalls(2)
> page, which is gigantic and contains many cross references inside a
> tbl(1) region.[1])

If you can share the sed script afterwards, this would be highly
appreciated. Maybe I can adapt it for manpages-l10n as well, this 
page is translated (at least partially) into 7 of our languages.

Greetings

           Helge

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi Helge,

On Sun, Aug 31, 2025 at 01:37:12PM +0000, Helge Kreutzmann wrote:
> Hello Branden,
> Am Sun, Aug 31, 2025 at 08:30:55AM -0500 schrieb G. Branden Robinson:
> > At 2025-08-31T14:56:18+0200, Mario Blättermann wrote:
> > (Alex is still waiting on me for a revised submission of heavy
> > sed(1)-lifting to automatically rewrite (primarily) the syscalls(2)
> > page, which is gigantic and contains many cross references inside a
> > tbl(1) region.[1])
> 
> If you can share the sed script afterwards, this would be highly
> appreciated. Maybe I can adapt it for manpages-l10n as well, this 
> page is translated (at least partially) into 7 of our languages.

Every commit that is scripted, I include the script entirely in the
commit message.  Don't worry about that.  ;)


Cheers,
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[G. Branden Robinson]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

At 2025-08-31T13:37:12+0000, Helge Kreutzmann wrote:
> Hello Branden,
> Am Sun, Aug 31, 2025 at 08:30:55AM -0500 schrieb G. Branden Robinson:
> > At 2025-08-31T14:56:18+0200, Mario Blättermann wrote:
> > (Alex is still waiting on me for a revised submission of heavy
> > sed(1)-lifting to automatically rewrite (primarily) the syscalls(2)
> > page, which is gigantic and contains many cross references inside a
> > tbl(1) region.[1])
> 
> If you can share the sed script afterwards, this would be highly
> appreciated. Maybe I can adapt it for manpages-l10n as well, this 
> page is translated (at least partially) into 7 of our languages.

Certainly.  In fact, I've found I _have_ to share it (strictly,
them--multiple scripts must be run in series) so that Alex can run them
himself.  Attempting to submit a diff of some stages of the
transformation of syscalls(2) blows past the attachment size limit of
the linux-man mail server, even when aggressively compressed.

https://lore.kernel.org/linux-man/20240114154225.5tyuiqrgwyltqmj3@illithid/

Regards,
Branden

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Issue in man page motd.5

[Helge Kreutzmann]

Without further ado, the following was found:

Issue:    Missing full stop

"On Debian GNU/Linux, dynamic content configured at I</etc/pam.d/login> is "
"also displayed by I<pam_exec>"

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

[To += Debian developers]

Hi Helge,

On Sun, Nov 17, 2024 at 10:46:21AM GMT, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    Missing full stop
> 
> "On Debian GNU/Linux, dynamic content configured at I</etc/pam.d/login> is "
> "also displayed by I<pam_exec>"

That's a bug in a downstream patch from Debian.  See the patch below.
In that patch,

	+.I pam_exec

should become

	+.IP pam_exec .

Woever does that change, please add:

	Reported-by: Helge Kreutzmann <debian@helgefjell.de>
	Reported-by: Alejandro Colomar <alx@kernel.org>
	Suggested-by: Alejandro Colomar <alx@kernel.org>

Have a lovely day!
Alex


alx@debian:~/src/debian/doc/manpages/debian/latest/debian/patches$ cat 0007-motd.5.patch 
From: "Dr. Tobias Quathamer" <toddy@debian.org>
Date: Sat, 6 Feb 2016 01:22:57 +0100
Subject: motd.5

---
 man/man5/motd.5 | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/man/man5/motd.5 b/man/man5/motd.5
index 9de8eea..2ddfae3 100644
--- a/man/man5/motd.5
+++ b/man/man5/motd.5
@@ -12,12 +12,20 @@ motd \- message of the day
 The contents of
 .I /etc/motd
 are displayed by
-.BR login (1)
+.\" Patched in Debian, maybe other distribs
+.BR pam_motd (8)
+.\" End of patch
+.\" .BR login (1)
 after a successful login but just before it executes the login shell.
 .P
 The abbreviation "motd" stands for "message of the day", and this file
 has been traditionally used for exactly that (it requires much less disk
 space than mail to all users).
+.P
+On Debian GNU/Linux, dynamic content configured at
+.I /etc/pam.d/login
+is also displayed by
+.I pam_exec
 .SH FILES
 .I /etc/motd
 .SH SEE ALSO


-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Issue in man page motd.5

[Helge Kreutzmann]

Without further ado, the following was found:

Issue:    B<issue>(5)  B<pam_motd>(8) → B<issue>(5), B<pam_motd>(8)

"B<login>(1), B<issue>(5)  B<pam_motd>(8)"

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Hi Helge,

On Wed, Nov 01, 2023 at 02:02:11PM +0000, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    B<issue>(5)  B<pam_motd>(8) → B<issue>(5), B<pam_motd>(8)
> 
> "B<login>(1), B<issue>(5)  B<pam_motd>(8)"

I don't understand the report.  I don't find any pam_motd reference in
motd(5).  See below:

$ grep pam_motd man5/motd.5 
$ git log -S pam_motd -- man5/motd.5
$


Cheers,
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Issue in man page motd.5

[Helge Kreutzmann]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hello Alejandro,
Am Wed, Nov 01, 2023 at 04:47:02PM +0100 schrieb Alejandro Colomar:
> On Wed, Nov 01, 2023 at 02:02:11PM +0000, Helge Kreutzmann wrote:
> > Without further ado, the following was found:
> > 
> > Issue:    B<issue>(5)  B<pam_motd>(8) → B<issue>(5), B<pam_motd>(8)
> > 
> > "B<login>(1), B<issue>(5)  B<pam_motd>(8)"
> 
> I don't understand the report.  I don't find any pam_motd reference in
> motd(5).  See below:
> 
> $ grep pam_motd man5/motd.5 
> $ git log -S pam_motd -- man5/motd.5
> $

Then disregard this report and I need to check where this man page
actually comes from. Probably assigned here by error.

Greetings

        Helge

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Issue in man page motd.5

[Helge Kreutzmann]

Without further ado, the following was found:

Issue:    B<issue>(5)  B<pam_motd>(8) → B<issue>(5), B<pam_motd>(8)

"B<login>(1), B<issue>(5)  B<pam_motd>(8)"

Re: Issue in man page motd.5

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]

I can't reproduce.  Please check the origin of the bug report.

On 1/22/23 20:31, Helge Kreutzmann wrote:
> Without further ado, the following was found:
> 
> Issue:    B<issue>(5)  B<pam_motd>(8) → B<issue>(5), B<pam_motd>(8)
> 
> "B<login>(1), B<issue>(5)  B<pam_motd>(8)"

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]