Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alewx,

On 12/30/20 10:41 PM, Alejandro Colomar wrote:
> See glibc's commit: 0ce657c576bf1b24
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
> 
> Reported-by: Jakub Wilk <jwilk@jwilk.net>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>  man3/get_phys_pages.3 | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
> index 35f83fedb..a8a1ce3f4 100644
> --- a/man3/get_phys_pages.3
> +++ b/man3/get_phys_pages.3
> @@ -55,15 +55,20 @@ The system could not provide the required information
>  (possibly because the
>  .I /proc
>  filesystem was not mounted).
> -.SH CONFORMING TO
> -These functions are GNU extensions.
> -.SH NOTES
> -These functions obtain the required information by scanning the
> +.SH VERSIONS
> +Before glibc 2.23,
> +these functions obtained the required information by scanning the
>  .I MemTotal
>  and
>  .I MemFree
>  fields of
>  .IR /proc/meminfo .

Thanks for the patch. But I think it would be better to put 
all the info into NOTES, rather than splitting some out into
VERSIONS.

> +.SH CONFORMING TO
> +These functions are GNU extensions.

And it's good to add this, but let's make it a separate patch.

> +.SH NOTES
> +Since glibc 2.23,
> +these functions obtain the required information by calling
> +.BR sysinfo (2).
>  .PP
>  The following
>  .BR sysconf (3)


Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/