From: <yjjuny.lee@samsung.com>
To: "'Ricardo Ribalda'" <ribalda@chromium.org>
Cc: <laurent.pinchart@ideasonboard.com>, <hdegoede@redhat.com>,
<mchehab@kernel.org>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yjjuny.lee@samsung.com>
Subject: RE: [PATCH] usb: uvc: Fix 1-byte out-of-bounds read in uvc_parse_format()
Date: Tue, 10 Jun 2025 21:33:18 +0900 [thread overview]
Message-ID: <000401dbda03$d86b7680$89426380$@samsung.com> (raw)
In-Reply-To: <CANiDSCtQiiutnqGWwL1u=K4kFavhw0-z=m_Kztr2xRpDUZ+iLA@mail.gmail.com>
Hi Ricardo Ribalda
> I think it makes more sense to add the length check where it is going to be used not on a caller function. If we every change
> uvc_parse_format to read byte #5 we will probably miss the check on
> uvc_parse_streaming()
I agree. Moving the length check into the function itself is a better approach.
I'll send v2 patch.
next prev parent reply other threads:[~2025-06-10 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250610113726epcas1p449116bfeef2a102c90e9519a632eb0b9@epcas1p4.samsung.com>
2025-06-10 11:37 ` [PATCH] usb: uvc: Fix 1-byte out-of-bounds read in uvc_parse_format() Youngjun Lee
2025-06-10 11:56 ` Ricardo Ribalda
2025-06-10 12:33 ` yjjuny.lee [this message]
[not found] <CGME20250610124111epcas1p18fe9fd8ab47a424c2143d4e2912a8179@epcas1p1.samsung.com>
2025-06-10 12:41 ` Youngjun Lee
2025-06-10 12:58 ` Ricardo Ribalda
2025-06-10 21:30 ` Laurent Pinchart
2025-06-11 1:33 ` yjjuny.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401dbda03$d86b7680$89426380$@samsung.com' \
--to=yjjuny.lee@samsung.com \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox