[dvb] Question on dvb-core re-structure

[dvb] Question on dvb-core re-structure

[Hamad Kadmany]

Hi,

With the new structure of dvb-core (moved up one directory), previous
DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.

For SoC that supports integrated DVB functionality, where should the
adapter's code be located in the new structure? I don't see it fit any of
the above three options.

Thanks,

--
Hamad Kadmany,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

Re: [dvb] Question on dvb-core re-structure

[Antti Palosaari]

On 01/10/2013 12:44 PM, Hamad Kadmany wrote:
> Hi,
>
> With the new structure of dvb-core (moved up one directory), previous
> DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.
>
> For SoC that supports integrated DVB functionality, where should the
> adapter's code be located in the new structure? I don't see it fit any of
> the above three options.

I could guess that even for the SoCs there is some bus used internally. 
If it is not one of those already existing, then create new directly 
just like one of those existing and put it there.

regards
Antti

-- 
http://palosaari.fi/

RE: [dvb] Question on dvb-core re-structure

[Hamad Kadmany]

On 01/10/2013 1:13 PM, Antti Palosaari wrote:
> I could guess that even for the SoCs there is some bus used internally. 
> If it is not one of those already existing, then create new directly just
like one of those existing and put it there.

Thanks for the answer. I just wanted to clarify - it's integrated into the
chip and accessed via memory mapped registers, so I'm not sure which
category to give the new directory (parallel to pci/mms/usb). Should I just
put the adapter's sources directory directly under media directory?


Thanks,

--
Hamad Kadmany,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

Re: [dvb] Question on dvb-core re-structure

[Mauro Carvalho Chehab]

Em Thu, 10 Jan 2013 13:49:52 +0200
"Hamad Kadmany" <hkadmany@codeaurora.org> escreveu:

> On 01/10/2013 1:13 PM, Antti Palosaari wrote:
> > I could guess that even for the SoCs there is some bus used internally. 
> > If it is not one of those already existing, then create new directly just
> like one of those existing and put it there.
> 
> Thanks for the answer. I just wanted to clarify - it's integrated into the
> chip and accessed via memory mapped registers, so I'm not sure which
> category to give the new directory (parallel to pci/mms/usb). Should I just
> put the adapter's sources directory directly under media directory?

That's the case of all other drivers under drivers/media/platform: they're
IP blocks inside the SoC chip. I think that all arch-dependent drivers are
there.

The menu needs to be renamed to "Media platform drivers" when the first DVB
driver arrives there (it currently says V4L, as there's no DVB driver there
yet). Feel free to add such patch on your patch series at the time you
submit your driver, if nobody else submit any DVB platform driver earlier
than yours.

Regards,
Mauro

Re: [dvb] Question on dvb-core re-structure

[Ralph Metzler]

Mauro Carvalho Chehab writes:
 > Em Thu, 10 Jan 2013 13:49:52 +0200
 > "Hamad Kadmany" <hkadmany@codeaurora.org> escreveu:
 > 
 > > On 01/10/2013 1:13 PM, Antti Palosaari wrote:
 > > > I could guess that even for the SoCs there is some bus used internally. 
 > > > If it is not one of those already existing, then create new directly just
 > > like one of those existing and put it there.
 > > 
 > > Thanks for the answer. I just wanted to clarify - it's integrated into the
 > > chip and accessed via memory mapped registers, so I'm not sure which
 > > category to give the new directory (parallel to pci/mms/usb). Should I just
 > > put the adapter's sources directory directly under media directory?
 > 
 > That's the case of all other drivers under drivers/media/platform: they're
 > IP blocks inside the SoC chip. I think that all arch-dependent drivers are
 > there.
 > 
 > The menu needs to be renamed to "Media platform drivers" when the first DVB
 > driver arrives there (it currently says V4L, as there's no DVB driver there
 > yet). Feel free to add such patch on your patch series at the time you
 > submit your driver, if nobody else submit any DVB platform driver earlier
 > than yours.


What about DVB cores which can be used via different busses?
E.g. ddbridge initially only used PCIe. Now we also use the same function blocks
(I2C, DVB input, etc.) connected to a SoC via an EBI (extension bus interface) 
and register it as a platform device. Because a lot of code can be
shared I do not want to split it over several directories. 

Regards,
Ralph

Re: [dvb] Question on dvb-core re-structure

[Mauro Carvalho Chehab]

Em Thu, 10 Jan 2013 17:01:57 +0100
Ralph Metzler <rjkm@metzlerbros.de> escreveu:

> Mauro Carvalho Chehab writes:
>  > Em Thu, 10 Jan 2013 13:49:52 +0200
>  > "Hamad Kadmany" <hkadmany@codeaurora.org> escreveu:
>  > 
>  > > On 01/10/2013 1:13 PM, Antti Palosaari wrote:
>  > > > I could guess that even for the SoCs there is some bus used internally. 
>  > > > If it is not one of those already existing, then create new directly just
>  > > like one of those existing and put it there.
>  > > 
>  > > Thanks for the answer. I just wanted to clarify - it's integrated into the
>  > > chip and accessed via memory mapped registers, so I'm not sure which
>  > > category to give the new directory (parallel to pci/mms/usb). Should I just
>  > > put the adapter's sources directory directly under media directory?
>  > 
>  > That's the case of all other drivers under drivers/media/platform: they're
>  > IP blocks inside the SoC chip. I think that all arch-dependent drivers are
>  > there.
>  > 
>  > The menu needs to be renamed to "Media platform drivers" when the first DVB
>  > driver arrives there (it currently says V4L, as there's no DVB driver there
>  > yet). Feel free to add such patch on your patch series at the time you
>  > submit your driver, if nobody else submit any DVB platform driver earlier
>  > than yours.
> 
> 
> What about DVB cores which can be used via different busses?
> E.g. ddbridge initially only used PCIe. Now we also use the same function blocks
> (I2C, DVB input, etc.) connected to a SoC via an EBI (extension bus interface) 
> and register it as a platform device. Because a lot of code can be
> shared I do not want to split it over several directories. 

What we're doing on such cases is to put the common stuff under drivers/media/common
and the bus-specific (or platform-specific) code under drivers/media/pci,
drivers/media/usb, drivers/media/mmc, etc. There are, currenlty, 3 drivers
like that: saa7146 (the common code were always stored at /common), b2c2 and siano.

Cheers,
Mauro

Re: [dvb] Question on dvb-core re-structure

[Mauro Carvalho Chehab]

Em Thu, 10 Jan 2013 12:44:14 +0200
"Hamad Kadmany" <hkadmany@codeaurora.org> escreveu:

> Hi,
> 
> With the new structure of dvb-core (moved up one directory), previous
> DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.
> 
> For SoC that supports integrated DVB functionality, where should the
> adapter's code be located in the new structure? I don't see it fit any of
> the above three options.

It should be inside drivers/media/platform.

Regards,
Mauro