From: "Sébastien RAILLARD (COEXSI)" <sr@coexsi.fr>
To: "'Andreas Oberritter'" <obi@linuxtv.org>,
"'Tomer Barletz'" <barletz@gmail.com>
Cc: "'Brice DUBOST'" <braice@braice.net>, <linux-media@vger.kernel.org>
Subject: RE: [libdvben50221] [PATCH] Assign same resource_id in open_session_response when "resource non-existent"
Date: Thu, 19 May 2011 23:01:30 +0200 [thread overview]
Message-ID: <005501cc1667$ee99a130$cbcce390$@coexsi.fr> (raw)
In-Reply-To: <4DD513F5.8060602@linuxtv.org>
> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Andreas Oberritter
> Sent: jeudi 19 mai 2011 14:58
> To: Tomer Barletz
> Cc: Brice DUBOST; linux-media@vger.kernel.org
> Subject: Re: [libdvben50221] [PATCH] Assign same resource_id in
> open_session_response when "resource non-existent"
>
> On 05/18/2011 09:16 PM, Tomer Barletz wrote:
> > On Tue, May 17, 2011 at 8:46 AM, Brice DUBOST <braice@braice.net>
> wrote:
> >> On 18/01/2011 15:42, Tomer Barletz wrote:
> >>> Attached a patch for a bug in the lookup_callback function, were in
> >>> case of a non-existent resource, the connected_resource_id is not
> >>> initialized and then used in the open_session_response call of the
> >>> session layer.
> >>>
> >>
> >> Hello
> >>
> >> Can you explain what kind of bug it fixes ?
> >>
> >> Thanks
> >>
> >
> > The standard states that in case the module can't provide the
> > requested resource , it should reply with the same resource id - this
> > is the only line that was added.
> > Also, since the caller to this function might use the variable
> > returned, this variable must be initialized.
> > The attached patch solves both bugs.
>
> Can you please resend the patch inline with a proper signed-off-by line,
> in order to get it tracked by patchwork.kernel.org?
>
Yes, of course, but I don't find information that can help me to provide the
correct format.
Is-there a documentation somewhere that explains how patches must be
formatted to be correctly tracked?
> Regards,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media"
> in the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-19 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 14:42 [libdvben50221] [PATCH] Assign same resource_id in open_session_response when "resource non-existent" Tomer Barletz
2011-05-17 15:46 ` Brice DUBOST
2011-05-18 19:16 ` Tomer Barletz
2011-05-19 12:58 ` Andreas Oberritter
2011-05-19 21:01 ` Sébastien RAILLARD (COEXSI) [this message]
2011-05-19 22:18 ` Issa Gorissen
2011-05-23 17:55 ` Tomer Barletz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005501cc1667$ee99a130$cbcce390$@coexsi.fr' \
--to=sr@coexsi.fr \
--cc=barletz@gmail.com \
--cc=braice@braice.net \
--cc=linux-media@vger.kernel.org \
--cc=obi@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox