* [PATCH] media: i2c: add ov01a10 image sensor driver
@ 2023-02-09 11:22 Bingbu Cao
2023-02-09 12:40 ` Dave Stevenson
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Bingbu Cao @ 2023-02-09 11:22 UTC (permalink / raw)
To: linux-media, sakari.ailus; +Cc: bingbu.cao, bingbu.cao, yating.wang
Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Yating Wang <yating.wang@intel.com>
---
drivers/media/i2c/Kconfig | 13 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 920 insertions(+)
create mode 100644 drivers/media/i2c/ov01a10.c
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 833241897d63..8e5d1ef0616f 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -338,6 +338,19 @@ config VIDEO_OG01A1B
To compile this driver as a module, choose M here: the
module will be called og01a1b.
+config VIDEO_OV01A10
+ tristate "OmniVision OV01A10 sensor support"
+ depends on VIDEO_DEV && I2C
+ select MEDIA_CONTROLLER
+ select VIDEO_V4L2_SUBDEV_API
+ select V4L2_FWNODE
+ help
+ This is a Video4Linux2 sensor driver for the OmniVision
+ OV01A10 camera.
+
+ To compile this driver as a module, choose M here: the
+ module will be called ov01a10.
+
config VIDEO_OV02A10
tristate "OmniVision OV02A10 sensor support"
depends on VIDEO_DEV && I2C
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 4d6c052bb5a7..ce214503b526 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o
obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o
obj-$(CONFIG_VIDEO_NOON010PC30) += noon010pc30.o
obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o
+obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o
obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o
obj-$(CONFIG_VIDEO_OV08D10) += ov08d10.o
obj-$(CONFIG_VIDEO_OV08X40) += ov08x40.o
diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
new file mode 100644
index 000000000000..13de9f9ccdc8
--- /dev/null
+++ b/drivers/media/i2c/ov01a10.c
@@ -0,0 +1,906 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020-2021 Intel Corporation.
+
+#include <asm/unaligned.h>
+
+#include <linux/acpi.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/pm_runtime.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-event.h>
+#include <media/v4l2-fwnode.h>
+
+#define OV01A10_LINK_FREQ_400MHZ 400000000ULL
+#define OV01A10_SCLK 40000000LL
+#define OV01A10_MCLK 19200000
+#define OV01A10_DATA_LANES 1
+#define OV01A10_RGB_DEPTH 10
+
+#define OV01A10_REG_CHIP_ID 0x300a
+#define OV01A10_CHIP_ID 0x560141
+
+#define OV01A10_REG_MODE_SELECT 0x0100
+#define OV01A10_MODE_STANDBY 0x00
+#define OV01A10_MODE_STREAMING 0x01
+
+/* vertical timings */
+#define OV01A10_REG_VTS 0x380e
+#define OV01A10_VTS_DEF 0x0380
+#define OV01A10_VTS_MIN 0x0380
+#define OV01A10_VTS_MAX 0xffff
+
+/* exposure controls */
+#define OV01A10_REG_EXPOSURE 0x3501
+#define OV01A10_EXPOSURE_MIN 4
+#define OV01A10_EXPOSURE_MAX_MARGIN 8
+#define OV01A10_EXPOSURE_STEP 1
+
+/* analog gain controls */
+#define OV01A10_REG_ANALOG_GAIN 0x3508
+#define OV01A10_ANAL_GAIN_MIN 0x100
+#define OV01A10_ANAL_GAIN_MAX 0xffff
+#define OV01A10_ANAL_GAIN_STEP 1
+
+/* digital gain controls */
+#define OV01A10_REG_DIGILAL_GAIN_B 0x350A
+#define OV01A10_REG_DIGITAL_GAIN_GB 0x3510
+#define OV01A10_REG_DIGITAL_GAIN_GR 0x3513
+#define OV01A10_REG_DIGITAL_GAIN_R 0x3516
+#define OV01A10_DGTL_GAIN_MIN 0
+#define OV01A10_DGTL_GAIN_MAX 0x3ffff
+#define OV01A10_DGTL_GAIN_STEP 1
+#define OV01A10_DGTL_GAIN_DEFAULT 1024
+
+/* test pattern control */
+#define OV01A10_REG_TEST_PATTERN 0x4503
+#define OV01A10_TEST_PATTERN_ENABLE BIT(7)
+#define OV01A10_TEST_PATTERN_BAR_SHIFT 0
+
+enum {
+ OV01A10_LINK_FREQ_400MHZ_INDEX,
+};
+
+struct ov01a10_reg {
+ u16 address;
+ u8 val;
+};
+
+struct ov01a10_reg_list {
+ u32 num_of_regs;
+ const struct ov01a10_reg *regs;
+};
+
+struct ov01a10_link_freq_config {
+ const struct ov01a10_reg_list reg_list;
+};
+
+struct ov01a10_mode {
+ u32 width;
+ u32 height;
+ u32 hts;
+ u32 vts_def;
+ u32 vts_min;
+ u32 link_freq_index;
+
+ const struct ov01a10_reg_list reg_list;
+};
+
+static const struct ov01a10_reg mipi_data_rate_720mbps[] = {
+};
+
+static const struct ov01a10_reg sensor_1280x800_setting[] = {
+ {0x0103, 0x01},
+ {0x0302, 0x00},
+ {0x0303, 0x06},
+ {0x0304, 0x01},
+ {0x0305, 0xe0},
+ {0x0306, 0x00},
+ {0x0308, 0x01},
+ {0x0309, 0x00},
+ {0x030c, 0x01},
+ {0x0322, 0x01},
+ {0x0323, 0x06},
+ {0x0324, 0x01},
+ {0x0325, 0x68},
+ {0x3002, 0xa1},
+ {0x301e, 0xf0},
+ {0x3022, 0x01},
+ {0x3501, 0x03},
+ {0x3502, 0x78},
+ {0x3504, 0x0c},
+ {0x3508, 0x01},
+ {0x3509, 0x00},
+ {0x3601, 0xc0},
+ {0x3603, 0x71},
+ {0x3610, 0x68},
+ {0x3611, 0x86},
+ {0x3640, 0x10},
+ {0x3641, 0x80},
+ {0x3642, 0xdc},
+ {0x3646, 0x55},
+ {0x3647, 0x57},
+ {0x364b, 0x00},
+ {0x3653, 0x10},
+ {0x3655, 0x00},
+ {0x3656, 0x00},
+ {0x365f, 0x0f},
+ {0x3661, 0x45},
+ {0x3662, 0x24},
+ {0x3663, 0x11},
+ {0x3664, 0x07},
+ {0x3709, 0x34},
+ {0x370b, 0x6f},
+ {0x3714, 0x22},
+ {0x371b, 0x27},
+ {0x371c, 0x67},
+ {0x371d, 0xa7},
+ {0x371e, 0xe7},
+ {0x3730, 0x81},
+ {0x3733, 0x10},
+ {0x3734, 0x40},
+ {0x3737, 0x04},
+ {0x3739, 0x1c},
+ {0x3767, 0x00},
+ {0x376c, 0x81},
+ {0x3772, 0x14},
+ {0x37c2, 0x04},
+ {0x37d8, 0x03},
+ {0x37d9, 0x0c},
+ {0x37e0, 0x00},
+ {0x37e1, 0x08},
+ {0x37e2, 0x10},
+ {0x37e3, 0x04},
+ {0x37e4, 0x04},
+ {0x37e5, 0x03},
+ {0x37e6, 0x04},
+ {0x3800, 0x00},
+ {0x3801, 0x00},
+ {0x3802, 0x00},
+ {0x3803, 0x00},
+ {0x3804, 0x05},
+ {0x3805, 0x0f},
+ {0x3806, 0x03},
+ {0x3807, 0x2f},
+ {0x3808, 0x05},
+ {0x3809, 0x00},
+ {0x380a, 0x03},
+ {0x380b, 0x20},
+ {0x380c, 0x02},
+ {0x380d, 0xe8},
+ {0x380e, 0x03},
+ {0x380f, 0x80},
+ {0x3810, 0x00},
+ {0x3811, 0x09},
+ {0x3812, 0x00},
+ {0x3813, 0x08},
+ {0x3814, 0x01},
+ {0x3815, 0x01},
+ {0x3816, 0x01},
+ {0x3817, 0x01},
+ {0x3820, 0xa8},
+ {0x3822, 0x13},
+ {0x3832, 0x28},
+ {0x3833, 0x10},
+ {0x3b00, 0x00},
+ {0x3c80, 0x00},
+ {0x3c88, 0x02},
+ {0x3c8c, 0x07},
+ {0x3c8d, 0x40},
+ {0x3cc7, 0x80},
+ {0x4000, 0xc3},
+ {0x4001, 0xe0},
+ {0x4003, 0x40},
+ {0x4008, 0x02},
+ {0x4009, 0x19},
+ {0x400a, 0x01},
+ {0x400b, 0x6c},
+ {0x4011, 0x00},
+ {0x4041, 0x00},
+ {0x4300, 0xff},
+ {0x4301, 0x00},
+ {0x4302, 0x0f},
+ {0x4503, 0x00},
+ {0x4601, 0x50},
+ {0x4800, 0x64},
+ {0x481f, 0x34},
+ {0x4825, 0x33},
+ {0x4837, 0x11},
+ {0x4881, 0x40},
+ {0x4883, 0x01},
+ {0x4890, 0x00},
+ {0x4901, 0x00},
+ {0x4902, 0x00},
+ {0x4b00, 0x2a},
+ {0x4b0d, 0x00},
+ {0x450a, 0x04},
+ {0x450b, 0x00},
+ {0x5000, 0x65},
+ {0x5200, 0x18},
+ {0x5004, 0x00},
+ {0x5080, 0x40},
+ {0x0305, 0xf4},
+ {0x0325, 0xc2},
+};
+
+static const char * const ov01a10_test_pattern_menu[] = {
+ "Disabled",
+ "Color Bar",
+ "Top-Bottom Darker Color Bar",
+ "Right-Left Darker Color Bar",
+ "Color Bar type 4",
+};
+
+static const s64 link_freq_menu_items[] = {
+ OV01A10_LINK_FREQ_400MHZ,
+};
+
+static const struct ov01a10_link_freq_config link_freq_configs[] = {
+ [OV01A10_LINK_FREQ_400MHZ_INDEX] = {
+ .reg_list = {
+ .num_of_regs = ARRAY_SIZE(mipi_data_rate_720mbps),
+ .regs = mipi_data_rate_720mbps,
+ }
+ },
+};
+
+static const struct ov01a10_mode supported_modes[] = {
+ {
+ .width = 1280,
+ .height = 800,
+ .hts = 1488,
+ .vts_def = OV01A10_VTS_DEF,
+ .vts_min = OV01A10_VTS_MIN,
+ .reg_list = {
+ .num_of_regs = ARRAY_SIZE(sensor_1280x800_setting),
+ .regs = sensor_1280x800_setting,
+ },
+ .link_freq_index = OV01A10_LINK_FREQ_400MHZ_INDEX,
+ },
+};
+
+struct ov01a10 {
+ struct v4l2_subdev sd;
+ struct media_pad pad;
+ struct v4l2_ctrl_handler ctrl_handler;
+
+ /* v4l2 controls */
+ struct v4l2_ctrl *link_freq;
+ struct v4l2_ctrl *pixel_rate;
+ struct v4l2_ctrl *vblank;
+ struct v4l2_ctrl *hblank;
+ struct v4l2_ctrl *exposure;
+
+ const struct ov01a10_mode *cur_mode;
+
+ /* serialize asynchronous callbacks */
+ struct mutex mutex;
+
+ /* streaming state */
+ bool streaming;
+};
+
+static inline struct ov01a10 *to_ov01a10(struct v4l2_subdev *subdev)
+{
+ return container_of(subdev, struct ov01a10, sd);
+}
+
+static int ov01a10_read_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 *val)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ struct i2c_msg msgs[2];
+ u8 addr_buf[2];
+ u8 data_buf[4] = {0};
+ int ret = 0;
+
+ if (len > sizeof(data_buf))
+ return -EINVAL;
+
+ put_unaligned_be16(reg, addr_buf);
+ msgs[0].addr = client->addr;
+ msgs[0].flags = 0;
+ msgs[0].len = sizeof(addr_buf);
+ msgs[0].buf = addr_buf;
+ msgs[1].addr = client->addr;
+ msgs[1].flags = I2C_M_RD;
+ msgs[1].len = len;
+ msgs[1].buf = &data_buf[sizeof(data_buf) - len];
+
+ ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
+
+ if (ret != ARRAY_SIZE(msgs))
+ return ret < 0 ? ret : -EIO;
+
+ *val = get_unaligned_be32(data_buf);
+
+ return 0;
+}
+
+static int ov01a10_write_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 val)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ u8 buf[6];
+ int ret = 0;
+
+ if (len > 4)
+ return -EINVAL;
+
+ put_unaligned_be16(reg, buf);
+ put_unaligned_be32(val << 8 * (4 - len), buf + 2);
+
+ ret = i2c_master_send(client, buf, len + 2);
+ if (ret != len + 2)
+ return ret < 0 ? ret : -EIO;
+
+ return 0;
+}
+
+static int ov01a10_write_reg_list(struct ov01a10 *ov01a10,
+ const struct ov01a10_reg_list *r_list)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ unsigned int i;
+ int ret = 0;
+
+ for (i = 0; i < r_list->num_of_regs; i++) {
+ ret = ov01a10_write_reg(ov01a10, r_list->regs[i].address, 1,
+ r_list->regs[i].val);
+ if (ret) {
+ dev_err_ratelimited(&client->dev,
+ "write reg 0x%4.4x return err = %d",
+ r_list->regs[i].address, ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
+static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ u32 real = d_gain << 6;
+ int ret = 0;
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGILAL_GAIN_B, 3, real);
+ if (ret) {
+ dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_B");
+ return ret;
+ }
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GB, 3, real);
+ if (ret) {
+ dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GB");
+ return ret;
+ }
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GR, 3, real);
+ if (ret) {
+ dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GR");
+ return ret;
+ }
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_R, 3, real);
+ if (ret) {
+ dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_R");
+ return ret;
+ }
+
+ return ret;
+}
+
+static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern)
+{
+ if (pattern)
+ pattern = (pattern - 1) << OV01A10_TEST_PATTERN_BAR_SHIFT |
+ OV01A10_TEST_PATTERN_ENABLE;
+
+ return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern);
+}
+
+static int ov01a10_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+ struct ov01a10 *ov01a10 = container_of(ctrl->handler,
+ struct ov01a10, ctrl_handler);
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ s64 exposure_max;
+ int ret = 0;
+
+ if (ctrl->id == V4L2_CID_VBLANK) {
+ exposure_max = ov01a10->cur_mode->height + ctrl->val -
+ OV01A10_EXPOSURE_MAX_MARGIN;
+ __v4l2_ctrl_modify_range(ov01a10->exposure,
+ ov01a10->exposure->minimum,
+ exposure_max, ov01a10->exposure->step,
+ exposure_max);
+ }
+
+ if (!pm_runtime_get_if_in_use(&client->dev))
+ return 0;
+
+ switch (ctrl->id) {
+ case V4L2_CID_ANALOGUE_GAIN:
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_ANALOG_GAIN, 2,
+ ctrl->val);
+ break;
+
+ case V4L2_CID_DIGITAL_GAIN:
+ ret = ov01a10_update_digital_gain(ov01a10, ctrl->val);
+ break;
+
+ case V4L2_CID_EXPOSURE:
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_EXPOSURE, 2,
+ ctrl->val);
+ break;
+
+ case V4L2_CID_VBLANK:
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_VTS, 2,
+ ov01a10->cur_mode->height + ctrl->val);
+ break;
+
+ case V4L2_CID_TEST_PATTERN:
+ ret = ov01a10_test_pattern(ov01a10, ctrl->val);
+ break;
+
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ pm_runtime_put(&client->dev);
+
+ return ret;
+}
+
+static const struct v4l2_ctrl_ops ov01a10_ctrl_ops = {
+ .s_ctrl = ov01a10_set_ctrl,
+};
+
+static int ov01a10_init_controls(struct ov01a10 *ov01a10)
+{
+ struct v4l2_ctrl_handler *ctrl_hdlr;
+ const struct ov01a10_mode *cur_mode;
+ s64 exposure_max, h_blank;
+ u32 vblank_min, vblank_max, vblank_default;
+ int size;
+ int ret = 0;
+
+ ctrl_hdlr = &ov01a10->ctrl_handler;
+ ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
+ if (ret)
+ return ret;
+
+ ctrl_hdlr->lock = &ov01a10->mutex;
+ cur_mode = ov01a10->cur_mode;
+ size = ARRAY_SIZE(link_freq_menu_items);
+
+ ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
+ &ov01a10_ctrl_ops,
+ V4L2_CID_LINK_FREQ,
+ size - 1, 0,
+ link_freq_menu_items);
+ if (ov01a10->link_freq)
+ ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+ ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
+ V4L2_CID_PIXEL_RATE, 0,
+ OV01A10_SCLK, 1, OV01A10_SCLK);
+
+ vblank_min = cur_mode->vts_min - cur_mode->height;
+ vblank_max = OV01A10_VTS_MAX - cur_mode->height;
+ vblank_default = cur_mode->vts_def - cur_mode->height;
+ ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
+ V4L2_CID_VBLANK, vblank_min,
+ vblank_max, 1, vblank_default);
+
+ h_blank = cur_mode->hts - cur_mode->width;
+ ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
+ V4L2_CID_HBLANK, h_blank, h_blank,
+ 1, h_blank);
+ if (ov01a10->hblank)
+ ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+ v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
+ OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
+ OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
+ v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
+ OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
+ OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
+ exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
+ ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
+ V4L2_CID_EXPOSURE,
+ OV01A10_EXPOSURE_MIN,
+ exposure_max,
+ OV01A10_EXPOSURE_STEP,
+ exposure_max);
+ v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
+ V4L2_CID_TEST_PATTERN,
+ ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
+ 0, 0, ov01a10_test_pattern_menu);
+ if (ctrl_hdlr->error)
+ return ctrl_hdlr->error;
+
+ ov01a10->sd.ctrl_handler = ctrl_hdlr;
+
+ return 0;
+}
+
+static void ov01a10_update_pad_format(const struct ov01a10_mode *mode,
+ struct v4l2_mbus_framefmt *fmt)
+{
+ fmt->width = mode->width;
+ fmt->height = mode->height;
+ fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
+ fmt->field = V4L2_FIELD_NONE;
+}
+
+static int ov01a10_start_streaming(struct ov01a10 *ov01a10)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ const struct ov01a10_reg_list *reg_list;
+ int link_freq_index;
+ int ret = 0;
+
+ link_freq_index = ov01a10->cur_mode->link_freq_index;
+ reg_list = &link_freq_configs[link_freq_index].reg_list;
+ ret = ov01a10_write_reg_list(ov01a10, reg_list);
+ if (ret) {
+ dev_err(&client->dev, "failed to set plls\n");
+ return ret;
+ }
+
+ reg_list = &ov01a10->cur_mode->reg_list;
+ ret = ov01a10_write_reg_list(ov01a10, reg_list);
+ if (ret) {
+ dev_err(&client->dev, "failed to set mode\n");
+ return ret;
+ }
+
+ ret = __v4l2_ctrl_handler_setup(ov01a10->sd.ctrl_handler);
+ if (ret)
+ return ret;
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
+ OV01A10_MODE_STREAMING);
+ if (ret)
+ dev_err(&client->dev, "failed to start streaming\n");
+
+ return ret;
+}
+
+static void ov01a10_stop_streaming(struct ov01a10 *ov01a10)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ int ret = 0;
+
+ ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
+ OV01A10_MODE_STANDBY);
+ if (ret)
+ dev_err(&client->dev, "failed to stop streaming");
+
+}
+
+static int ov01a10_set_stream(struct v4l2_subdev *sd, int enable)
+{
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+ struct i2c_client *client = v4l2_get_subdevdata(sd);
+ int ret = 0;
+
+ if (ov01a10->streaming == enable)
+ return 0;
+
+ mutex_lock(&ov01a10->mutex);
+ if (enable) {
+ ret = pm_runtime_get_sync(&client->dev);
+ if (ret < 0) {
+ pm_runtime_put_noidle(&client->dev);
+ mutex_unlock(&ov01a10->mutex);
+ return ret;
+ }
+
+ ret = ov01a10_start_streaming(ov01a10);
+ if (ret) {
+ enable = 0;
+ ov01a10_stop_streaming(ov01a10);
+ pm_runtime_put(&client->dev);
+ }
+ } else {
+ ov01a10_stop_streaming(ov01a10);
+ pm_runtime_put(&client->dev);
+ }
+
+ ov01a10->streaming = enable;
+ mutex_unlock(&ov01a10->mutex);
+
+ return ret;
+}
+
+static int __maybe_unused ov01a10_suspend(struct device *dev)
+{
+ struct i2c_client *client = to_i2c_client(dev);
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+
+ mutex_lock(&ov01a10->mutex);
+ if (ov01a10->streaming)
+ ov01a10_stop_streaming(ov01a10);
+
+ mutex_unlock(&ov01a10->mutex);
+
+ return 0;
+}
+
+static int __maybe_unused ov01a10_resume(struct device *dev)
+{
+ struct i2c_client *client = to_i2c_client(dev);
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+ int ret = 0;
+
+ mutex_lock(&ov01a10->mutex);
+ if (!ov01a10->streaming)
+ goto exit;
+
+ ret = ov01a10_start_streaming(ov01a10);
+ if (ret) {
+ ov01a10->streaming = false;
+ ov01a10_stop_streaming(ov01a10);
+ }
+
+exit:
+ mutex_unlock(&ov01a10->mutex);
+
+ return ret;
+}
+
+static int ov01a10_set_format(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *sd_state,
+ struct v4l2_subdev_format *fmt)
+{
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+ const struct ov01a10_mode *mode;
+ s32 vblank_def, h_blank;
+
+ mode = v4l2_find_nearest_size(supported_modes,
+ ARRAY_SIZE(supported_modes), width,
+ height, fmt->format.width,
+ fmt->format.height);
+
+ mutex_lock(&ov01a10->mutex);
+ ov01a10_update_pad_format(mode, &fmt->format);
+ if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
+ *v4l2_subdev_get_try_format(sd, sd_state, fmt->pad) = fmt->format;
+ } else {
+ ov01a10->cur_mode = mode;
+ __v4l2_ctrl_s_ctrl(ov01a10->link_freq, mode->link_freq_index);
+ __v4l2_ctrl_s_ctrl_int64(ov01a10->pixel_rate, OV01A10_SCLK);
+
+ vblank_def = mode->vts_def - mode->height;
+ __v4l2_ctrl_modify_range(ov01a10->vblank,
+ mode->vts_min - mode->height,
+ OV01A10_VTS_MAX - mode->height, 1,
+ vblank_def);
+ __v4l2_ctrl_s_ctrl(ov01a10->vblank, vblank_def);
+ h_blank = mode->hts - mode->width;
+ __v4l2_ctrl_modify_range(ov01a10->hblank, h_blank, h_blank, 1,
+ h_blank);
+ }
+ mutex_unlock(&ov01a10->mutex);
+
+ return 0;
+}
+
+static int ov01a10_get_format(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *sd_state,
+ struct v4l2_subdev_format *fmt)
+{
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+
+ mutex_lock(&ov01a10->mutex);
+ if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
+ fmt->format = *v4l2_subdev_get_try_format(&ov01a10->sd,
+ sd_state, fmt->pad);
+ else
+ ov01a10_update_pad_format(ov01a10->cur_mode, &fmt->format);
+
+ mutex_unlock(&ov01a10->mutex);
+
+ return 0;
+}
+
+static int ov01a10_enum_mbus_code(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *sd_state,
+ struct v4l2_subdev_mbus_code_enum *code)
+{
+ if (code->index > 0)
+ return -EINVAL;
+
+ code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
+
+ return 0;
+}
+
+static int ov01a10_enum_frame_size(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *sd_state,
+ struct v4l2_subdev_frame_size_enum *fse)
+{
+ if (fse->index >= ARRAY_SIZE(supported_modes))
+ return -EINVAL;
+
+ if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
+ return -EINVAL;
+
+ fse->min_width = supported_modes[fse->index].width;
+ fse->max_width = fse->min_width;
+ fse->min_height = supported_modes[fse->index].height;
+ fse->max_height = fse->min_height;
+
+ return 0;
+}
+
+static int ov01a10_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
+{
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+
+ mutex_lock(&ov01a10->mutex);
+ ov01a10_update_pad_format(&supported_modes[0],
+ v4l2_subdev_get_try_format(sd, fh->state, 0));
+ mutex_unlock(&ov01a10->mutex);
+
+ return 0;
+}
+
+static const struct v4l2_subdev_core_ops ov01a10_core_ops = {
+ .log_status = v4l2_ctrl_subdev_log_status,
+ .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+ .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
+static const struct v4l2_subdev_video_ops ov01a10_video_ops = {
+ .s_stream = ov01a10_set_stream,
+};
+
+static const struct v4l2_subdev_pad_ops ov01a10_pad_ops = {
+ .set_fmt = ov01a10_set_format,
+ .get_fmt = ov01a10_get_format,
+ .enum_mbus_code = ov01a10_enum_mbus_code,
+ .enum_frame_size = ov01a10_enum_frame_size,
+};
+
+static const struct v4l2_subdev_ops ov01a10_subdev_ops = {
+ .core = &ov01a10_core_ops,
+ .video = &ov01a10_video_ops,
+ .pad = &ov01a10_pad_ops,
+};
+
+static const struct media_entity_operations ov01a10_subdev_entity_ops = {
+ .link_validate = v4l2_subdev_link_validate,
+};
+
+static const struct v4l2_subdev_internal_ops ov01a10_internal_ops = {
+ .open = ov01a10_open,
+};
+
+static int ov01a10_identify_module(struct ov01a10 *ov01a10)
+{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
+ int ret;
+ u32 val;
+
+ ret = ov01a10_read_reg(ov01a10, OV01A10_REG_CHIP_ID, 3, &val);
+ if (ret)
+ return ret;
+
+ if (val != OV01A10_CHIP_ID) {
+ dev_err(&client->dev, "chip id mismatch: %x!=%x\n",
+ OV01A10_CHIP_ID, val);
+ return -EIO;
+ }
+
+ return 0;
+}
+
+static void ov01a10_remove(struct i2c_client *client)
+{
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct ov01a10 *ov01a10 = to_ov01a10(sd);
+
+ v4l2_async_unregister_subdev(sd);
+ media_entity_cleanup(&sd->entity);
+ v4l2_ctrl_handler_free(sd->ctrl_handler);
+
+ pm_runtime_disable(&client->dev);
+ mutex_destroy(&ov01a10->mutex);
+}
+
+static int ov01a10_probe(struct i2c_client *client)
+{
+ struct device *dev = &client->dev;
+ struct ov01a10 *ov01a10;
+ int ret = 0;
+
+ ov01a10 = devm_kzalloc(dev, sizeof(*ov01a10), GFP_KERNEL);
+ if (!ov01a10)
+ return -ENOMEM;
+
+ v4l2_i2c_subdev_init(&ov01a10->sd, client, &ov01a10_subdev_ops);
+
+ ret = ov01a10_identify_module(ov01a10);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to find sensor\n");
+
+ mutex_init(&ov01a10->mutex);
+ ov01a10->cur_mode = &supported_modes[0];
+
+ ret = ov01a10_init_controls(ov01a10);
+ if (ret) {
+ dev_err(dev, "failed to init controls: %d\n", ret);
+ goto err_mutex_destroy;
+ }
+
+ ov01a10->sd.internal_ops = &ov01a10_internal_ops;
+ ov01a10->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+ V4L2_SUBDEV_FL_HAS_EVENTS;
+ ov01a10->sd.entity.ops = &ov01a10_subdev_entity_ops;
+ ov01a10->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
+ ov01a10->pad.flags = MEDIA_PAD_FL_SOURCE;
+
+ ret = media_entity_pads_init(&ov01a10->sd.entity, 1, &ov01a10->pad);
+ if (ret) {
+ dev_err(dev, "failed to init entity pads: %d\n", ret);
+ goto err_handler_free;
+ }
+
+ ret = v4l2_async_register_subdev_sensor(&ov01a10->sd);
+ if (ret < 0) {
+ dev_err(dev, "failed to register subdev: %d\n",
+ ret);
+ goto err_media_entity_cleanup;
+ }
+
+ pm_runtime_enable(dev);
+ pm_runtime_idle(dev);
+
+ return 0;
+
+err_media_entity_cleanup:
+ media_entity_cleanup(&ov01a10->sd.entity);
+
+err_handler_free:
+ v4l2_ctrl_handler_free(ov01a10->sd.ctrl_handler);
+
+err_mutex_destroy:
+ mutex_destroy(&ov01a10->mutex);
+
+ return ret;
+}
+
+static const struct dev_pm_ops ov01a10_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(ov01a10_suspend, ov01a10_resume)
+};
+
+static const struct acpi_device_id ov01a10_acpi_ids[] = {
+ {"OVTI01A0"},
+ {}
+};
+
+MODULE_DEVICE_TABLE(acpi, ov01a10_acpi_ids);
+
+static struct i2c_driver ov01a10_i2c_driver = {
+ .driver = {
+ .name = "ov01a10",
+ .pm = &ov01a10_pm_ops,
+ .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
+ },
+ .probe_new = ov01a10_probe,
+ .remove = ov01a10_remove,
+};
+
+module_i2c_driver(ov01a10_i2c_driver);
+
+MODULE_AUTHOR("Bingbu Cao <bingbu.cao@intel.com>");
+MODULE_AUTHOR("Wang Yating <yating.wang@intel.com>");
+MODULE_DESCRIPTION("OmniVision OV01A10 sensor driver");
+MODULE_LICENSE("GPL v2");
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 11:22 [PATCH] media: i2c: add ov01a10 image sensor driver Bingbu Cao
@ 2023-02-09 12:40 ` Dave Stevenson
2023-02-09 13:15 ` Sakari Ailus
2023-04-13 7:58 ` Bingbu Cao
2023-02-09 13:06 ` Sakari Ailus
2023-02-09 14:41 ` Kieran Bingham
2 siblings, 2 replies; 13+ messages in thread
From: Dave Stevenson @ 2023-02-09 12:40 UTC (permalink / raw)
To: Bingbu Cao; +Cc: linux-media, sakari.ailus, bingbu.cao, yating.wang
Hi Bingbu
Thanks for the patch. Just a couple of observations as I read through it.
On Thu, 9 Feb 2023 at 11:39, Bingbu Cao <bingbu.cao@intel.com> wrote:
>
> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Signed-off-by: Yating Wang <yating.wang@intel.com>
> ---
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 920 insertions(+)
> create mode 100644 drivers/media/i2c/ov01a10.c
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 833241897d63..8e5d1ef0616f 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -338,6 +338,19 @@ config VIDEO_OG01A1B
> To compile this driver as a module, choose M here: the
> module will be called og01a1b.
>
> +config VIDEO_OV01A10
> + tristate "OmniVision OV01A10 sensor support"
> + depends on VIDEO_DEV && I2C
> + select MEDIA_CONTROLLER
> + select VIDEO_V4L2_SUBDEV_API
> + select V4L2_FWNODE
> + help
> + This is a Video4Linux2 sensor driver for the OmniVision
> + OV01A10 camera.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called ov01a10.
> +
> config VIDEO_OV02A10
> tristate "OmniVision OV02A10 sensor support"
> depends on VIDEO_DEV && I2C
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 4d6c052bb5a7..ce214503b526 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o
> obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o
> obj-$(CONFIG_VIDEO_NOON010PC30) += noon010pc30.o
> obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o
> +obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o
> obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o
> obj-$(CONFIG_VIDEO_OV08D10) += ov08d10.o
> obj-$(CONFIG_VIDEO_OV08X40) += ov08x40.o
> diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
> new file mode 100644
> index 000000000000..13de9f9ccdc8
> --- /dev/null
> +++ b/drivers/media/i2c/ov01a10.c
> @@ -0,0 +1,906 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2020-2021 Intel Corporation.
Copyright year 2023?
> +
> +#include <asm/unaligned.h>
> +
> +#include <linux/acpi.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> +#include <media/v4l2-fwnode.h>
> +
> +#define OV01A10_LINK_FREQ_400MHZ 400000000ULL
> +#define OV01A10_SCLK 40000000LL
> +#define OV01A10_MCLK 19200000
Never used. Did you mean to validate the external clock frequency if
this is the only value supported?
> +#define OV01A10_DATA_LANES 1
> +#define OV01A10_RGB_DEPTH 10
These are never used either.
> +
> +#define OV01A10_REG_CHIP_ID 0x300a
> +#define OV01A10_CHIP_ID 0x560141
> +
> +#define OV01A10_REG_MODE_SELECT 0x0100
> +#define OV01A10_MODE_STANDBY 0x00
> +#define OV01A10_MODE_STREAMING 0x01
> +
> +/* vertical timings */
> +#define OV01A10_REG_VTS 0x380e
> +#define OV01A10_VTS_DEF 0x0380
> +#define OV01A10_VTS_MIN 0x0380
> +#define OV01A10_VTS_MAX 0xffff
> +
> +/* exposure controls */
> +#define OV01A10_REG_EXPOSURE 0x3501
> +#define OV01A10_EXPOSURE_MIN 4
> +#define OV01A10_EXPOSURE_MAX_MARGIN 8
> +#define OV01A10_EXPOSURE_STEP 1
> +
> +/* analog gain controls */
> +#define OV01A10_REG_ANALOG_GAIN 0x3508
> +#define OV01A10_ANAL_GAIN_MIN 0x100
> +#define OV01A10_ANAL_GAIN_MAX 0xffff
> +#define OV01A10_ANAL_GAIN_STEP 1
> +
> +/* digital gain controls */
> +#define OV01A10_REG_DIGILAL_GAIN_B 0x350A
s/DIGILAL/DIGITAL
(and fix where referenced in ov01a10_update_digital_gain)
> +#define OV01A10_REG_DIGITAL_GAIN_GB 0x3510
> +#define OV01A10_REG_DIGITAL_GAIN_GR 0x3513
> +#define OV01A10_REG_DIGITAL_GAIN_R 0x3516
> +#define OV01A10_DGTL_GAIN_MIN 0
> +#define OV01A10_DGTL_GAIN_MAX 0x3ffff
> +#define OV01A10_DGTL_GAIN_STEP 1
> +#define OV01A10_DGTL_GAIN_DEFAULT 1024
> +
> +/* test pattern control */
> +#define OV01A10_REG_TEST_PATTERN 0x4503
> +#define OV01A10_TEST_PATTERN_ENABLE BIT(7)
> +#define OV01A10_TEST_PATTERN_BAR_SHIFT 0
> +
> +enum {
> + OV01A10_LINK_FREQ_400MHZ_INDEX,
> +};
> +
> +struct ov01a10_reg {
> + u16 address;
> + u8 val;
> +};
> +
> +struct ov01a10_reg_list {
> + u32 num_of_regs;
> + const struct ov01a10_reg *regs;
> +};
> +
> +struct ov01a10_link_freq_config {
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +struct ov01a10_mode {
> + u32 width;
> + u32 height;
> + u32 hts;
> + u32 vts_def;
> + u32 vts_min;
> + u32 link_freq_index;
> +
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +static const struct ov01a10_reg mipi_data_rate_720mbps[] = {
> +};
An empty register set?
Is there currently any need to support alternate link frequencies? If
not then this struct, struct v4l2_ctrl *link_freq in struct ov01a10,
and link_freq_index in struct ov01a10_mode could all be dropped.
> +
> +static const struct ov01a10_reg sensor_1280x800_setting[] = {
> + {0x0103, 0x01},
> + {0x0302, 0x00},
> + {0x0303, 0x06},
> + {0x0304, 0x01},
> + {0x0305, 0xe0},
> + {0x0306, 0x00},
> + {0x0308, 0x01},
> + {0x0309, 0x00},
> + {0x030c, 0x01},
> + {0x0322, 0x01},
> + {0x0323, 0x06},
> + {0x0324, 0x01},
> + {0x0325, 0x68},
> + {0x3002, 0xa1},
> + {0x301e, 0xf0},
> + {0x3022, 0x01},
> + {0x3501, 0x03},
> + {0x3502, 0x78},
> + {0x3504, 0x0c},
> + {0x3508, 0x01},
> + {0x3509, 0x00},
> + {0x3601, 0xc0},
> + {0x3603, 0x71},
> + {0x3610, 0x68},
> + {0x3611, 0x86},
> + {0x3640, 0x10},
> + {0x3641, 0x80},
> + {0x3642, 0xdc},
> + {0x3646, 0x55},
> + {0x3647, 0x57},
> + {0x364b, 0x00},
> + {0x3653, 0x10},
> + {0x3655, 0x00},
> + {0x3656, 0x00},
> + {0x365f, 0x0f},
> + {0x3661, 0x45},
> + {0x3662, 0x24},
> + {0x3663, 0x11},
> + {0x3664, 0x07},
> + {0x3709, 0x34},
> + {0x370b, 0x6f},
> + {0x3714, 0x22},
> + {0x371b, 0x27},
> + {0x371c, 0x67},
> + {0x371d, 0xa7},
> + {0x371e, 0xe7},
> + {0x3730, 0x81},
> + {0x3733, 0x10},
> + {0x3734, 0x40},
> + {0x3737, 0x04},
> + {0x3739, 0x1c},
> + {0x3767, 0x00},
> + {0x376c, 0x81},
> + {0x3772, 0x14},
> + {0x37c2, 0x04},
> + {0x37d8, 0x03},
> + {0x37d9, 0x0c},
> + {0x37e0, 0x00},
> + {0x37e1, 0x08},
> + {0x37e2, 0x10},
> + {0x37e3, 0x04},
> + {0x37e4, 0x04},
> + {0x37e5, 0x03},
> + {0x37e6, 0x04},
> + {0x3800, 0x00},
> + {0x3801, 0x00},
> + {0x3802, 0x00},
> + {0x3803, 0x00},
> + {0x3804, 0x05},
> + {0x3805, 0x0f},
> + {0x3806, 0x03},
> + {0x3807, 0x2f},
> + {0x3808, 0x05},
> + {0x3809, 0x00},
> + {0x380a, 0x03},
> + {0x380b, 0x20},
> + {0x380c, 0x02},
> + {0x380d, 0xe8},
> + {0x380e, 0x03},
> + {0x380f, 0x80},
> + {0x3810, 0x00},
> + {0x3811, 0x09},
> + {0x3812, 0x00},
> + {0x3813, 0x08},
> + {0x3814, 0x01},
> + {0x3815, 0x01},
> + {0x3816, 0x01},
> + {0x3817, 0x01},
> + {0x3820, 0xa8},
> + {0x3822, 0x13},
> + {0x3832, 0x28},
> + {0x3833, 0x10},
> + {0x3b00, 0x00},
> + {0x3c80, 0x00},
> + {0x3c88, 0x02},
> + {0x3c8c, 0x07},
> + {0x3c8d, 0x40},
> + {0x3cc7, 0x80},
> + {0x4000, 0xc3},
> + {0x4001, 0xe0},
> + {0x4003, 0x40},
> + {0x4008, 0x02},
> + {0x4009, 0x19},
> + {0x400a, 0x01},
> + {0x400b, 0x6c},
> + {0x4011, 0x00},
> + {0x4041, 0x00},
> + {0x4300, 0xff},
> + {0x4301, 0x00},
> + {0x4302, 0x0f},
> + {0x4503, 0x00},
> + {0x4601, 0x50},
> + {0x4800, 0x64},
> + {0x481f, 0x34},
> + {0x4825, 0x33},
> + {0x4837, 0x11},
> + {0x4881, 0x40},
> + {0x4883, 0x01},
> + {0x4890, 0x00},
> + {0x4901, 0x00},
> + {0x4902, 0x00},
> + {0x4b00, 0x2a},
> + {0x4b0d, 0x00},
> + {0x450a, 0x04},
> + {0x450b, 0x00},
> + {0x5000, 0x65},
> + {0x5200, 0x18},
> + {0x5004, 0x00},
> + {0x5080, 0x40},
> + {0x0305, 0xf4},
> + {0x0325, 0xc2},
> +};
> +
> +static const char * const ov01a10_test_pattern_menu[] = {
> + "Disabled",
> + "Color Bar",
> + "Top-Bottom Darker Color Bar",
> + "Right-Left Darker Color Bar",
> + "Color Bar type 4",
> +};
> +
> +static const s64 link_freq_menu_items[] = {
> + OV01A10_LINK_FREQ_400MHZ,
> +};
> +
> +static const struct ov01a10_link_freq_config link_freq_configs[] = {
> + [OV01A10_LINK_FREQ_400MHZ_INDEX] = {
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(mipi_data_rate_720mbps),
> + .regs = mipi_data_rate_720mbps,
> + }
> + },
> +};
> +
> +static const struct ov01a10_mode supported_modes[] = {
> + {
> + .width = 1280,
> + .height = 800,
> + .hts = 1488,
> + .vts_def = OV01A10_VTS_DEF,
> + .vts_min = OV01A10_VTS_MIN,
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(sensor_1280x800_setting),
> + .regs = sensor_1280x800_setting,
> + },
> + .link_freq_index = OV01A10_LINK_FREQ_400MHZ_INDEX,
> + },
> +};
> +
> +struct ov01a10 {
> + struct v4l2_subdev sd;
> + struct media_pad pad;
> + struct v4l2_ctrl_handler ctrl_handler;
> +
> + /* v4l2 controls */
> + struct v4l2_ctrl *link_freq;
> + struct v4l2_ctrl *pixel_rate;
> + struct v4l2_ctrl *vblank;
> + struct v4l2_ctrl *hblank;
> + struct v4l2_ctrl *exposure;
> +
> + const struct ov01a10_mode *cur_mode;
> +
> + /* serialize asynchronous callbacks */
> + struct mutex mutex;
> +
> + /* streaming state */
> + bool streaming;
> +};
> +
> +static inline struct ov01a10 *to_ov01a10(struct v4l2_subdev *subdev)
> +{
> + return container_of(subdev, struct ov01a10, sd);
> +}
> +
> +static int ov01a10_read_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 *val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + struct i2c_msg msgs[2];
> + u8 addr_buf[2];
> + u8 data_buf[4] = {0};
> + int ret = 0;
> +
> + if (len > sizeof(data_buf))
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, addr_buf);
> + msgs[0].addr = client->addr;
> + msgs[0].flags = 0;
> + msgs[0].len = sizeof(addr_buf);
> + msgs[0].buf = addr_buf;
> + msgs[1].addr = client->addr;
> + msgs[1].flags = I2C_M_RD;
> + msgs[1].len = len;
> + msgs[1].buf = &data_buf[sizeof(data_buf) - len];
> +
> + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
> +
> + if (ret != ARRAY_SIZE(msgs))
> + return ret < 0 ? ret : -EIO;
> +
> + *val = get_unaligned_be32(data_buf);
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u8 buf[6];
> + int ret = 0;
> +
> + if (len > 4)
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, buf);
> + put_unaligned_be32(val << 8 * (4 - len), buf + 2);
> +
> + ret = i2c_master_send(client, buf, len + 2);
> + if (ret != len + 2)
> + return ret < 0 ? ret : -EIO;
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg_list(struct ov01a10 *ov01a10,
> + const struct ov01a10_reg_list *r_list)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + unsigned int i;
> + int ret = 0;
> +
> + for (i = 0; i < r_list->num_of_regs; i++) {
> + ret = ov01a10_write_reg(ov01a10, r_list->regs[i].address, 1,
> + r_list->regs[i].val);
> + if (ret) {
> + dev_err_ratelimited(&client->dev,
> + "write reg 0x%4.4x return err = %d",
> + r_list->regs[i].address, ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u32 real = d_gain << 6;
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGILAL_GAIN_B, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_B");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GB, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GB");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GR, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GR");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_R, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_R");
> + return ret;
> + }
> +
> + return ret;
> +}
> +
> +static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern)
> +{
> + if (pattern)
> + pattern = (pattern - 1) << OV01A10_TEST_PATTERN_BAR_SHIFT |
> + OV01A10_TEST_PATTERN_ENABLE;
> +
> + return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern);
> +}
> +
> +static int ov01a10_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
> + struct ov01a10 *ov01a10 = container_of(ctrl->handler,
> + struct ov01a10, ctrl_handler);
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + s64 exposure_max;
> + int ret = 0;
> +
> + if (ctrl->id == V4L2_CID_VBLANK) {
> + exposure_max = ov01a10->cur_mode->height + ctrl->val -
> + OV01A10_EXPOSURE_MAX_MARGIN;
> + __v4l2_ctrl_modify_range(ov01a10->exposure,
> + ov01a10->exposure->minimum,
> + exposure_max, ov01a10->exposure->step,
> + exposure_max);
> + }
> +
> + if (!pm_runtime_get_if_in_use(&client->dev))
> + return 0;
> +
> + switch (ctrl->id) {
> + case V4L2_CID_ANALOGUE_GAIN:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_ANALOG_GAIN, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_DIGITAL_GAIN:
> + ret = ov01a10_update_digital_gain(ov01a10, ctrl->val);
> + break;
> +
> + case V4L2_CID_EXPOSURE:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_EXPOSURE, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_VBLANK:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_VTS, 2,
> + ov01a10->cur_mode->height + ctrl->val);
> + break;
> +
> + case V4L2_CID_TEST_PATTERN:
> + ret = ov01a10_test_pattern(ov01a10, ctrl->val);
> + break;
Support for V4L2_CID_HFLIP and V4L2_CID_VFLIP?
> +
> + default:
> + ret = -EINVAL;
> + break;
> + }
> +
> + pm_runtime_put(&client->dev);
> +
> + return ret;
> +}
> +
> +static const struct v4l2_ctrl_ops ov01a10_ctrl_ops = {
> + .s_ctrl = ov01a10_set_ctrl,
> +};
> +
> +static int ov01a10_init_controls(struct ov01a10 *ov01a10)
> +{
> + struct v4l2_ctrl_handler *ctrl_hdlr;
> + const struct ov01a10_mode *cur_mode;
> + s64 exposure_max, h_blank;
> + u32 vblank_min, vblank_max, vblank_default;
> + int size;
> + int ret = 0;
> +
> + ctrl_hdlr = &ov01a10->ctrl_handler;
> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
> + if (ret)
> + return ret;
> +
> + ctrl_hdlr->lock = &ov01a10->mutex;
> + cur_mode = ov01a10->cur_mode;
> + size = ARRAY_SIZE(link_freq_menu_items);
> +
> + ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> + &ov01a10_ctrl_ops,
> + V4L2_CID_LINK_FREQ,
> + size - 1, 0,
> + link_freq_menu_items);
> + if (ov01a10->link_freq)
> + ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_PIXEL_RATE, 0,
> + OV01A10_SCLK, 1, OV01A10_SCLK);
> +
> + vblank_min = cur_mode->vts_min - cur_mode->height;
> + vblank_max = OV01A10_VTS_MAX - cur_mode->height;
> + vblank_default = cur_mode->vts_def - cur_mode->height;
> + ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_VBLANK, vblank_min,
> + vblank_max, 1, vblank_default);
> +
> + h_blank = cur_mode->hts - cur_mode->width;
> + ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_HBLANK, h_blank, h_blank,
> + 1, h_blank);
> + if (ov01a10->hblank)
> + ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
> + OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
> + OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
> + OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
> + OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
> + exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
> + ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_EXPOSURE,
> + OV01A10_EXPOSURE_MIN,
> + exposure_max,
> + OV01A10_EXPOSURE_STEP,
> + exposure_max);
> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_TEST_PATTERN,
> + ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
> + 0, 0, ov01a10_test_pattern_menu);
> + if (ctrl_hdlr->error)
> + return ctrl_hdlr->error;
A call to v4l2_ctrl_new_fwnode_properties to add the standard
V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION
properties?
> +
> + ov01a10->sd.ctrl_handler = ctrl_hdlr;
> +
> + return 0;
> +}
> +
> +static void ov01a10_update_pad_format(const struct ov01a10_mode *mode,
> + struct v4l2_mbus_framefmt *fmt)
> +{
> + fmt->width = mode->width;
> + fmt->height = mode->height;
> + fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> + fmt->field = V4L2_FIELD_NONE;
> +}
> +
> +static int ov01a10_start_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + const struct ov01a10_reg_list *reg_list;
> + int link_freq_index;
> + int ret = 0;
> +
> + link_freq_index = ov01a10->cur_mode->link_freq_index;
> + reg_list = &link_freq_configs[link_freq_index].reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set plls\n");
> + return ret;
> + }
> +
> + reg_list = &ov01a10->cur_mode->reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set mode\n");
> + return ret;
> + }
> +
> + ret = __v4l2_ctrl_handler_setup(ov01a10->sd.ctrl_handler);
> + if (ret)
> + return ret;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STREAMING);
> + if (ret)
> + dev_err(&client->dev, "failed to start streaming\n");
> +
> + return ret;
> +}
> +
> +static void ov01a10_stop_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STANDBY);
> + if (ret)
> + dev_err(&client->dev, "failed to stop streaming");
> +
> +}
> +
> +static int ov01a10_set_stream(struct v4l2_subdev *sd, int enable)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + struct i2c_client *client = v4l2_get_subdevdata(sd);
> + int ret = 0;
> +
> + if (ov01a10->streaming == enable)
> + return 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (enable) {
> + ret = pm_runtime_get_sync(&client->dev);
> + if (ret < 0) {
> + pm_runtime_put_noidle(&client->dev);
> + mutex_unlock(&ov01a10->mutex);
> + return ret;
> + }
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + enable = 0;
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> + } else {
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> +
> + ov01a10->streaming = enable;
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int __maybe_unused ov01a10_suspend(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (ov01a10->streaming)
> + ov01a10_stop_streaming(ov01a10);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused ov01a10_resume(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + int ret = 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (!ov01a10->streaming)
> + goto exit;
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + ov01a10->streaming = false;
> + ov01a10_stop_streaming(ov01a10);
> + }
> +
> +exit:
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int ov01a10_set_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + const struct ov01a10_mode *mode;
> + s32 vblank_def, h_blank;
> +
> + mode = v4l2_find_nearest_size(supported_modes,
> + ARRAY_SIZE(supported_modes), width,
> + height, fmt->format.width,
> + fmt->format.height);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(mode, &fmt->format);
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> + *v4l2_subdev_get_try_format(sd, sd_state, fmt->pad) = fmt->format;
> + } else {
> + ov01a10->cur_mode = mode;
> + __v4l2_ctrl_s_ctrl(ov01a10->link_freq, mode->link_freq_index);
> + __v4l2_ctrl_s_ctrl_int64(ov01a10->pixel_rate, OV01A10_SCLK);
> +
> + vblank_def = mode->vts_def - mode->height;
> + __v4l2_ctrl_modify_range(ov01a10->vblank,
> + mode->vts_min - mode->height,
> + OV01A10_VTS_MAX - mode->height, 1,
> + vblank_def);
> + __v4l2_ctrl_s_ctrl(ov01a10->vblank, vblank_def);
> + h_blank = mode->hts - mode->width;
> + __v4l2_ctrl_modify_range(ov01a10->hblank, h_blank, h_blank, 1,
> + h_blank);
> + }
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_get_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
> + fmt->format = *v4l2_subdev_get_try_format(&ov01a10->sd,
> + sd_state, fmt->pad);
> + else
> + ov01a10_update_pad_format(ov01a10->cur_mode, &fmt->format);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + if (code->index > 0)
> + return -EINVAL;
> +
> + code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_frame_size_enum *fse)
> +{
> + if (fse->index >= ARRAY_SIZE(supported_modes))
> + return -EINVAL;
> +
> + if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
> + return -EINVAL;
> +
> + fse->min_width = supported_modes[fse->index].width;
> + fse->max_width = fse->min_width;
> + fse->min_height = supported_modes[fse->index].height;
> + fse->max_height = fse->min_height;
> +
> + return 0;
> +}
> +
> +static int ov01a10_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(&supported_modes[0],
> + v4l2_subdev_get_try_format(sd, fh->state, 0));
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static const struct v4l2_subdev_core_ops ov01a10_core_ops = {
> + .log_status = v4l2_ctrl_subdev_log_status,
> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> + .unsubscribe_event = v4l2_event_subdev_unsubscribe,
> +};
> +
> +static const struct v4l2_subdev_video_ops ov01a10_video_ops = {
> + .s_stream = ov01a10_set_stream,
> +};
> +
> +static const struct v4l2_subdev_pad_ops ov01a10_pad_ops = {
> + .set_fmt = ov01a10_set_format,
> + .get_fmt = ov01a10_get_format,
> + .enum_mbus_code = ov01a10_enum_mbus_code,
> + .enum_frame_size = ov01a10_enum_frame_size,
> +};
> +
> +static const struct v4l2_subdev_ops ov01a10_subdev_ops = {
> + .core = &ov01a10_core_ops,
> + .video = &ov01a10_video_ops,
> + .pad = &ov01a10_pad_ops,
> +};
> +
> +static const struct media_entity_operations ov01a10_subdev_entity_ops = {
> + .link_validate = v4l2_subdev_link_validate,
> +};
> +
> +static const struct v4l2_subdev_internal_ops ov01a10_internal_ops = {
> + .open = ov01a10_open,
> +};
> +
> +static int ov01a10_identify_module(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret;
> + u32 val;
> +
> + ret = ov01a10_read_reg(ov01a10, OV01A10_REG_CHIP_ID, 3, &val);
> + if (ret)
> + return ret;
> +
> + if (val != OV01A10_CHIP_ID) {
> + dev_err(&client->dev, "chip id mismatch: %x!=%x\n",
> + OV01A10_CHIP_ID, val);
> + return -EIO;
> + }
> +
> + return 0;
> +}
> +
> +static void ov01a10_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + media_entity_cleanup(&sd->entity);
> + v4l2_ctrl_handler_free(sd->ctrl_handler);
> +
> + pm_runtime_disable(&client->dev);
> + mutex_destroy(&ov01a10->mutex);
> +}
> +
> +static int ov01a10_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct ov01a10 *ov01a10;
> + int ret = 0;
> +
> + ov01a10 = devm_kzalloc(dev, sizeof(*ov01a10), GFP_KERNEL);
> + if (!ov01a10)
> + return -ENOMEM;
> +
> + v4l2_i2c_subdev_init(&ov01a10->sd, client, &ov01a10_subdev_ops);
> +
> + ret = ov01a10_identify_module(ov01a10);
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "failed to find sensor\n");
> +
> + mutex_init(&ov01a10->mutex);
> + ov01a10->cur_mode = &supported_modes[0];
> +
> + ret = ov01a10_init_controls(ov01a10);
> + if (ret) {
> + dev_err(dev, "failed to init controls: %d\n", ret);
> + goto err_mutex_destroy;
> + }
> +
> + ov01a10->sd.internal_ops = &ov01a10_internal_ops;
> + ov01a10->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> + V4L2_SUBDEV_FL_HAS_EVENTS;
> + ov01a10->sd.entity.ops = &ov01a10_subdev_entity_ops;
> + ov01a10->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + ov01a10->pad.flags = MEDIA_PAD_FL_SOURCE;
> +
> + ret = media_entity_pads_init(&ov01a10->sd.entity, 1, &ov01a10->pad);
> + if (ret) {
> + dev_err(dev, "failed to init entity pads: %d\n", ret);
> + goto err_handler_free;
> + }
> +
> + ret = v4l2_async_register_subdev_sensor(&ov01a10->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register subdev: %d\n",
> + ret);
> + goto err_media_entity_cleanup;
> + }
> +
> + pm_runtime_enable(dev);
> + pm_runtime_idle(dev);
> +
> + return 0;
> +
> +err_media_entity_cleanup:
> + media_entity_cleanup(&ov01a10->sd.entity);
> +
> +err_handler_free:
> + v4l2_ctrl_handler_free(ov01a10->sd.ctrl_handler);
> +
> +err_mutex_destroy:
> + mutex_destroy(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static const struct dev_pm_ops ov01a10_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(ov01a10_suspend, ov01a10_resume)
> +};
> +
> +static const struct acpi_device_id ov01a10_acpi_ids[] = {
> + {"OVTI01A0"},
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(acpi, ov01a10_acpi_ids);
> +
> +static struct i2c_driver ov01a10_i2c_driver = {
> + .driver = {
> + .name = "ov01a10",
> + .pm = &ov01a10_pm_ops,
> + .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
As you're only supporting ACPI here, make ACPI a dependency in Kconfig?
Dave
> + },
> + .probe_new = ov01a10_probe,
> + .remove = ov01a10_remove,
> +};
> +
> +module_i2c_driver(ov01a10_i2c_driver);
> +
> +MODULE_AUTHOR("Bingbu Cao <bingbu.cao@intel.com>");
> +MODULE_AUTHOR("Wang Yating <yating.wang@intel.com>");
> +MODULE_DESCRIPTION("OmniVision OV01A10 sensor driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 11:22 [PATCH] media: i2c: add ov01a10 image sensor driver Bingbu Cao
2023-02-09 12:40 ` Dave Stevenson
@ 2023-02-09 13:06 ` Sakari Ailus
2023-04-12 11:40 ` Bingbu Cao
2023-02-09 14:41 ` Kieran Bingham
2 siblings, 1 reply; 13+ messages in thread
From: Sakari Ailus @ 2023-02-09 13:06 UTC (permalink / raw)
To: Bingbu Cao; +Cc: linux-media, bingbu.cao, yating.wang
Hi Bingbu,
Thanks for the patch.
On Thu, Feb 09, 2023 at 07:22:38PM +0800, Bingbu Cao wrote:
> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Signed-off-by: Yating Wang <yating.wang@intel.com>
> ---
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 920 insertions(+)
> create mode 100644 drivers/media/i2c/ov01a10.c
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 833241897d63..8e5d1ef0616f 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -338,6 +338,19 @@ config VIDEO_OG01A1B
> To compile this driver as a module, choose M here: the
> module will be called og01a1b.
>
> +config VIDEO_OV01A10
> + tristate "OmniVision OV01A10 sensor support"
> + depends on VIDEO_DEV && I2C
> + select MEDIA_CONTROLLER
> + select VIDEO_V4L2_SUBDEV_API
> + select V4L2_FWNODE
> + help
> + This is a Video4Linux2 sensor driver for the OmniVision
> + OV01A10 camera.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called ov01a10.
> +
> config VIDEO_OV02A10
> tristate "OmniVision OV02A10 sensor support"
> depends on VIDEO_DEV && I2C
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 4d6c052bb5a7..ce214503b526 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o
> obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o
> obj-$(CONFIG_VIDEO_NOON010PC30) += noon010pc30.o
> obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o
> +obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o
> obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o
> obj-$(CONFIG_VIDEO_OV08D10) += ov08d10.o
> obj-$(CONFIG_VIDEO_OV08X40) += ov08x40.o
> diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
> new file mode 100644
> index 000000000000..13de9f9ccdc8
> --- /dev/null
> +++ b/drivers/media/i2c/ov01a10.c
> @@ -0,0 +1,906 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2020-2021 Intel Corporation.
The // comment is used for the SPDX license line only.
> +
> +#include <asm/unaligned.h>
> +
> +#include <linux/acpi.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> +#include <media/v4l2-fwnode.h>
> +
> +#define OV01A10_LINK_FREQ_400MHZ 400000000ULL
> +#define OV01A10_SCLK 40000000LL
> +#define OV01A10_MCLK 19200000
> +#define OV01A10_DATA_LANES 1
> +#define OV01A10_RGB_DEPTH 10
> +
> +#define OV01A10_REG_CHIP_ID 0x300a
> +#define OV01A10_CHIP_ID 0x560141
> +
> +#define OV01A10_REG_MODE_SELECT 0x0100
> +#define OV01A10_MODE_STANDBY 0x00
> +#define OV01A10_MODE_STREAMING 0x01
> +
> +/* vertical timings */
> +#define OV01A10_REG_VTS 0x380e
> +#define OV01A10_VTS_DEF 0x0380
> +#define OV01A10_VTS_MIN 0x0380
> +#define OV01A10_VTS_MAX 0xffff
> +
> +/* exposure controls */
> +#define OV01A10_REG_EXPOSURE 0x3501
> +#define OV01A10_EXPOSURE_MIN 4
> +#define OV01A10_EXPOSURE_MAX_MARGIN 8
> +#define OV01A10_EXPOSURE_STEP 1
> +
> +/* analog gain controls */
> +#define OV01A10_REG_ANALOG_GAIN 0x3508
> +#define OV01A10_ANAL_GAIN_MIN 0x100
> +#define OV01A10_ANAL_GAIN_MAX 0xffff
> +#define OV01A10_ANAL_GAIN_STEP 1
> +
> +/* digital gain controls */
> +#define OV01A10_REG_DIGILAL_GAIN_B 0x350A
> +#define OV01A10_REG_DIGITAL_GAIN_GB 0x3510
> +#define OV01A10_REG_DIGITAL_GAIN_GR 0x3513
> +#define OV01A10_REG_DIGITAL_GAIN_R 0x3516
> +#define OV01A10_DGTL_GAIN_MIN 0
> +#define OV01A10_DGTL_GAIN_MAX 0x3ffff
> +#define OV01A10_DGTL_GAIN_STEP 1
> +#define OV01A10_DGTL_GAIN_DEFAULT 1024
> +
> +/* test pattern control */
> +#define OV01A10_REG_TEST_PATTERN 0x4503
> +#define OV01A10_TEST_PATTERN_ENABLE BIT(7)
> +#define OV01A10_TEST_PATTERN_BAR_SHIFT 0
> +
> +enum {
> + OV01A10_LINK_FREQ_400MHZ_INDEX,
> +};
> +
> +struct ov01a10_reg {
> + u16 address;
> + u8 val;
> +};
> +
> +struct ov01a10_reg_list {
> + u32 num_of_regs;
> + const struct ov01a10_reg *regs;
> +};
> +
> +struct ov01a10_link_freq_config {
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +struct ov01a10_mode {
> + u32 width;
> + u32 height;
> + u32 hts;
> + u32 vts_def;
> + u32 vts_min;
> + u32 link_freq_index;
> +
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +static const struct ov01a10_reg mipi_data_rate_720mbps[] = {
> +};
Hm. The registers to configure this are probably somewhere else. Could they
be moved here?
> +
> +static const struct ov01a10_reg sensor_1280x800_setting[] = {
> + {0x0103, 0x01},
> + {0x0302, 0x00},
> + {0x0303, 0x06},
> + {0x0304, 0x01},
> + {0x0305, 0xe0},
> + {0x0306, 0x00},
> + {0x0308, 0x01},
> + {0x0309, 0x00},
> + {0x030c, 0x01},
> + {0x0322, 0x01},
> + {0x0323, 0x06},
> + {0x0324, 0x01},
> + {0x0325, 0x68},
> + {0x3002, 0xa1},
> + {0x301e, 0xf0},
> + {0x3022, 0x01},
> + {0x3501, 0x03},
> + {0x3502, 0x78},
> + {0x3504, 0x0c},
> + {0x3508, 0x01},
> + {0x3509, 0x00},
> + {0x3601, 0xc0},
> + {0x3603, 0x71},
> + {0x3610, 0x68},
> + {0x3611, 0x86},
> + {0x3640, 0x10},
> + {0x3641, 0x80},
> + {0x3642, 0xdc},
> + {0x3646, 0x55},
> + {0x3647, 0x57},
> + {0x364b, 0x00},
> + {0x3653, 0x10},
> + {0x3655, 0x00},
> + {0x3656, 0x00},
> + {0x365f, 0x0f},
> + {0x3661, 0x45},
> + {0x3662, 0x24},
> + {0x3663, 0x11},
> + {0x3664, 0x07},
> + {0x3709, 0x34},
> + {0x370b, 0x6f},
> + {0x3714, 0x22},
> + {0x371b, 0x27},
> + {0x371c, 0x67},
> + {0x371d, 0xa7},
> + {0x371e, 0xe7},
> + {0x3730, 0x81},
> + {0x3733, 0x10},
> + {0x3734, 0x40},
> + {0x3737, 0x04},
> + {0x3739, 0x1c},
> + {0x3767, 0x00},
> + {0x376c, 0x81},
> + {0x3772, 0x14},
> + {0x37c2, 0x04},
> + {0x37d8, 0x03},
> + {0x37d9, 0x0c},
> + {0x37e0, 0x00},
> + {0x37e1, 0x08},
> + {0x37e2, 0x10},
> + {0x37e3, 0x04},
> + {0x37e4, 0x04},
> + {0x37e5, 0x03},
> + {0x37e6, 0x04},
> + {0x3800, 0x00},
> + {0x3801, 0x00},
> + {0x3802, 0x00},
> + {0x3803, 0x00},
> + {0x3804, 0x05},
> + {0x3805, 0x0f},
> + {0x3806, 0x03},
> + {0x3807, 0x2f},
> + {0x3808, 0x05},
> + {0x3809, 0x00},
> + {0x380a, 0x03},
> + {0x380b, 0x20},
> + {0x380c, 0x02},
> + {0x380d, 0xe8},
> + {0x380e, 0x03},
> + {0x380f, 0x80},
> + {0x3810, 0x00},
> + {0x3811, 0x09},
> + {0x3812, 0x00},
> + {0x3813, 0x08},
> + {0x3814, 0x01},
> + {0x3815, 0x01},
> + {0x3816, 0x01},
> + {0x3817, 0x01},
> + {0x3820, 0xa8},
> + {0x3822, 0x13},
> + {0x3832, 0x28},
> + {0x3833, 0x10},
> + {0x3b00, 0x00},
> + {0x3c80, 0x00},
> + {0x3c88, 0x02},
> + {0x3c8c, 0x07},
> + {0x3c8d, 0x40},
> + {0x3cc7, 0x80},
> + {0x4000, 0xc3},
> + {0x4001, 0xe0},
> + {0x4003, 0x40},
> + {0x4008, 0x02},
> + {0x4009, 0x19},
> + {0x400a, 0x01},
> + {0x400b, 0x6c},
> + {0x4011, 0x00},
> + {0x4041, 0x00},
> + {0x4300, 0xff},
> + {0x4301, 0x00},
> + {0x4302, 0x0f},
> + {0x4503, 0x00},
> + {0x4601, 0x50},
> + {0x4800, 0x64},
> + {0x481f, 0x34},
> + {0x4825, 0x33},
> + {0x4837, 0x11},
> + {0x4881, 0x40},
> + {0x4883, 0x01},
> + {0x4890, 0x00},
> + {0x4901, 0x00},
> + {0x4902, 0x00},
> + {0x4b00, 0x2a},
> + {0x4b0d, 0x00},
> + {0x450a, 0x04},
> + {0x450b, 0x00},
> + {0x5000, 0x65},
> + {0x5200, 0x18},
> + {0x5004, 0x00},
> + {0x5080, 0x40},
> + {0x0305, 0xf4},
> + {0x0325, 0xc2},
> +};
> +
> +static const char * const ov01a10_test_pattern_menu[] = {
> + "Disabled",
> + "Color Bar",
> + "Top-Bottom Darker Color Bar",
> + "Right-Left Darker Color Bar",
> + "Color Bar type 4",
> +};
> +
> +static const s64 link_freq_menu_items[] = {
> + OV01A10_LINK_FREQ_400MHZ,
> +};
> +
> +static const struct ov01a10_link_freq_config link_freq_configs[] = {
> + [OV01A10_LINK_FREQ_400MHZ_INDEX] = {
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(mipi_data_rate_720mbps),
> + .regs = mipi_data_rate_720mbps,
> + }
> + },
> +};
> +
> +static const struct ov01a10_mode supported_modes[] = {
> + {
> + .width = 1280,
> + .height = 800,
> + .hts = 1488,
> + .vts_def = OV01A10_VTS_DEF,
> + .vts_min = OV01A10_VTS_MIN,
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(sensor_1280x800_setting),
> + .regs = sensor_1280x800_setting,
> + },
> + .link_freq_index = OV01A10_LINK_FREQ_400MHZ_INDEX,
> + },
> +};
> +
> +struct ov01a10 {
> + struct v4l2_subdev sd;
> + struct media_pad pad;
> + struct v4l2_ctrl_handler ctrl_handler;
> +
> + /* v4l2 controls */
> + struct v4l2_ctrl *link_freq;
> + struct v4l2_ctrl *pixel_rate;
> + struct v4l2_ctrl *vblank;
> + struct v4l2_ctrl *hblank;
> + struct v4l2_ctrl *exposure;
> +
> + const struct ov01a10_mode *cur_mode;
> +
> + /* serialize asynchronous callbacks */
> + struct mutex mutex;
> +
> + /* streaming state */
> + bool streaming;
> +};
> +
> +static inline struct ov01a10 *to_ov01a10(struct v4l2_subdev *subdev)
> +{
> + return container_of(subdev, struct ov01a10, sd);
> +}
> +
> +static int ov01a10_read_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 *val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + struct i2c_msg msgs[2];
> + u8 addr_buf[2];
> + u8 data_buf[4] = {0};
> + int ret = 0;
> +
> + if (len > sizeof(data_buf))
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, addr_buf);
> + msgs[0].addr = client->addr;
> + msgs[0].flags = 0;
> + msgs[0].len = sizeof(addr_buf);
> + msgs[0].buf = addr_buf;
> + msgs[1].addr = client->addr;
> + msgs[1].flags = I2C_M_RD;
> + msgs[1].len = len;
> + msgs[1].buf = &data_buf[sizeof(data_buf) - len];
> +
> + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
> +
> + if (ret != ARRAY_SIZE(msgs))
> + return ret < 0 ? ret : -EIO;
> +
> + *val = get_unaligned_be32(data_buf);
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u8 buf[6];
> + int ret = 0;
> +
> + if (len > 4)
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, buf);
> + put_unaligned_be32(val << 8 * (4 - len), buf + 2);
> +
> + ret = i2c_master_send(client, buf, len + 2);
> + if (ret != len + 2)
> + return ret < 0 ? ret : -EIO;
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg_list(struct ov01a10 *ov01a10,
> + const struct ov01a10_reg_list *r_list)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + unsigned int i;
> + int ret = 0;
> +
> + for (i = 0; i < r_list->num_of_regs; i++) {
> + ret = ov01a10_write_reg(ov01a10, r_list->regs[i].address, 1,
> + r_list->regs[i].val);
> + if (ret) {
> + dev_err_ratelimited(&client->dev,
> + "write reg 0x%4.4x return err = %d",
> + r_list->regs[i].address, ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u32 real = d_gain << 6;
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGILAL_GAIN_B, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_B");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GB, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GB");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GR, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GR");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_R, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_R");
> + return ret;
> + }
> +
> + return ret;
> +}
> +
> +static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern)
> +{
> + if (pattern)
> + pattern = (pattern - 1) << OV01A10_TEST_PATTERN_BAR_SHIFT |
> + OV01A10_TEST_PATTERN_ENABLE;
> +
> + return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern);
> +}
> +
> +static int ov01a10_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
> + struct ov01a10 *ov01a10 = container_of(ctrl->handler,
> + struct ov01a10, ctrl_handler);
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + s64 exposure_max;
> + int ret = 0;
> +
> + if (ctrl->id == V4L2_CID_VBLANK) {
> + exposure_max = ov01a10->cur_mode->height + ctrl->val -
> + OV01A10_EXPOSURE_MAX_MARGIN;
> + __v4l2_ctrl_modify_range(ov01a10->exposure,
> + ov01a10->exposure->minimum,
> + exposure_max, ov01a10->exposure->step,
> + exposure_max);
> + }
> +
> + if (!pm_runtime_get_if_in_use(&client->dev))
> + return 0;
> +
> + switch (ctrl->id) {
> + case V4L2_CID_ANALOGUE_GAIN:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_ANALOG_GAIN, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_DIGITAL_GAIN:
> + ret = ov01a10_update_digital_gain(ov01a10, ctrl->val);
> + break;
> +
> + case V4L2_CID_EXPOSURE:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_EXPOSURE, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_VBLANK:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_VTS, 2,
> + ov01a10->cur_mode->height + ctrl->val);
> + break;
> +
> + case V4L2_CID_TEST_PATTERN:
> + ret = ov01a10_test_pattern(ov01a10, ctrl->val);
> + break;
> +
> + default:
> + ret = -EINVAL;
> + break;
> + }
> +
> + pm_runtime_put(&client->dev);
> +
> + return ret;
> +}
> +
> +static const struct v4l2_ctrl_ops ov01a10_ctrl_ops = {
> + .s_ctrl = ov01a10_set_ctrl,
> +};
> +
> +static int ov01a10_init_controls(struct ov01a10 *ov01a10)
> +{
> + struct v4l2_ctrl_handler *ctrl_hdlr;
> + const struct ov01a10_mode *cur_mode;
> + s64 exposure_max, h_blank;
> + u32 vblank_min, vblank_max, vblank_default;
> + int size;
> + int ret = 0;
> +
> + ctrl_hdlr = &ov01a10->ctrl_handler;
> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
> + if (ret)
> + return ret;
> +
> + ctrl_hdlr->lock = &ov01a10->mutex;
> + cur_mode = ov01a10->cur_mode;
> + size = ARRAY_SIZE(link_freq_menu_items);
> +
> + ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> + &ov01a10_ctrl_ops,
> + V4L2_CID_LINK_FREQ,
> + size - 1, 0,
> + link_freq_menu_items);
> + if (ov01a10->link_freq)
> + ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_PIXEL_RATE, 0,
> + OV01A10_SCLK, 1, OV01A10_SCLK);
> +
> + vblank_min = cur_mode->vts_min - cur_mode->height;
> + vblank_max = OV01A10_VTS_MAX - cur_mode->height;
> + vblank_default = cur_mode->vts_def - cur_mode->height;
> + ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_VBLANK, vblank_min,
> + vblank_max, 1, vblank_default);
> +
> + h_blank = cur_mode->hts - cur_mode->width;
> + ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_HBLANK, h_blank, h_blank,
> + 1, h_blank);
> + if (ov01a10->hblank)
> + ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
> + OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
> + OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
> + OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
> + OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
> + exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
> + ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_EXPOSURE,
> + OV01A10_EXPOSURE_MIN,
> + exposure_max,
> + OV01A10_EXPOSURE_STEP,
> + exposure_max);
> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_TEST_PATTERN,
> + ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
> + 0, 0, ov01a10_test_pattern_menu);
> + if (ctrl_hdlr->error)
> + return ctrl_hdlr->error;
> +
> + ov01a10->sd.ctrl_handler = ctrl_hdlr;
> +
> + return 0;
> +}
> +
> +static void ov01a10_update_pad_format(const struct ov01a10_mode *mode,
> + struct v4l2_mbus_framefmt *fmt)
> +{
> + fmt->width = mode->width;
> + fmt->height = mode->height;
> + fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> + fmt->field = V4L2_FIELD_NONE;
> +}
> +
> +static int ov01a10_start_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + const struct ov01a10_reg_list *reg_list;
> + int link_freq_index;
> + int ret = 0;
> +
> + link_freq_index = ov01a10->cur_mode->link_freq_index;
> + reg_list = &link_freq_configs[link_freq_index].reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set plls\n");
> + return ret;
> + }
> +
> + reg_list = &ov01a10->cur_mode->reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set mode\n");
> + return ret;
> + }
> +
> + ret = __v4l2_ctrl_handler_setup(ov01a10->sd.ctrl_handler);
> + if (ret)
> + return ret;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STREAMING);
> + if (ret)
> + dev_err(&client->dev, "failed to start streaming\n");
> +
> + return ret;
> +}
> +
> +static void ov01a10_stop_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STANDBY);
> + if (ret)
> + dev_err(&client->dev, "failed to stop streaming");
> +
> +}
> +
> +static int ov01a10_set_stream(struct v4l2_subdev *sd, int enable)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + struct i2c_client *client = v4l2_get_subdevdata(sd);
> + int ret = 0;
> +
> + if (ov01a10->streaming == enable)
> + return 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (enable) {
> + ret = pm_runtime_get_sync(&client->dev);
> + if (ret < 0) {
> + pm_runtime_put_noidle(&client->dev);
> + mutex_unlock(&ov01a10->mutex);
> + return ret;
> + }
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + enable = 0;
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> + } else {
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> +
> + ov01a10->streaming = enable;
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int __maybe_unused ov01a10_suspend(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (ov01a10->streaming)
> + ov01a10_stop_streaming(ov01a10);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused ov01a10_resume(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + int ret = 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (!ov01a10->streaming)
> + goto exit;
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + ov01a10->streaming = false;
> + ov01a10_stop_streaming(ov01a10);
> + }
> +
> +exit:
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int ov01a10_set_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + const struct ov01a10_mode *mode;
> + s32 vblank_def, h_blank;
> +
> + mode = v4l2_find_nearest_size(supported_modes,
> + ARRAY_SIZE(supported_modes), width,
> + height, fmt->format.width,
> + fmt->format.height);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(mode, &fmt->format);
Could you switch to the sub-device state? That is now the preferred way to
serialise access to e.g. the format.
See e.g.
<URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
The control handler's mutex doubles as a sub-device state mutex.
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> + *v4l2_subdev_get_try_format(sd, sd_state, fmt->pad) = fmt->format;
> + } else {
> + ov01a10->cur_mode = mode;
> + __v4l2_ctrl_s_ctrl(ov01a10->link_freq, mode->link_freq_index);
> + __v4l2_ctrl_s_ctrl_int64(ov01a10->pixel_rate, OV01A10_SCLK);
> +
> + vblank_def = mode->vts_def - mode->height;
> + __v4l2_ctrl_modify_range(ov01a10->vblank,
> + mode->vts_min - mode->height,
> + OV01A10_VTS_MAX - mode->height, 1,
> + vblank_def);
> + __v4l2_ctrl_s_ctrl(ov01a10->vblank, vblank_def);
> + h_blank = mode->hts - mode->width;
> + __v4l2_ctrl_modify_range(ov01a10->hblank, h_blank, h_blank, 1,
> + h_blank);
> + }
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_get_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
> + fmt->format = *v4l2_subdev_get_try_format(&ov01a10->sd,
> + sd_state, fmt->pad);
> + else
> + ov01a10_update_pad_format(ov01a10->cur_mode, &fmt->format);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + if (code->index > 0)
> + return -EINVAL;
> +
> + code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_frame_size_enum *fse)
> +{
> + if (fse->index >= ARRAY_SIZE(supported_modes))
> + return -EINVAL;
> +
> + if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
> + return -EINVAL;
> +
> + fse->min_width = supported_modes[fse->index].width;
> + fse->max_width = fse->min_width;
> + fse->min_height = supported_modes[fse->index].height;
> + fse->max_height = fse->min_height;
> +
> + return 0;
> +}
> +
> +static int ov01a10_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(&supported_modes[0],
> + v4l2_subdev_get_try_format(sd, fh->state, 0));
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static const struct v4l2_subdev_core_ops ov01a10_core_ops = {
> + .log_status = v4l2_ctrl_subdev_log_status,
> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> + .unsubscribe_event = v4l2_event_subdev_unsubscribe,
> +};
> +
> +static const struct v4l2_subdev_video_ops ov01a10_video_ops = {
> + .s_stream = ov01a10_set_stream,
> +};
> +
> +static const struct v4l2_subdev_pad_ops ov01a10_pad_ops = {
> + .set_fmt = ov01a10_set_format,
> + .get_fmt = ov01a10_get_format,
> + .enum_mbus_code = ov01a10_enum_mbus_code,
> + .enum_frame_size = ov01a10_enum_frame_size,
> +};
> +
> +static const struct v4l2_subdev_ops ov01a10_subdev_ops = {
> + .core = &ov01a10_core_ops,
> + .video = &ov01a10_video_ops,
> + .pad = &ov01a10_pad_ops,
> +};
> +
> +static const struct media_entity_operations ov01a10_subdev_entity_ops = {
> + .link_validate = v4l2_subdev_link_validate,
> +};
> +
> +static const struct v4l2_subdev_internal_ops ov01a10_internal_ops = {
> + .open = ov01a10_open,
> +};
> +
> +static int ov01a10_identify_module(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret;
> + u32 val;
> +
> + ret = ov01a10_read_reg(ov01a10, OV01A10_REG_CHIP_ID, 3, &val);
> + if (ret)
> + return ret;
> +
> + if (val != OV01A10_CHIP_ID) {
> + dev_err(&client->dev, "chip id mismatch: %x!=%x\n",
> + OV01A10_CHIP_ID, val);
> + return -EIO;
> + }
> +
> + return 0;
> +}
> +
> +static void ov01a10_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + media_entity_cleanup(&sd->entity);
> + v4l2_ctrl_handler_free(sd->ctrl_handler);
> +
> + pm_runtime_disable(&client->dev);
> + mutex_destroy(&ov01a10->mutex);
> +}
> +
> +static int ov01a10_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct ov01a10 *ov01a10;
> + int ret = 0;
> +
> + ov01a10 = devm_kzalloc(dev, sizeof(*ov01a10), GFP_KERNEL);
> + if (!ov01a10)
> + return -ENOMEM;
> +
> + v4l2_i2c_subdev_init(&ov01a10->sd, client, &ov01a10_subdev_ops);
> +
> + ret = ov01a10_identify_module(ov01a10);
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "failed to find sensor\n");
> +
> + mutex_init(&ov01a10->mutex);
> + ov01a10->cur_mode = &supported_modes[0];
> +
> + ret = ov01a10_init_controls(ov01a10);
> + if (ret) {
> + dev_err(dev, "failed to init controls: %d\n", ret);
> + goto err_mutex_destroy;
> + }
> +
> + ov01a10->sd.internal_ops = &ov01a10_internal_ops;
> + ov01a10->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> + V4L2_SUBDEV_FL_HAS_EVENTS;
> + ov01a10->sd.entity.ops = &ov01a10_subdev_entity_ops;
> + ov01a10->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + ov01a10->pad.flags = MEDIA_PAD_FL_SOURCE;
> +
> + ret = media_entity_pads_init(&ov01a10->sd.entity, 1, &ov01a10->pad);
> + if (ret) {
> + dev_err(dev, "failed to init entity pads: %d\n", ret);
> + goto err_handler_free;
> + }
> +
> + ret = v4l2_async_register_subdev_sensor(&ov01a10->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register subdev: %d\n",
> + ret);
> + goto err_media_entity_cleanup;
> + }
> +
> + pm_runtime_enable(dev);
> + pm_runtime_idle(dev);
> +
> + return 0;
> +
> +err_media_entity_cleanup:
> + media_entity_cleanup(&ov01a10->sd.entity);
> +
> +err_handler_free:
> + v4l2_ctrl_handler_free(ov01a10->sd.ctrl_handler);
> +
> +err_mutex_destroy:
> + mutex_destroy(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static const struct dev_pm_ops ov01a10_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(ov01a10_suspend, ov01a10_resume)
> +};
> +
> +static const struct acpi_device_id ov01a10_acpi_ids[] = {
> + {"OVTI01A0"},
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(acpi, ov01a10_acpi_ids);
> +
> +static struct i2c_driver ov01a10_i2c_driver = {
> + .driver = {
> + .name = "ov01a10",
> + .pm = &ov01a10_pm_ops,
> + .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
> + },
> + .probe_new = ov01a10_probe,
> + .remove = ov01a10_remove,
> +};
> +
> +module_i2c_driver(ov01a10_i2c_driver);
> +
> +MODULE_AUTHOR("Bingbu Cao <bingbu.cao@intel.com>");
> +MODULE_AUTHOR("Wang Yating <yating.wang@intel.com>");
> +MODULE_DESCRIPTION("OmniVision OV01A10 sensor driver");
> +MODULE_LICENSE("GPL v2");
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 12:40 ` Dave Stevenson
@ 2023-02-09 13:15 ` Sakari Ailus
2023-04-13 7:58 ` Bingbu Cao
1 sibling, 0 replies; 13+ messages in thread
From: Sakari Ailus @ 2023-02-09 13:15 UTC (permalink / raw)
To: Dave Stevenson; +Cc: Bingbu Cao, linux-media, bingbu.cao, yating.wang
Hi Dave,
On Thu, Feb 09, 2023 at 12:40:43PM +0000, Dave Stevenson wrote:
> > +static struct i2c_driver ov01a10_i2c_driver = {
> > + .driver = {
> > + .name = "ov01a10",
> > + .pm = &ov01a10_pm_ops,
> > + .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
>
> As you're only supporting ACPI here, make ACPI a dependency in Kconfig?
I wonder if || COMPILE_TEST should be added as there's nothing ACPI
specific in this driver, it's that only ACPI is supported.
Very few drivers have firmware type dependencies currently.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 11:22 [PATCH] media: i2c: add ov01a10 image sensor driver Bingbu Cao
2023-02-09 12:40 ` Dave Stevenson
2023-02-09 13:06 ` Sakari Ailus
@ 2023-02-09 14:41 ` Kieran Bingham
2 siblings, 0 replies; 13+ messages in thread
From: Kieran Bingham @ 2023-02-09 14:41 UTC (permalink / raw)
To: Bingbu Cao, linux-media, sakari.ailus; +Cc: bingbu.cao, bingbu.cao, yating.wang
Quoting Bingbu Cao (2023-02-09 11:22:38)
> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
Could you also implement the V4L2 Selection API please?
V4L2_SEL_TGT_CROP_DEFAULT
V4L2_SEL_TGT_CROP
V4L2_SEL_TGT_CROP_BOUNDS
https://git.libcamera.org/libcamera/libcamera.git/tree/Documentation/sensor_driver_requirements.rst
may have other details to check too.
--
Regards
Kieran
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Signed-off-by: Yating Wang <yating.wang@intel.com>
> ---
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 920 insertions(+)
> create mode 100644 drivers/media/i2c/ov01a10.c
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 833241897d63..8e5d1ef0616f 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -338,6 +338,19 @@ config VIDEO_OG01A1B
> To compile this driver as a module, choose M here: the
> module will be called og01a1b.
>
> +config VIDEO_OV01A10
> + tristate "OmniVision OV01A10 sensor support"
> + depends on VIDEO_DEV && I2C
> + select MEDIA_CONTROLLER
> + select VIDEO_V4L2_SUBDEV_API
> + select V4L2_FWNODE
> + help
> + This is a Video4Linux2 sensor driver for the OmniVision
> + OV01A10 camera.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called ov01a10.
> +
> config VIDEO_OV02A10
> tristate "OmniVision OV02A10 sensor support"
> depends on VIDEO_DEV && I2C
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 4d6c052bb5a7..ce214503b526 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o
> obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o
> obj-$(CONFIG_VIDEO_NOON010PC30) += noon010pc30.o
> obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o
> +obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o
> obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o
> obj-$(CONFIG_VIDEO_OV08D10) += ov08d10.o
> obj-$(CONFIG_VIDEO_OV08X40) += ov08x40.o
> diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
> new file mode 100644
> index 000000000000..13de9f9ccdc8
> --- /dev/null
> +++ b/drivers/media/i2c/ov01a10.c
> @@ -0,0 +1,906 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2020-2021 Intel Corporation.
> +
> +#include <asm/unaligned.h>
> +
> +#include <linux/acpi.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> +#include <media/v4l2-fwnode.h>
> +
> +#define OV01A10_LINK_FREQ_400MHZ 400000000ULL
> +#define OV01A10_SCLK 40000000LL
> +#define OV01A10_MCLK 19200000
> +#define OV01A10_DATA_LANES 1
> +#define OV01A10_RGB_DEPTH 10
> +
> +#define OV01A10_REG_CHIP_ID 0x300a
> +#define OV01A10_CHIP_ID 0x560141
> +
> +#define OV01A10_REG_MODE_SELECT 0x0100
> +#define OV01A10_MODE_STANDBY 0x00
> +#define OV01A10_MODE_STREAMING 0x01
> +
> +/* vertical timings */
> +#define OV01A10_REG_VTS 0x380e
> +#define OV01A10_VTS_DEF 0x0380
> +#define OV01A10_VTS_MIN 0x0380
> +#define OV01A10_VTS_MAX 0xffff
> +
> +/* exposure controls */
> +#define OV01A10_REG_EXPOSURE 0x3501
> +#define OV01A10_EXPOSURE_MIN 4
> +#define OV01A10_EXPOSURE_MAX_MARGIN 8
> +#define OV01A10_EXPOSURE_STEP 1
> +
> +/* analog gain controls */
> +#define OV01A10_REG_ANALOG_GAIN 0x3508
> +#define OV01A10_ANAL_GAIN_MIN 0x100
> +#define OV01A10_ANAL_GAIN_MAX 0xffff
> +#define OV01A10_ANAL_GAIN_STEP 1
> +
> +/* digital gain controls */
> +#define OV01A10_REG_DIGILAL_GAIN_B 0x350A
> +#define OV01A10_REG_DIGITAL_GAIN_GB 0x3510
> +#define OV01A10_REG_DIGITAL_GAIN_GR 0x3513
> +#define OV01A10_REG_DIGITAL_GAIN_R 0x3516
> +#define OV01A10_DGTL_GAIN_MIN 0
> +#define OV01A10_DGTL_GAIN_MAX 0x3ffff
> +#define OV01A10_DGTL_GAIN_STEP 1
> +#define OV01A10_DGTL_GAIN_DEFAULT 1024
> +
> +/* test pattern control */
> +#define OV01A10_REG_TEST_PATTERN 0x4503
> +#define OV01A10_TEST_PATTERN_ENABLE BIT(7)
> +#define OV01A10_TEST_PATTERN_BAR_SHIFT 0
> +
> +enum {
> + OV01A10_LINK_FREQ_400MHZ_INDEX,
> +};
> +
> +struct ov01a10_reg {
> + u16 address;
> + u8 val;
> +};
> +
> +struct ov01a10_reg_list {
> + u32 num_of_regs;
> + const struct ov01a10_reg *regs;
> +};
> +
> +struct ov01a10_link_freq_config {
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +struct ov01a10_mode {
> + u32 width;
> + u32 height;
> + u32 hts;
> + u32 vts_def;
> + u32 vts_min;
> + u32 link_freq_index;
> +
> + const struct ov01a10_reg_list reg_list;
> +};
> +
> +static const struct ov01a10_reg mipi_data_rate_720mbps[] = {
> +};
> +
> +static const struct ov01a10_reg sensor_1280x800_setting[] = {
> + {0x0103, 0x01},
> + {0x0302, 0x00},
> + {0x0303, 0x06},
> + {0x0304, 0x01},
> + {0x0305, 0xe0},
> + {0x0306, 0x00},
> + {0x0308, 0x01},
> + {0x0309, 0x00},
> + {0x030c, 0x01},
> + {0x0322, 0x01},
> + {0x0323, 0x06},
> + {0x0324, 0x01},
> + {0x0325, 0x68},
> + {0x3002, 0xa1},
> + {0x301e, 0xf0},
> + {0x3022, 0x01},
> + {0x3501, 0x03},
> + {0x3502, 0x78},
> + {0x3504, 0x0c},
> + {0x3508, 0x01},
> + {0x3509, 0x00},
> + {0x3601, 0xc0},
> + {0x3603, 0x71},
> + {0x3610, 0x68},
> + {0x3611, 0x86},
> + {0x3640, 0x10},
> + {0x3641, 0x80},
> + {0x3642, 0xdc},
> + {0x3646, 0x55},
> + {0x3647, 0x57},
> + {0x364b, 0x00},
> + {0x3653, 0x10},
> + {0x3655, 0x00},
> + {0x3656, 0x00},
> + {0x365f, 0x0f},
> + {0x3661, 0x45},
> + {0x3662, 0x24},
> + {0x3663, 0x11},
> + {0x3664, 0x07},
> + {0x3709, 0x34},
> + {0x370b, 0x6f},
> + {0x3714, 0x22},
> + {0x371b, 0x27},
> + {0x371c, 0x67},
> + {0x371d, 0xa7},
> + {0x371e, 0xe7},
> + {0x3730, 0x81},
> + {0x3733, 0x10},
> + {0x3734, 0x40},
> + {0x3737, 0x04},
> + {0x3739, 0x1c},
> + {0x3767, 0x00},
> + {0x376c, 0x81},
> + {0x3772, 0x14},
> + {0x37c2, 0x04},
> + {0x37d8, 0x03},
> + {0x37d9, 0x0c},
> + {0x37e0, 0x00},
> + {0x37e1, 0x08},
> + {0x37e2, 0x10},
> + {0x37e3, 0x04},
> + {0x37e4, 0x04},
> + {0x37e5, 0x03},
> + {0x37e6, 0x04},
> + {0x3800, 0x00},
> + {0x3801, 0x00},
> + {0x3802, 0x00},
> + {0x3803, 0x00},
> + {0x3804, 0x05},
> + {0x3805, 0x0f},
> + {0x3806, 0x03},
> + {0x3807, 0x2f},
> + {0x3808, 0x05},
> + {0x3809, 0x00},
> + {0x380a, 0x03},
> + {0x380b, 0x20},
> + {0x380c, 0x02},
> + {0x380d, 0xe8},
> + {0x380e, 0x03},
> + {0x380f, 0x80},
> + {0x3810, 0x00},
> + {0x3811, 0x09},
> + {0x3812, 0x00},
> + {0x3813, 0x08},
> + {0x3814, 0x01},
> + {0x3815, 0x01},
> + {0x3816, 0x01},
> + {0x3817, 0x01},
> + {0x3820, 0xa8},
> + {0x3822, 0x13},
> + {0x3832, 0x28},
> + {0x3833, 0x10},
> + {0x3b00, 0x00},
> + {0x3c80, 0x00},
> + {0x3c88, 0x02},
> + {0x3c8c, 0x07},
> + {0x3c8d, 0x40},
> + {0x3cc7, 0x80},
> + {0x4000, 0xc3},
> + {0x4001, 0xe0},
> + {0x4003, 0x40},
> + {0x4008, 0x02},
> + {0x4009, 0x19},
> + {0x400a, 0x01},
> + {0x400b, 0x6c},
> + {0x4011, 0x00},
> + {0x4041, 0x00},
> + {0x4300, 0xff},
> + {0x4301, 0x00},
> + {0x4302, 0x0f},
> + {0x4503, 0x00},
> + {0x4601, 0x50},
> + {0x4800, 0x64},
> + {0x481f, 0x34},
> + {0x4825, 0x33},
> + {0x4837, 0x11},
> + {0x4881, 0x40},
> + {0x4883, 0x01},
> + {0x4890, 0x00},
> + {0x4901, 0x00},
> + {0x4902, 0x00},
> + {0x4b00, 0x2a},
> + {0x4b0d, 0x00},
> + {0x450a, 0x04},
> + {0x450b, 0x00},
> + {0x5000, 0x65},
> + {0x5200, 0x18},
> + {0x5004, 0x00},
> + {0x5080, 0x40},
> + {0x0305, 0xf4},
> + {0x0325, 0xc2},
> +};
> +
> +static const char * const ov01a10_test_pattern_menu[] = {
> + "Disabled",
> + "Color Bar",
> + "Top-Bottom Darker Color Bar",
> + "Right-Left Darker Color Bar",
> + "Color Bar type 4",
> +};
> +
> +static const s64 link_freq_menu_items[] = {
> + OV01A10_LINK_FREQ_400MHZ,
> +};
> +
> +static const struct ov01a10_link_freq_config link_freq_configs[] = {
> + [OV01A10_LINK_FREQ_400MHZ_INDEX] = {
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(mipi_data_rate_720mbps),
> + .regs = mipi_data_rate_720mbps,
> + }
> + },
> +};
> +
> +static const struct ov01a10_mode supported_modes[] = {
> + {
> + .width = 1280,
> + .height = 800,
> + .hts = 1488,
> + .vts_def = OV01A10_VTS_DEF,
> + .vts_min = OV01A10_VTS_MIN,
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(sensor_1280x800_setting),
> + .regs = sensor_1280x800_setting,
> + },
> + .link_freq_index = OV01A10_LINK_FREQ_400MHZ_INDEX,
> + },
> +};
> +
> +struct ov01a10 {
> + struct v4l2_subdev sd;
> + struct media_pad pad;
> + struct v4l2_ctrl_handler ctrl_handler;
> +
> + /* v4l2 controls */
> + struct v4l2_ctrl *link_freq;
> + struct v4l2_ctrl *pixel_rate;
> + struct v4l2_ctrl *vblank;
> + struct v4l2_ctrl *hblank;
> + struct v4l2_ctrl *exposure;
> +
> + const struct ov01a10_mode *cur_mode;
> +
> + /* serialize asynchronous callbacks */
> + struct mutex mutex;
> +
> + /* streaming state */
> + bool streaming;
> +};
> +
> +static inline struct ov01a10 *to_ov01a10(struct v4l2_subdev *subdev)
> +{
> + return container_of(subdev, struct ov01a10, sd);
> +}
> +
> +static int ov01a10_read_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 *val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + struct i2c_msg msgs[2];
> + u8 addr_buf[2];
> + u8 data_buf[4] = {0};
> + int ret = 0;
> +
> + if (len > sizeof(data_buf))
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, addr_buf);
> + msgs[0].addr = client->addr;
> + msgs[0].flags = 0;
> + msgs[0].len = sizeof(addr_buf);
> + msgs[0].buf = addr_buf;
> + msgs[1].addr = client->addr;
> + msgs[1].flags = I2C_M_RD;
> + msgs[1].len = len;
> + msgs[1].buf = &data_buf[sizeof(data_buf) - len];
> +
> + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
> +
> + if (ret != ARRAY_SIZE(msgs))
> + return ret < 0 ? ret : -EIO;
> +
> + *val = get_unaligned_be32(data_buf);
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg(struct ov01a10 *ov01a10, u16 reg, u16 len, u32 val)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u8 buf[6];
> + int ret = 0;
> +
> + if (len > 4)
> + return -EINVAL;
> +
> + put_unaligned_be16(reg, buf);
> + put_unaligned_be32(val << 8 * (4 - len), buf + 2);
> +
> + ret = i2c_master_send(client, buf, len + 2);
> + if (ret != len + 2)
> + return ret < 0 ? ret : -EIO;
> +
> + return 0;
> +}
> +
> +static int ov01a10_write_reg_list(struct ov01a10 *ov01a10,
> + const struct ov01a10_reg_list *r_list)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + unsigned int i;
> + int ret = 0;
> +
> + for (i = 0; i < r_list->num_of_regs; i++) {
> + ret = ov01a10_write_reg(ov01a10, r_list->regs[i].address, 1,
> + r_list->regs[i].val);
> + if (ret) {
> + dev_err_ratelimited(&client->dev,
> + "write reg 0x%4.4x return err = %d",
> + r_list->regs[i].address, ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}
> +
> +static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + u32 real = d_gain << 6;
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGILAL_GAIN_B, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_B");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GB, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GB");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_GR, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_GR");
> + return ret;
> + }
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_DIGITAL_GAIN_R, 3, real);
> + if (ret) {
> + dev_err(&client->dev, "failed to set OV01A10_REG_DIGITAL_GAIN_R");
> + return ret;
> + }
> +
> + return ret;
> +}
> +
> +static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern)
> +{
> + if (pattern)
> + pattern = (pattern - 1) << OV01A10_TEST_PATTERN_BAR_SHIFT |
> + OV01A10_TEST_PATTERN_ENABLE;
> +
> + return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern);
> +}
> +
> +static int ov01a10_set_ctrl(struct v4l2_ctrl *ctrl)
> +{
> + struct ov01a10 *ov01a10 = container_of(ctrl->handler,
> + struct ov01a10, ctrl_handler);
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + s64 exposure_max;
> + int ret = 0;
> +
> + if (ctrl->id == V4L2_CID_VBLANK) {
> + exposure_max = ov01a10->cur_mode->height + ctrl->val -
> + OV01A10_EXPOSURE_MAX_MARGIN;
> + __v4l2_ctrl_modify_range(ov01a10->exposure,
> + ov01a10->exposure->minimum,
> + exposure_max, ov01a10->exposure->step,
> + exposure_max);
> + }
> +
> + if (!pm_runtime_get_if_in_use(&client->dev))
> + return 0;
> +
> + switch (ctrl->id) {
> + case V4L2_CID_ANALOGUE_GAIN:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_ANALOG_GAIN, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_DIGITAL_GAIN:
> + ret = ov01a10_update_digital_gain(ov01a10, ctrl->val);
> + break;
> +
> + case V4L2_CID_EXPOSURE:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_EXPOSURE, 2,
> + ctrl->val);
> + break;
> +
> + case V4L2_CID_VBLANK:
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_VTS, 2,
> + ov01a10->cur_mode->height + ctrl->val);
> + break;
> +
> + case V4L2_CID_TEST_PATTERN:
> + ret = ov01a10_test_pattern(ov01a10, ctrl->val);
> + break;
> +
> + default:
> + ret = -EINVAL;
> + break;
> + }
> +
> + pm_runtime_put(&client->dev);
> +
> + return ret;
> +}
> +
> +static const struct v4l2_ctrl_ops ov01a10_ctrl_ops = {
> + .s_ctrl = ov01a10_set_ctrl,
> +};
> +
> +static int ov01a10_init_controls(struct ov01a10 *ov01a10)
> +{
> + struct v4l2_ctrl_handler *ctrl_hdlr;
> + const struct ov01a10_mode *cur_mode;
> + s64 exposure_max, h_blank;
> + u32 vblank_min, vblank_max, vblank_default;
> + int size;
> + int ret = 0;
> +
> + ctrl_hdlr = &ov01a10->ctrl_handler;
> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
> + if (ret)
> + return ret;
> +
> + ctrl_hdlr->lock = &ov01a10->mutex;
> + cur_mode = ov01a10->cur_mode;
> + size = ARRAY_SIZE(link_freq_menu_items);
> +
> + ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> + &ov01a10_ctrl_ops,
> + V4L2_CID_LINK_FREQ,
> + size - 1, 0,
> + link_freq_menu_items);
> + if (ov01a10->link_freq)
> + ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_PIXEL_RATE, 0,
> + OV01A10_SCLK, 1, OV01A10_SCLK);
> +
> + vblank_min = cur_mode->vts_min - cur_mode->height;
> + vblank_max = OV01A10_VTS_MAX - cur_mode->height;
> + vblank_default = cur_mode->vts_def - cur_mode->height;
> + ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_VBLANK, vblank_min,
> + vblank_max, 1, vblank_default);
> +
> + h_blank = cur_mode->hts - cur_mode->width;
> + ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_HBLANK, h_blank, h_blank,
> + 1, h_blank);
> + if (ov01a10->hblank)
> + ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
> + OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
> + OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
> + OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
> + OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
> + exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
> + ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_EXPOSURE,
> + OV01A10_EXPOSURE_MIN,
> + exposure_max,
> + OV01A10_EXPOSURE_STEP,
> + exposure_max);
> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
> + V4L2_CID_TEST_PATTERN,
> + ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
> + 0, 0, ov01a10_test_pattern_menu);
> + if (ctrl_hdlr->error)
> + return ctrl_hdlr->error;
> +
> + ov01a10->sd.ctrl_handler = ctrl_hdlr;
> +
> + return 0;
> +}
> +
> +static void ov01a10_update_pad_format(const struct ov01a10_mode *mode,
> + struct v4l2_mbus_framefmt *fmt)
> +{
> + fmt->width = mode->width;
> + fmt->height = mode->height;
> + fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> + fmt->field = V4L2_FIELD_NONE;
> +}
> +
> +static int ov01a10_start_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + const struct ov01a10_reg_list *reg_list;
> + int link_freq_index;
> + int ret = 0;
> +
> + link_freq_index = ov01a10->cur_mode->link_freq_index;
> + reg_list = &link_freq_configs[link_freq_index].reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set plls\n");
> + return ret;
> + }
> +
> + reg_list = &ov01a10->cur_mode->reg_list;
> + ret = ov01a10_write_reg_list(ov01a10, reg_list);
> + if (ret) {
> + dev_err(&client->dev, "failed to set mode\n");
> + return ret;
> + }
> +
> + ret = __v4l2_ctrl_handler_setup(ov01a10->sd.ctrl_handler);
> + if (ret)
> + return ret;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STREAMING);
> + if (ret)
> + dev_err(&client->dev, "failed to start streaming\n");
> +
> + return ret;
> +}
> +
> +static void ov01a10_stop_streaming(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret = 0;
> +
> + ret = ov01a10_write_reg(ov01a10, OV01A10_REG_MODE_SELECT, 1,
> + OV01A10_MODE_STANDBY);
> + if (ret)
> + dev_err(&client->dev, "failed to stop streaming");
> +
> +}
> +
> +static int ov01a10_set_stream(struct v4l2_subdev *sd, int enable)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + struct i2c_client *client = v4l2_get_subdevdata(sd);
> + int ret = 0;
> +
> + if (ov01a10->streaming == enable)
> + return 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (enable) {
> + ret = pm_runtime_get_sync(&client->dev);
> + if (ret < 0) {
> + pm_runtime_put_noidle(&client->dev);
> + mutex_unlock(&ov01a10->mutex);
> + return ret;
> + }
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + enable = 0;
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> + } else {
> + ov01a10_stop_streaming(ov01a10);
> + pm_runtime_put(&client->dev);
> + }
> +
> + ov01a10->streaming = enable;
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int __maybe_unused ov01a10_suspend(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (ov01a10->streaming)
> + ov01a10_stop_streaming(ov01a10);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int __maybe_unused ov01a10_resume(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + int ret = 0;
> +
> + mutex_lock(&ov01a10->mutex);
> + if (!ov01a10->streaming)
> + goto exit;
> +
> + ret = ov01a10_start_streaming(ov01a10);
> + if (ret) {
> + ov01a10->streaming = false;
> + ov01a10_stop_streaming(ov01a10);
> + }
> +
> +exit:
> + mutex_unlock(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static int ov01a10_set_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> + const struct ov01a10_mode *mode;
> + s32 vblank_def, h_blank;
> +
> + mode = v4l2_find_nearest_size(supported_modes,
> + ARRAY_SIZE(supported_modes), width,
> + height, fmt->format.width,
> + fmt->format.height);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(mode, &fmt->format);
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
> + *v4l2_subdev_get_try_format(sd, sd_state, fmt->pad) = fmt->format;
> + } else {
> + ov01a10->cur_mode = mode;
> + __v4l2_ctrl_s_ctrl(ov01a10->link_freq, mode->link_freq_index);
> + __v4l2_ctrl_s_ctrl_int64(ov01a10->pixel_rate, OV01A10_SCLK);
> +
> + vblank_def = mode->vts_def - mode->height;
> + __v4l2_ctrl_modify_range(ov01a10->vblank,
> + mode->vts_min - mode->height,
> + OV01A10_VTS_MAX - mode->height, 1,
> + vblank_def);
> + __v4l2_ctrl_s_ctrl(ov01a10->vblank, vblank_def);
> + h_blank = mode->hts - mode->width;
> + __v4l2_ctrl_modify_range(ov01a10->hblank, h_blank, h_blank, 1,
> + h_blank);
> + }
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_get_format(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_format *fmt)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
> + fmt->format = *v4l2_subdev_get_try_format(&ov01a10->sd,
> + sd_state, fmt->pad);
> + else
> + ov01a10_update_pad_format(ov01a10->cur_mode, &fmt->format);
> +
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_mbus_code(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_mbus_code_enum *code)
> +{
> + if (code->index > 0)
> + return -EINVAL;
> +
> + code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> +
> + return 0;
> +}
> +
> +static int ov01a10_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *sd_state,
> + struct v4l2_subdev_frame_size_enum *fse)
> +{
> + if (fse->index >= ARRAY_SIZE(supported_modes))
> + return -EINVAL;
> +
> + if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
> + return -EINVAL;
> +
> + fse->min_width = supported_modes[fse->index].width;
> + fse->max_width = fse->min_width;
> + fse->min_height = supported_modes[fse->index].height;
> + fse->max_height = fse->min_height;
> +
> + return 0;
> +}
> +
> +static int ov01a10_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> +{
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + mutex_lock(&ov01a10->mutex);
> + ov01a10_update_pad_format(&supported_modes[0],
> + v4l2_subdev_get_try_format(sd, fh->state, 0));
> + mutex_unlock(&ov01a10->mutex);
> +
> + return 0;
> +}
> +
> +static const struct v4l2_subdev_core_ops ov01a10_core_ops = {
> + .log_status = v4l2_ctrl_subdev_log_status,
> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> + .unsubscribe_event = v4l2_event_subdev_unsubscribe,
> +};
> +
> +static const struct v4l2_subdev_video_ops ov01a10_video_ops = {
> + .s_stream = ov01a10_set_stream,
> +};
> +
> +static const struct v4l2_subdev_pad_ops ov01a10_pad_ops = {
> + .set_fmt = ov01a10_set_format,
> + .get_fmt = ov01a10_get_format,
> + .enum_mbus_code = ov01a10_enum_mbus_code,
> + .enum_frame_size = ov01a10_enum_frame_size,
> +};
> +
> +static const struct v4l2_subdev_ops ov01a10_subdev_ops = {
> + .core = &ov01a10_core_ops,
> + .video = &ov01a10_video_ops,
> + .pad = &ov01a10_pad_ops,
> +};
> +
> +static const struct media_entity_operations ov01a10_subdev_entity_ops = {
> + .link_validate = v4l2_subdev_link_validate,
> +};
> +
> +static const struct v4l2_subdev_internal_ops ov01a10_internal_ops = {
> + .open = ov01a10_open,
> +};
> +
> +static int ov01a10_identify_module(struct ov01a10 *ov01a10)
> +{
> + struct i2c_client *client = v4l2_get_subdevdata(&ov01a10->sd);
> + int ret;
> + u32 val;
> +
> + ret = ov01a10_read_reg(ov01a10, OV01A10_REG_CHIP_ID, 3, &val);
> + if (ret)
> + return ret;
> +
> + if (val != OV01A10_CHIP_ID) {
> + dev_err(&client->dev, "chip id mismatch: %x!=%x\n",
> + OV01A10_CHIP_ID, val);
> + return -EIO;
> + }
> +
> + return 0;
> +}
> +
> +static void ov01a10_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + media_entity_cleanup(&sd->entity);
> + v4l2_ctrl_handler_free(sd->ctrl_handler);
> +
> + pm_runtime_disable(&client->dev);
> + mutex_destroy(&ov01a10->mutex);
> +}
> +
> +static int ov01a10_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct ov01a10 *ov01a10;
> + int ret = 0;
> +
> + ov01a10 = devm_kzalloc(dev, sizeof(*ov01a10), GFP_KERNEL);
> + if (!ov01a10)
> + return -ENOMEM;
> +
> + v4l2_i2c_subdev_init(&ov01a10->sd, client, &ov01a10_subdev_ops);
> +
> + ret = ov01a10_identify_module(ov01a10);
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "failed to find sensor\n");
> +
> + mutex_init(&ov01a10->mutex);
> + ov01a10->cur_mode = &supported_modes[0];
> +
> + ret = ov01a10_init_controls(ov01a10);
> + if (ret) {
> + dev_err(dev, "failed to init controls: %d\n", ret);
> + goto err_mutex_destroy;
> + }
> +
> + ov01a10->sd.internal_ops = &ov01a10_internal_ops;
> + ov01a10->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> + V4L2_SUBDEV_FL_HAS_EVENTS;
> + ov01a10->sd.entity.ops = &ov01a10_subdev_entity_ops;
> + ov01a10->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + ov01a10->pad.flags = MEDIA_PAD_FL_SOURCE;
> +
> + ret = media_entity_pads_init(&ov01a10->sd.entity, 1, &ov01a10->pad);
> + if (ret) {
> + dev_err(dev, "failed to init entity pads: %d\n", ret);
> + goto err_handler_free;
> + }
> +
> + ret = v4l2_async_register_subdev_sensor(&ov01a10->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register subdev: %d\n",
> + ret);
> + goto err_media_entity_cleanup;
> + }
> +
> + pm_runtime_enable(dev);
> + pm_runtime_idle(dev);
> +
> + return 0;
> +
> +err_media_entity_cleanup:
> + media_entity_cleanup(&ov01a10->sd.entity);
> +
> +err_handler_free:
> + v4l2_ctrl_handler_free(ov01a10->sd.ctrl_handler);
> +
> +err_mutex_destroy:
> + mutex_destroy(&ov01a10->mutex);
> +
> + return ret;
> +}
> +
> +static const struct dev_pm_ops ov01a10_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(ov01a10_suspend, ov01a10_resume)
> +};
> +
> +static const struct acpi_device_id ov01a10_acpi_ids[] = {
> + {"OVTI01A0"},
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(acpi, ov01a10_acpi_ids);
> +
> +static struct i2c_driver ov01a10_i2c_driver = {
> + .driver = {
> + .name = "ov01a10",
> + .pm = &ov01a10_pm_ops,
> + .acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
> + },
> + .probe_new = ov01a10_probe,
> + .remove = ov01a10_remove,
> +};
> +
> +module_i2c_driver(ov01a10_i2c_driver);
> +
> +MODULE_AUTHOR("Bingbu Cao <bingbu.cao@intel.com>");
> +MODULE_AUTHOR("Wang Yating <yating.wang@intel.com>");
> +MODULE_DESCRIPTION("OmniVision OV01A10 sensor driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 13:06 ` Sakari Ailus
@ 2023-04-12 11:40 ` Bingbu Cao
2023-04-12 12:19 ` Sakari Ailus
0 siblings, 1 reply; 13+ messages in thread
From: Bingbu Cao @ 2023-04-12 11:40 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao; +Cc: linux-media, Tomi Valkeinen
Sakari,
Thanks for your review.
On 2/9/23 9:06 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> Thanks for the patch.
>
> On Thu, Feb 09, 2023 at 07:22:38PM +0800, Bingbu Cao wrote:
>> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
>> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> Signed-off-by: Yating Wang <yating.wang@intel.com>
>> ---
>> drivers/media/i2c/Kconfig | 13 +
>> drivers/media/i2c/Makefile | 1 +
>> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 920 insertions(+)
>> create mode 100644 drivers/media/i2c/ov01a10.c
>>
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index 833241897d63..8e5d1ef0616f 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -338,6 +338,19 @@ config VIDEO_OG01A1B
>> To compile this driver as a module, choose M here: the
>> module will be called og01a1b.
>>
>> +config VIDEO_OV01A10
>> + tristate "OmniVision OV01A10 sensor support"
>> + depends on VIDEO_DEV && I2C
>> + select MEDIA_CONTROLLER
>> + select VIDEO_V4L2_SUBDEV_API
>> + select V4L2_FWNODE
>> + help
>> + This is a Video4Linux2 sensor driver for the OmniVision
>> + OV01A10 camera.
>> +
>> + To compile this driver as a module, choose M here: the
>> + module will be called ov01a10.
>> +
>> config VIDEO_OV02A10
>> tristate "OmniVision OV02A10 sensor support"
>> depends on VIDEO_DEV && I2C
>> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
>> index 4d6c052bb5a7..ce214503b526 100644
>> --- a/drivers/media/i2c/Makefile
>> +++ b/drivers/media/i2c/Makefile
>> @@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_MT9V032) += mt9v032.o
>> obj-$(CONFIG_VIDEO_MT9V111) += mt9v111.o
>> obj-$(CONFIG_VIDEO_NOON010PC30) += noon010pc30.o
>> obj-$(CONFIG_VIDEO_OG01A1B) += og01a1b.o
>> +obj-$(CONFIG_VIDEO_OV01A10) += ov01a10.o
>> obj-$(CONFIG_VIDEO_OV02A10) += ov02a10.o
>> obj-$(CONFIG_VIDEO_OV08D10) += ov08d10.o
>> obj-$(CONFIG_VIDEO_OV08X40) += ov08x40.o
>> diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
>> new file mode 100644
>> index 000000000000..13de9f9ccdc8
>> --- /dev/null
>> +++ b/drivers/media/i2c/ov01a10.c
>> @@ -0,0 +1,906 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2020-2021 Intel Corporation.
..snip..
>> +static void ov01a10_update_pad_format(const struct ov01a10_mode *mode,
>> + struct v4l2_mbus_framefmt *fmt)
>> +{
>> + fmt->width = mode->width;
>> + fmt->height = mode->height;
>> + fmt->code = MEDIA_BUS_FMT_SBGGR10_1X10;
>> + fmt->field = V4L2_FIELD_NONE;
>> +}
>> +
..snip..
>> +static int ov01a10_set_format(struct v4l2_subdev *sd,
>> + struct v4l2_subdev_state *sd_state,
>> + struct v4l2_subdev_format *fmt)
>> +{
>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>> + const struct ov01a10_mode *mode;
>> + s32 vblank_def, h_blank;
>> +
>> + mode = v4l2_find_nearest_size(supported_modes,
>> + ARRAY_SIZE(supported_modes), width,
>> + height, fmt->format.width,
>> + fmt->format.height);
>> +
>> + mutex_lock(&ov01a10->mutex);
>> + ov01a10_update_pad_format(mode, &fmt->format);
>
> Could you switch to the sub-device state? That is now the preferred way to
> serialise access to e.g. the format.
>
> See e.g.
> <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
>
> The control handler's mutex doubles as a sub-device state mutex.
Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
>
>> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
>> + *v4l2_subdev_get_try_format(sd, sd_state, fmt->pad) = fmt->format;
>> + } else {
>> + ov01a10->cur_mode = mode;
>> + __v4l2_ctrl_s_ctrl(ov01a10->link_freq, mode->link_freq_index);
>> + __v4l2_ctrl_s_ctrl_int64(ov01a10->pixel_rate, OV01A10_SCLK);
>> +
>> + vblank_def = mode->vts_def - mode->height;
>> + __v4l2_ctrl_modify_range(ov01a10->vblank,
>> + mode->vts_min - mode->height,
>> + OV01A10_VTS_MAX - mode->height, 1,
>> + vblank_def);
>> + __v4l2_ctrl_s_ctrl(ov01a10->vblank, vblank_def);
>> + h_blank = mode->hts - mode->width;
>> + __v4l2_ctrl_modify_range(ov01a10->hblank, h_blank, h_blank, 1,
>> + h_blank);
>> + }
>> + mutex_unlock(&ov01a10->mutex);
>> +
>> + return 0;
>> +}
>> +
>> +static int ov01a10_get_format(struct v4l2_subdev *sd,
>> + struct v4l2_subdev_state *sd_state,
>> + struct v4l2_subdev_format *fmt)
>> +{
>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>> +
>> + mutex_lock(&ov01a10->mutex);
>> + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
>> + fmt->format = *v4l2_subdev_get_try_format(&ov01a10->sd,
>> + sd_state, fmt->pad);
>> + else
>> + ov01a10_update_pad_format(ov01a10->cur_mode, &fmt->format);
>> +
>> + mutex_unlock(&ov01a10->mutex);
>> +
>> + return 0;
>> +}
>> +
>> +static int ov01a10_enum_mbus_code(struct v4l2_subdev *sd,
>> + struct v4l2_subdev_state *sd_state,
>> + struct v4l2_subdev_mbus_code_enum *code)
>> +{
>> + if (code->index > 0)
>> + return -EINVAL;
>> +
>> + code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
>> +
>> + return 0;
>> +}
>> +
>> +static int ov01a10_enum_frame_size(struct v4l2_subdev *sd,
>> + struct v4l2_subdev_state *sd_state,
>> + struct v4l2_subdev_frame_size_enum *fse)
>> +{
>> + if (fse->index >= ARRAY_SIZE(supported_modes))
>> + return -EINVAL;
>> +
>> + if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)
>> + return -EINVAL;
>> +
>> + fse->min_width = supported_modes[fse->index].width;
>> + fse->max_width = fse->min_width;
>> + fse->min_height = supported_modes[fse->index].height;
>> + fse->max_height = fse->min_height;
>> +
>> + return 0;
>> +}
>> +
>> +static int ov01a10_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>> +{
>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>> +
>> + mutex_lock(&ov01a10->mutex);
>> + ov01a10_update_pad_format(&supported_modes[0],
>> + v4l2_subdev_get_try_format(sd, fh->state, 0));
>> + mutex_unlock(&ov01a10->mutex);
>> +
>> + return 0;
>> +}
>> +
>> +static const struct v4l2_subdev_core_ops ov01a10_core_ops = {
>> + .log_status = v4l2_ctrl_subdev_log_status,
>> + .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
>> + .unsubscribe_event = v4l2_event_subdev_unsubscribe,
>> +};
>> +
>> +static const struct v4l2_subdev_video_ops ov01a10_video_ops = {
>> + .s_stream = ov01a10_set_stream,
>> +};
>> +
>> +static const struct v4l2_subdev_pad_ops ov01a10_pad_ops = {
>> + .set_fmt = ov01a10_set_format,
>> + .get_fmt = ov01a10_get_format,
>> + .enum_mbus_code = ov01a10_enum_mbus_code,
>> + .enum_frame_size = ov01a10_enum_frame_size,
>> +};
>> +
...
>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-12 11:40 ` Bingbu Cao
@ 2023-04-12 12:19 ` Sakari Ailus
2023-04-19 7:44 ` Bingbu Cao
0 siblings, 1 reply; 13+ messages in thread
From: Sakari Ailus @ 2023-04-12 12:19 UTC (permalink / raw)
To: Bingbu Cao; +Cc: Bingbu Cao, linux-media, Tomi Valkeinen
Hi Bingbu,
On Wed, Apr 12, 2023 at 07:40:19PM +0800, Bingbu Cao wrote:
> >> +static int ov01a10_set_format(struct v4l2_subdev *sd,
> >> + struct v4l2_subdev_state *sd_state,
> >> + struct v4l2_subdev_format *fmt)
> >> +{
> >> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> >> + const struct ov01a10_mode *mode;
> >> + s32 vblank_def, h_blank;
> >> +
> >> + mode = v4l2_find_nearest_size(supported_modes,
> >> + ARRAY_SIZE(supported_modes), width,
> >> + height, fmt->format.width,
> >> + fmt->format.height);
> >> +
> >> + mutex_lock(&ov01a10->mutex);
> >> + ov01a10_update_pad_format(mode, &fmt->format);
> >
> > Could you switch to the sub-device state? That is now the preferred way to
> > serialise access to e.g. the format.
> >
> > See e.g.
> > <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
> >
> > The control handler's mutex doubles as a sub-device state mutex.
>
> Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
Sure, it's fine to use it.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-02-09 12:40 ` Dave Stevenson
2023-02-09 13:15 ` Sakari Ailus
@ 2023-04-13 7:58 ` Bingbu Cao
2023-04-13 8:13 ` Sakari Ailus
1 sibling, 1 reply; 13+ messages in thread
From: Bingbu Cao @ 2023-04-13 7:58 UTC (permalink / raw)
To: Dave Stevenson, Bingbu Cao; +Cc: linux-media, sakari.ailus
Thanks for your review.
On 2/9/23 8:40 PM, Dave Stevenson wrote:
> Hi Bingbu
>
> Thanks for the patch. Just a couple of observations as I read through it.
>
> On Thu, 9 Feb 2023 at 11:39, Bingbu Cao <bingbu.cao@intel.com> wrote:
>>
>> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
>> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> Signed-off-by: Yating Wang <yating.wang@intel.com>
>> ---
>> drivers/media/i2c/Kconfig | 13 +
>> drivers/media/i2c/Makefile | 1 +
>> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 920 insertions(+)
>> create mode 100644 drivers/media/i2c/ov01a10.c
>>
snip
>> +static int ov01a10_init_controls(struct ov01a10 *ov01a10)
>> +{
>> + struct v4l2_ctrl_handler *ctrl_hdlr;
>> + const struct ov01a10_mode *cur_mode;
>> + s64 exposure_max, h_blank;
>> + u32 vblank_min, vblank_max, vblank_default;
>> + int size;
>> + int ret = 0;
>> +
>> + ctrl_hdlr = &ov01a10->ctrl_handler;
>> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
>> + if (ret)
>> + return ret;
>> +
>> + ctrl_hdlr->lock = &ov01a10->mutex;
>> + cur_mode = ov01a10->cur_mode;
>> + size = ARRAY_SIZE(link_freq_menu_items);
>> +
>> + ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
>> + &ov01a10_ctrl_ops,
>> + V4L2_CID_LINK_FREQ,
>> + size - 1, 0,
>> + link_freq_menu_items);
>> + if (ov01a10->link_freq)
>> + ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>> +
>> + ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
>> + V4L2_CID_PIXEL_RATE, 0,
>> + OV01A10_SCLK, 1, OV01A10_SCLK);
>> +
>> + vblank_min = cur_mode->vts_min - cur_mode->height;
>> + vblank_max = OV01A10_VTS_MAX - cur_mode->height;
>> + vblank_default = cur_mode->vts_def - cur_mode->height;
>> + ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
>> + V4L2_CID_VBLANK, vblank_min,
>> + vblank_max, 1, vblank_default);
>> +
>> + h_blank = cur_mode->hts - cur_mode->width;
>> + ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
>> + V4L2_CID_HBLANK, h_blank, h_blank,
>> + 1, h_blank);
>> + if (ov01a10->hblank)
>> + ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>> +
>> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
>> + OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
>> + OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
>> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
>> + OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
>> + OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
>> + exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
>> + ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
>> + V4L2_CID_EXPOSURE,
>> + OV01A10_EXPOSURE_MIN,
>> + exposure_max,
>> + OV01A10_EXPOSURE_STEP,
>> + exposure_max);
>> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
>> + V4L2_CID_TEST_PATTERN,
>> + ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
>> + 0, 0, ov01a10_test_pattern_menu);
>> + if (ctrl_hdlr->error)
>> + return ctrl_hdlr->error;
>
> A call to v4l2_ctrl_new_fwnode_properties to add the standard
> V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION
> properties?
Dave and Sakari,
Is it mandatory for all systems? Cameras don't have such 2 properties on
some systems.
>
>> +
>> + ov01a10->sd.ctrl_handler = ctrl_hdlr;
>> +
>> + return 0;
>> +}
>> +
...
>> --
>> 2.7.4
>>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-13 7:58 ` Bingbu Cao
@ 2023-04-13 8:13 ` Sakari Ailus
0 siblings, 0 replies; 13+ messages in thread
From: Sakari Ailus @ 2023-04-13 8:13 UTC (permalink / raw)
To: Bingbu Cao; +Cc: Dave Stevenson, Bingbu Cao, linux-media
Hi Bingbu,
On Thu, Apr 13, 2023 at 03:58:30PM +0800, Bingbu Cao wrote:
>
> Thanks for your review.
>
> On 2/9/23 8:40 PM, Dave Stevenson wrote:
> > Hi Bingbu
> >
> > Thanks for the patch. Just a couple of observations as I read through it.
> >
> > On Thu, 9 Feb 2023 at 11:39, Bingbu Cao <bingbu.cao@intel.com> wrote:
> >>
> >> Add v4l2 device driver for OmniVision ov01a10 image sensor, ov01a10
> >> image sensor can deliver 1280x800 resolution BGGR10 images at 60 fps.
> >>
> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> >> Signed-off-by: Yating Wang <yating.wang@intel.com>
> >> ---
> >> drivers/media/i2c/Kconfig | 13 +
> >> drivers/media/i2c/Makefile | 1 +
> >> drivers/media/i2c/ov01a10.c | 906 ++++++++++++++++++++++++++++++++++++++++++++
> >> 3 files changed, 920 insertions(+)
> >> create mode 100644 drivers/media/i2c/ov01a10.c
> >>
>
> snip
>
> >> +static int ov01a10_init_controls(struct ov01a10 *ov01a10)
> >> +{
> >> + struct v4l2_ctrl_handler *ctrl_hdlr;
> >> + const struct ov01a10_mode *cur_mode;
> >> + s64 exposure_max, h_blank;
> >> + u32 vblank_min, vblank_max, vblank_default;
> >> + int size;
> >> + int ret = 0;
> >> +
> >> + ctrl_hdlr = &ov01a10->ctrl_handler;
> >> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
> >> + if (ret)
> >> + return ret;
> >> +
> >> + ctrl_hdlr->lock = &ov01a10->mutex;
> >> + cur_mode = ov01a10->cur_mode;
> >> + size = ARRAY_SIZE(link_freq_menu_items);
> >> +
> >> + ov01a10->link_freq = v4l2_ctrl_new_int_menu(ctrl_hdlr,
> >> + &ov01a10_ctrl_ops,
> >> + V4L2_CID_LINK_FREQ,
> >> + size - 1, 0,
> >> + link_freq_menu_items);
> >> + if (ov01a10->link_freq)
> >> + ov01a10->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> >> +
> >> + ov01a10->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> >> + V4L2_CID_PIXEL_RATE, 0,
> >> + OV01A10_SCLK, 1, OV01A10_SCLK);
> >> +
> >> + vblank_min = cur_mode->vts_min - cur_mode->height;
> >> + vblank_max = OV01A10_VTS_MAX - cur_mode->height;
> >> + vblank_default = cur_mode->vts_def - cur_mode->height;
> >> + ov01a10->vblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> >> + V4L2_CID_VBLANK, vblank_min,
> >> + vblank_max, 1, vblank_default);
> >> +
> >> + h_blank = cur_mode->hts - cur_mode->width;
> >> + ov01a10->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> >> + V4L2_CID_HBLANK, h_blank, h_blank,
> >> + 1, h_blank);
> >> + if (ov01a10->hblank)
> >> + ov01a10->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> >> +
> >> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
> >> + OV01A10_ANAL_GAIN_MIN, OV01A10_ANAL_GAIN_MAX,
> >> + OV01A10_ANAL_GAIN_STEP, OV01A10_ANAL_GAIN_MIN);
> >> + v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
> >> + OV01A10_DGTL_GAIN_MIN, OV01A10_DGTL_GAIN_MAX,
> >> + OV01A10_DGTL_GAIN_STEP, OV01A10_DGTL_GAIN_DEFAULT);
> >> + exposure_max = cur_mode->vts_def - OV01A10_EXPOSURE_MAX_MARGIN;
> >> + ov01a10->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov01a10_ctrl_ops,
> >> + V4L2_CID_EXPOSURE,
> >> + OV01A10_EXPOSURE_MIN,
> >> + exposure_max,
> >> + OV01A10_EXPOSURE_STEP,
> >> + exposure_max);
> >> + v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov01a10_ctrl_ops,
> >> + V4L2_CID_TEST_PATTERN,
> >> + ARRAY_SIZE(ov01a10_test_pattern_menu) - 1,
> >> + 0, 0, ov01a10_test_pattern_menu);
> >> + if (ctrl_hdlr->error)
> >> + return ctrl_hdlr->error;
> >
> > A call to v4l2_ctrl_new_fwnode_properties to add the standard
> > V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION
> > properties?
>
> Dave and Sakari,
>
> Is it mandatory for all systems? Cameras don't have such 2 properties on
> some systems.
Please do add them. The values will be just 0 in those cases, and this is
good for the user space to know as well.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-12 12:19 ` Sakari Ailus
@ 2023-04-19 7:44 ` Bingbu Cao
2023-04-19 8:04 ` Sakari Ailus
0 siblings, 1 reply; 13+ messages in thread
From: Bingbu Cao @ 2023-04-19 7:44 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Bingbu Cao, linux-media, Tomi Valkeinen
Sakari,
On 4/12/23 8:19 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> On Wed, Apr 12, 2023 at 07:40:19PM +0800, Bingbu Cao wrote:
>>>> +static int ov01a10_set_format(struct v4l2_subdev *sd,
>>>> + struct v4l2_subdev_state *sd_state,
>>>> + struct v4l2_subdev_format *fmt)
>>>> +{
>>>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>>>> + const struct ov01a10_mode *mode;
>>>> + s32 vblank_def, h_blank;
>>>> +
>>>> + mode = v4l2_find_nearest_size(supported_modes,
>>>> + ARRAY_SIZE(supported_modes), width,
>>>> + height, fmt->format.width,
>>>> + fmt->format.height);
>>>> +
>>>> + mutex_lock(&ov01a10->mutex);
>>>> + ov01a10_update_pad_format(mode, &fmt->format);
>>>
>>> Could you switch to the sub-device state? That is now the preferred way to
>>> serialise access to e.g. the format.
>>>
>>> See e.g.
>>> <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
>>>
>>> The control handler's mutex doubles as a sub-device state mutex.
>>
>> Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
>
> Sure, it's fine to use it.
>
I tried to use the v4l2_subdev_state_get_stream_format() in set_fmt, but I
see that the pad format of camera sensor was missing in media information.
- entity 105: ov01a10 3-0036 (1 pad, 1 link)
type V4L2 subdev subtype Sensor flags 0
device node name /dev/v4l-subdev8
pad0: Source
-> "Intel IPU6 CSI2 2":0 [ENABLED]
And the link validation cannot work as expected, is there something
missing? My kernel head is Linux 6.3-rc2.
static int ov01a10_set_format(struct v4l2_subdev *sd,
struct v4l2_subdev_state *sd_state,
struct v4l2_subdev_format *fmt)
{
...
format = v4l2_subdev_state_get_stream_format(sd_state, fmt->pad,
fmt->stream);
if (!format) {
dev_err(&client->dev, "Failed to get stream format\n");
return -EINVAL;
}
...
ov01a10_update_pad_format(mode, &fmt->format);
*format = fmt->format;
return 0;
}
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-19 7:44 ` Bingbu Cao
@ 2023-04-19 8:04 ` Sakari Ailus
2023-04-19 8:21 ` Tomi Valkeinen
0 siblings, 1 reply; 13+ messages in thread
From: Sakari Ailus @ 2023-04-19 8:04 UTC (permalink / raw)
To: Bingbu Cao; +Cc: Bingbu Cao, linux-media, Tomi Valkeinen
Hi Bingbu,
On Wed, Apr 19, 2023 at 03:44:25PM +0800, Bingbu Cao wrote:
> Sakari,
>
> On 4/12/23 8:19 PM, Sakari Ailus wrote:
> > Hi Bingbu,
> >
> > On Wed, Apr 12, 2023 at 07:40:19PM +0800, Bingbu Cao wrote:
> >>>> +static int ov01a10_set_format(struct v4l2_subdev *sd,
> >>>> + struct v4l2_subdev_state *sd_state,
> >>>> + struct v4l2_subdev_format *fmt)
> >>>> +{
> >>>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
> >>>> + const struct ov01a10_mode *mode;
> >>>> + s32 vblank_def, h_blank;
> >>>> +
> >>>> + mode = v4l2_find_nearest_size(supported_modes,
> >>>> + ARRAY_SIZE(supported_modes), width,
> >>>> + height, fmt->format.width,
> >>>> + fmt->format.height);
> >>>> +
> >>>> + mutex_lock(&ov01a10->mutex);
> >>>> + ov01a10_update_pad_format(mode, &fmt->format);
> >>>
> >>> Could you switch to the sub-device state? That is now the preferred way to
> >>> serialise access to e.g. the format.
> >>>
> >>> See e.g.
> >>> <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
> >>>
> >>> The control handler's mutex doubles as a sub-device state mutex.
> >>
> >> Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
> >
> > Sure, it's fine to use it.
> >
>
> I tried to use the v4l2_subdev_state_get_stream_format() in set_fmt, but I
> see that the pad format of camera sensor was missing in media information.
>
> - entity 105: ov01a10 3-0036 (1 pad, 1 link)
> type V4L2 subdev subtype Sensor flags 0
> device node name /dev/v4l-subdev8
> pad0: Source
> -> "Intel IPU6 CSI2 2":0 [ENABLED]
>
> And the link validation cannot work as expected, is there something
> missing? My kernel head is Linux 6.3-rc2.
>
> static int ov01a10_set_format(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_format *fmt)
> {
> ...
> format = v4l2_subdev_state_get_stream_format(sd_state, fmt->pad,
> fmt->stream);
> if (!format) {
> dev_err(&client->dev, "Failed to get stream format\n");
> return -EINVAL;
> }
>
> ...
> ov01a10_update_pad_format(mode, &fmt->format);
> *format = fmt->format;
>
> return 0;
> }
v4l2_subdev_state_get_stream_format() will access streams and I presume you
won't have any in this case (not even streams support right now as it's a
sensor driver with a single sub-device).
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-19 8:04 ` Sakari Ailus
@ 2023-04-19 8:21 ` Tomi Valkeinen
2023-04-20 2:33 ` Bingbu Cao
0 siblings, 1 reply; 13+ messages in thread
From: Tomi Valkeinen @ 2023-04-19 8:21 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao; +Cc: Bingbu Cao, linux-media
On 19/04/2023 11:04, Sakari Ailus wrote:
> Hi Bingbu,
>
> On Wed, Apr 19, 2023 at 03:44:25PM +0800, Bingbu Cao wrote:
>> Sakari,
>>
>> On 4/12/23 8:19 PM, Sakari Ailus wrote:
>>> Hi Bingbu,
>>>
>>> On Wed, Apr 12, 2023 at 07:40:19PM +0800, Bingbu Cao wrote:
>>>>>> +static int ov01a10_set_format(struct v4l2_subdev *sd,
>>>>>> + struct v4l2_subdev_state *sd_state,
>>>>>> + struct v4l2_subdev_format *fmt)
>>>>>> +{
>>>>>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>>>>>> + const struct ov01a10_mode *mode;
>>>>>> + s32 vblank_def, h_blank;
>>>>>> +
>>>>>> + mode = v4l2_find_nearest_size(supported_modes,
>>>>>> + ARRAY_SIZE(supported_modes), width,
>>>>>> + height, fmt->format.width,
>>>>>> + fmt->format.height);
>>>>>> +
>>>>>> + mutex_lock(&ov01a10->mutex);
>>>>>> + ov01a10_update_pad_format(mode, &fmt->format);
>>>>>
>>>>> Could you switch to the sub-device state? That is now the preferred way to
>>>>> serialise access to e.g. the format.
>>>>>
>>>>> See e.g.
>>>>> <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
>>>>>
>>>>> The control handler's mutex doubles as a sub-device state mutex.
>>>>
>>>> Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
>>>
>>> Sure, it's fine to use it.
>>>
>>
>> I tried to use the v4l2_subdev_state_get_stream_format() in set_fmt, but I
>> see that the pad format of camera sensor was missing in media information.
>>
>> - entity 105: ov01a10 3-0036 (1 pad, 1 link)
>> type V4L2 subdev subtype Sensor flags 0
>> device node name /dev/v4l-subdev8
>> pad0: Source
>> -> "Intel IPU6 CSI2 2":0 [ENABLED]
>>
>> And the link validation cannot work as expected, is there something
>> missing? My kernel head is Linux 6.3-rc2.
>>
>> static int ov01a10_set_format(struct v4l2_subdev *sd,
>> struct v4l2_subdev_state *sd_state,
>> struct v4l2_subdev_format *fmt)
>> {
>> ...
>> format = v4l2_subdev_state_get_stream_format(sd_state, fmt->pad,
>> fmt->stream);
>> if (!format) {
>> dev_err(&client->dev, "Failed to get stream format\n");
>> return -EINVAL;
>> }
>>
>> ...
>> ov01a10_update_pad_format(mode, &fmt->format);
>> *format = fmt->format;
>>
>> return 0;
>> }
>
> v4l2_subdev_state_get_stream_format() will access streams and I presume you
> won't have any in this case (not even streams support right now as it's a
> sensor driver with a single sub-device).
>
This perhaps gives a better example on how to migrate to subdev state:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/media/i2c/imx290.c?id=a2514b9a634ac0a2cfbc329822b8fb58ffe23a80
Tomi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] media: i2c: add ov01a10 image sensor driver
2023-04-19 8:21 ` Tomi Valkeinen
@ 2023-04-20 2:33 ` Bingbu Cao
0 siblings, 0 replies; 13+ messages in thread
From: Bingbu Cao @ 2023-04-20 2:33 UTC (permalink / raw)
To: Tomi Valkeinen, Sakari Ailus; +Cc: Bingbu Cao, linux-media
Tomi and Sakari,
On 4/19/23 4:21 PM, Tomi Valkeinen wrote:
> On 19/04/2023 11:04, Sakari Ailus wrote:
>> Hi Bingbu,
>>
>> On Wed, Apr 19, 2023 at 03:44:25PM +0800, Bingbu Cao wrote:
>>> Sakari,
>>>
>>> On 4/12/23 8:19 PM, Sakari Ailus wrote:
>>>> Hi Bingbu,
>>>>
>>>> On Wed, Apr 12, 2023 at 07:40:19PM +0800, Bingbu Cao wrote:
>>>>>>> +static int ov01a10_set_format(struct v4l2_subdev *sd,
>>>>>>> + struct v4l2_subdev_state *sd_state,
>>>>>>> + struct v4l2_subdev_format *fmt)
>>>>>>> +{
>>>>>>> + struct ov01a10 *ov01a10 = to_ov01a10(sd);
>>>>>>> + const struct ov01a10_mode *mode;
>>>>>>> + s32 vblank_def, h_blank;
>>>>>>> +
>>>>>>> + mode = v4l2_find_nearest_size(supported_modes,
>>>>>>> + ARRAY_SIZE(supported_modes), width,
>>>>>>> + height, fmt->format.width,
>>>>>>> + fmt->format.height);
>>>>>>> +
>>>>>>> + mutex_lock(&ov01a10->mutex);
>>>>>>> + ov01a10_update_pad_format(mode, &fmt->format);
>>>>>>
>>>>>> Could you switch to the sub-device state? That is now the preferred way to
>>>>>> serialise access to e.g. the format.
>>>>>>
>>>>>> See e.g.
>>>>>> <URL:https://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git/tree/drivers/media/i2c/ov1063x.c?h=streams/work-v16>.
>>>>>>
>>>>>> The control handler's mutex doubles as a sub-device state mutex.
>>>>>
>>>>> Is it fine to use v4l2_subdev_get_fmt()? Or will it be deprecated soon?
>>>>
>>>> Sure, it's fine to use it.
>>>>
>>>
>>> I tried to use the v4l2_subdev_state_get_stream_format() in set_fmt, but I
>>> see that the pad format of camera sensor was missing in media information.
>>>
>>> - entity 105: ov01a10 3-0036 (1 pad, 1 link)
>>> type V4L2 subdev subtype Sensor flags 0
>>> device node name /dev/v4l-subdev8
>>> pad0: Source
>>> -> "Intel IPU6 CSI2 2":0 [ENABLED]
>>>
>>> And the link validation cannot work as expected, is there something
>>> missing? My kernel head is Linux 6.3-rc2.
>>>
>>> static int ov01a10_set_format(struct v4l2_subdev *sd,
>>> struct v4l2_subdev_state *sd_state,
>>> struct v4l2_subdev_format *fmt)
>>> {
>>> ...
>>> format = v4l2_subdev_state_get_stream_format(sd_state, fmt->pad,
>>> fmt->stream);
>>> if (!format) {
>>> dev_err(&client->dev, "Failed to get stream format\n");
>>> return -EINVAL;
>>> }
>>>
>>> ...
>>> ov01a10_update_pad_format(mode, &fmt->format);
>>> *format = fmt->format;
>>>
>>> return 0;
>>> }
>>
>> v4l2_subdev_state_get_stream_format() will access streams and I presume you
>> won't have any in this case (not even streams support right now as it's a
>> sensor driver with a single sub-device).
>>
>
> This perhaps gives a better example on how to migrate to subdev state:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/media/i2c/imx290.c?id=a2514b9a634ac0a2cfbc329822b8fb58ffe23a80
Got it, thank you!
>
> Tomi
>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-04-20 2:34 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 11:22 [PATCH] media: i2c: add ov01a10 image sensor driver Bingbu Cao
2023-02-09 12:40 ` Dave Stevenson
2023-02-09 13:15 ` Sakari Ailus
2023-04-13 7:58 ` Bingbu Cao
2023-04-13 8:13 ` Sakari Ailus
2023-02-09 13:06 ` Sakari Ailus
2023-04-12 11:40 ` Bingbu Cao
2023-04-12 12:19 ` Sakari Ailus
2023-04-19 7:44 ` Bingbu Cao
2023-04-19 8:04 ` Sakari Ailus
2023-04-19 8:21 ` Tomi Valkeinen
2023-04-20 2:33 ` Bingbu Cao
2023-02-09 14:41 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).