Re: [PATCH 19/20] arm64: dts: fsd: Add MFC related DT enteries

Krzysztof Kozlowski
2022-05-17T14:02:37Z

On 17/05/2022 14:55, Smitha T Murthy wrote:
> Add MFC DT node and reserve memory node for MFC usage.
>
> Cc: linux-fsd@tesla.com
> Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
> ---
> arch/arm64/boot/dts/tesla/fsd-evb.dts | 8 ++++++++
> arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 5af560c1b5e6..36f6b013ce99 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -37,3 +37,11 @@
> &serial_0 {
> status = "okay";
> };
> +
> +&clock_mfc {
> + status = "okay";
> +};
> +
> +&mfc_0 {
> + status = "okay";
> +};

Labels are ordered by name.

> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index 9a652abcbcac..434ae75421d8 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -249,6 +249,18 @@
> #clock-cells = <0>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + mfc_left: region@84000000 {
> + compatible = "shared-dma-pool";
> + no-map;
> + reg = <0 0x84000000 0 0x8000000>;
> + };
> + };
> +
> soc: soc@0 {
> compatible = "simple-bus";
> #address-cells = <2>;
> @@ -748,6 +760,16 @@
> clocks = <&fin_pll>, <&clock_imem IMEM_MCT_PCLK>;
> clock-names = "fin_pll", "mct";
> };
> +
> + mfc_0: mfc0@12880000 {

Generic node names, so mfc.

> + compatible = "samsung,mfc-v12";
> + reg = <0x0 0x12880000 0x0 0x10000>;
> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "mfc";
> + clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>;
> + memory-region = <&mfc_left>;
> + status = "disabled";

Why exactly this is disabled? Usually we disable nodes which needs
resources from the boards, but this is not the case here. Unless it is?

> + };
> };
> };
>

Best regards,
Krzysztof