Re: [PATCH v7 09/10] [media] st-delta: add mjpeg support

[Hugues FRUCHET <hugues.fruchet@st.com>]

On 02/08/2017 01:19 PM, Mauro Carvalho Chehab wrote:
> Em Thu, 2 Feb 2017 15:59:52 +0100
> Hugues Fruchet <hugues.fruchet@st.com> escreveu:
>
> I applied today this series. There's just a nitpick, that you can change
> when you submit a version 2 of the MPEG2 driver. See below:
>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index 2e82ec6..20b26ea 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -317,10 +317,20 @@ config VIDEO_STI_DELTA
>>
>>  if VIDEO_STI_DELTA
>>
>> +config VIDEO_STI_DELTA_MJPEG
>> +	bool "STMicroelectronics DELTA MJPEG support"
>> +	default y
>> +	help
>> +		Enables DELTA MJPEG hardware support.
>> +
>> +		To compile this driver as a module, choose M here:
>> +		the module will be called st-delta.
>> +
>>  config VIDEO_STI_DELTA_DRIVER
>>  	tristate
>>  	depends on VIDEO_STI_DELTA
>> -	default n
>> +	depends on VIDEO_STI_DELTA_MJPEG
>> +	default VIDEO_STI_DELTA_MJPEG
>
> Just do:
> 	default y
>
> The build system will do the right thing, as it will evaluate
> the dependencies, disabling it if no decoder is selected. That
> will avoid needing to change the default line for every new decoder
> you add.
>

Thanks Mauro,

this is done in v2 of MPEG-2 patchset.

Best regards,
Hugues.

>>  	select VIDEOBUF2_DMA_CONTIG
>>  	select V4L2_MEM2MEM_DEV
>>  	select RPMSG
>
>
> Thanks,
> Mauro
>