From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: tian.shu.qiu@intel.com, antti.laakso@linux.intel.com,
mehdi.djait@linux.intel.com
Subject: Re: [PATCH v4 10/14] media: ipu6: Obtain remote pad using media_pad_remote_pad_unique()
Date: Thu, 8 Jan 2026 16:20:14 +0800 [thread overview]
Message-ID: <0232e2d7-c2b9-3f0f-238f-db73686bf7e6@linux.intel.com> (raw)
In-Reply-To: <20260108081712.543704-11-sakari.ailus@linux.intel.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
On 1/8/26 4:17 PM, Sakari Ailus wrote:
> There's no reason to use media_entity_remote_source_pad_unique() as we
> know our pads. Use media_pad_remote_pad_unique() instead.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c b/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> index 43a2a16a3c2a..7e539a0c6c92 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> @@ -88,7 +88,7 @@ s64 ipu6_isys_csi2_get_link_freq(struct ipu6_isys_csi2 *csi2)
> if (!csi2)
> return -EINVAL;
>
> - src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity);
> + src_pad = media_pad_remote_pad_unique(&csi2->asd.sd.entity.pads[CSI2_PAD_SINK]);
> if (IS_ERR(src_pad)) {
> dev_err(&csi2->isys->adev->auxdev.dev,
> "can't get source pad of %s (%pe)\n",
>
--
Best regards,
Bingbu Cao
next prev parent reply other threads:[~2026-01-08 8:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:16 [PATCH v4 00/14] IPU6 driver cleanups and fixes Sakari Ailus
2026-01-08 8:16 ` [PATCH v4 01/14] media: ipu6: Ensure stream_mutex is acquired when dealing with node list Sakari Ailus
2026-01-08 8:16 ` [PATCH v4 02/14] media: ipu6: Drop MMU hardware initialisation in probe() Sakari Ailus
2026-01-08 8:16 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 03/14] media: ipu6: Remove redundant driver data checks Sakari Ailus
2026-01-08 8:17 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 04/14] media: ipu6: Make symbols static Sakari Ailus
2026-01-08 8:17 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 05/14] media: ipu6: Remove redundant streaming start via buffer queueing Sakari Ailus
2026-01-08 8:17 ` [PATCH v4 06/14] media: ipu6: Don't check pipeline in stream_start Sakari Ailus
2026-01-08 8:17 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 07/14] media: ipu6: Close firmware streams on streaming enable failure Sakari Ailus
2026-01-08 8:18 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 08/14] media: ipu6: Always close firmware stream Sakari Ailus
2026-01-08 8:19 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 09/14] media: ipu6: Drop error argument from ipu6_isys_stream_start() Sakari Ailus
2026-01-08 8:19 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 10/14] media: ipu6: Obtain remote pad using media_pad_remote_pad_unique() Sakari Ailus
2026-01-08 8:20 ` Bingbu Cao [this message]
2026-01-08 8:17 ` [PATCH v4 11/14] media: ipu6: Obtain unique source pad from remote sub-device Sakari Ailus
2026-01-08 8:20 ` Bingbu Cao
2026-01-08 12:28 ` Mehdi Djait
2026-01-08 12:36 ` Sakari Ailus
2026-01-08 8:17 ` [PATCH v4 12/14] media: ipu6: Remove source_entity from struct ipu6_isys_stream Sakari Ailus
2026-01-08 8:17 ` [PATCH v4 13/14] media: ipu6: Drop custom functions to obtain sd state information Sakari Ailus
2026-01-08 8:22 ` Bingbu Cao
2026-01-08 8:17 ` [PATCH v4 14/14] media: ipu6: Always call video_device_pipeline_alloc_start() Sakari Ailus
2026-01-08 12:44 ` [PATCH v4 00/14] IPU6 driver cleanups and fixes Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0232e2d7-c2b9-3f0f-238f-db73686bf7e6@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox