RE: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT schema for MFC

Aakarsh Jain
2022-10-18T11:01:46Z

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 12 October 2022 18:50
> To: aakarsh jain <aakarsh.jain@samsung.com>
> Cc: linux-fsd@tesla.com; linux-media@vger.kernel.org;
> pankaj.dubey@samsung.com; linux-arm-kernel@lists.infradead.org;
> dillon.minfei@gmail.com; devicetree@vger.kernel.org; krzk+dt@kernel.org;
> smitha.t@samsung.com; benjamin.gaignard@collabora.com;
> stanimir.varbanov@linaro.org; jernej.skrabec@gmail.com;
> robh+dt@kernel.org; aswani.reddy@samsung.com; mchehab@kernel.org;
> hverkuil-cisco@xs4all.nl; mark.rutland@arm.com;
> m.szyprowski@samsung.com; linux-kernel@vger.kernel.org;
> alim.akhtar@samsung.com; andi@etezian.org; andrzej.hajda@intel.com;
> ezequiel@vanguardiasur.com.ar; david.plowman@raspberrypi.com
> Subject: Re: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT
> schema for MFC
>
> On Tue, 11 Oct 2022 17:55:02 +0530, aakarsh jain wrote:
> > From: Smitha T Murthy <smitha.t@samsung.com>
> >
> > Convert DT schema for s5p-mfc in yaml format
> >
> > Cc: linux-fsd@tesla.com
> > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
> > Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> > ---
> > .../devicetree/bindings/media/s5p-mfc.txt | 75 --------
> > .../bindings/media/samsung,s5p-mfc.yaml | 163
> ++++++++++++++++++
> > 2 files changed, 163 insertions(+), 75 deletions(-) create mode
> > 100644 Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
following
> warnings. Consider if they are expected or the schema is incorrect. These
> may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here:
https://protect2.fireeye.com/v1/url?k=b651482e-
> e9ca7131-b650c361-000babdfecba-bb28230f82534754&q=1&e=25a7ee78-
> 697f-4371-880e-
> dcf4e3072c99&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F
>
>
> codec@13400000: clock-names: ['mfc', 'sclk_mfc'] is too long
> arch/arm/boot/dts/exynos3250-artik5-eval.dtb
> arch/arm/boot/dts/exynos3250-monk.dtb
> arch/arm/boot/dts/exynos3250-rinato.dtb
>
> codec@13400000: clocks: [[7, 178], [7, 228]] is too long
> arch/arm/boot/dts/exynos3250-artik5-eval.dtb
> arch/arm/boot/dts/exynos3250-monk.dtb
> arch/arm/boot/dts/exynos3250-rinato.dtb
>
> codec@13400000: iommus: [[36]] is too short
> arch/arm/boot/dts/exynos3250-monk.dtb
> arch/arm/boot/dts/exynos3250-monk.dtb
>
> codec@13400000: iommus: [[40]] is too short
> arch/arm/boot/dts/exynos3250-artik5-eval.dtb
> arch/arm/boot/dts/exynos3250-artik5-eval.dtb
>
> codec@13400000: iommus: [[47]] is too short
> arch/arm/boot/dts/exynos3250-rinato.dtb
> arch/arm/boot/dts/exynos3250-rinato.dtb
>
> codec@13400000: memory-region: [[31], [32]] is too long
> arch/arm/boot/dts/exynos4210-smdkv310.dtb
>
> codec@13400000: memory-region: [[37], [38]] is too long
> arch/arm/boot/dts/exynos4210-origen.dtb
>
> codec@13400000: memory-region: [[41], [42]] is too long
> arch/arm/boot/dts/exynos4412-smdk4412.dtb
>
> codec@13400000: memory-region: [[43], [44]] is too long
> arch/arm/boot/dts/exynos4412-origen.dtb
>
> codec@13400000: memory-region: [[47], [48]] is too long
> arch/arm/boot/dts/exynos4412-itop-elite.dtb
> arch/arm/boot/dts/exynos4412-odroidx2.dtb
> arch/arm/boot/dts/exynos4412-odroidx.dtb
>
> codec@13400000: memory-region: [[48], [49]] is too long
> arch/arm/boot/dts/exynos4412-odroidu3.dtb
>
> codec@f1700000: clock-names:0: 'mfc' was expected
> arch/arm/boot/dts/s5pv210-aquila.dtb
> arch/arm/boot/dts/s5pv210-fascinate4g.dtb
> arch/arm/boot/dts/s5pv210-galaxys.dtb
> arch/arm/boot/dts/s5pv210-goni.dtb
> arch/arm/boot/dts/s5pv210-smdkc110.dtb
> arch/arm/boot/dts/s5pv210-smdkv210.dtb
> arch/arm/boot/dts/s5pv210-torbreck.dtb
>
> codec@f1700000: clock-names:1: 'sclk_mfc' was expected
> arch/arm/boot/dts/s5pv210-aquila.dtb
> arch/arm/boot/dts/s5pv210-fascinate4g.dtb
> arch/arm/boot/dts/s5pv210-galaxys.dtb
> arch/arm/boot/dts/s5pv210-goni.dtb
> arch/arm/boot/dts/s5pv210-smdkc110.dtb
> arch/arm/boot/dts/s5pv210-smdkv210.dtb
> arch/arm/boot/dts/s5pv210-torbreck.dtb
>
> codec@f1700000: memory-region: [[51], [52]] is too long
> arch/arm/boot/dts/s5pv210-fascinate4g.dtb
>
> codec@f1700000: memory-region: [[55], [56]] is too long
> arch/arm/boot/dts/s5pv210-galaxys.dtb

Hi Rob,

We tried reproducing warnings as reported above, but I am not able to see
these warnings after running make dtbs_check & make DT_CHECKER_FLAGS=-m
dt_binding_check.
Packages used-
yamllint 1.10.0
$ dt-mk-schema --version
2022.9

Am I missing anything? Do let me know.

Thanks,
Aakarsh