Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver

Sowjanya Komatineni
2020-04-26T01:08:49Z

On 4/25/20 5:41 PM, Sowjanya Komatineni wrote:
>
> On 4/25/20 5:36 PM, Dmitry Osipenko wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> 25.04.2020 12:36, Hans Verkuil пишет:
>> ...
>>>> The media/tegra/ sounds a bit too generic, the media/tegra-vi/ path
>>>> should better reflect the driver, IMO.
>>>>
>>>> It also should be better to name the compiled kernel module as
>>>> tegra-vi,
>>>> IMO.
>>>>
>>> The driver name and the directory should be in sync, so either
>>> tegra-video
>>> or tegra-vi for both. I have no preference myself, as long as they
>>> are the
>>> same.
>>>
>>> This can be done as a follow-up patch.
>> Given that this driver isn't going to be reused by older pre-Tegra210
>> SoCs, perhaps it will also be worthwhile to name it as tegra210-vi or
>> tegra210-video.
>
> Can you explain what do you meant by can't be reused for pre-tegra210
> or for tegra186/194?
>
> support for other tegra's can be added to same tegra-video driver.
> tegra-video host1x driver can be updated to add other tegra's vi and
> csi compatibles to host1x subdevs and vi and csi driver can be updated
> to add other tegra soc data and need to add coresponding
> tegra186/194/xxx.c file with tegra specific prog sequence
>
Same tegra-video.ko can be used for all tegra soc as driver supports
adding other soc related as well.

Also was thinking instead of renaming media/tegra as media/tegra-vi,
probably we can rename as media/tegra-video so it will be inline with
module name we already chosen and also mainly we have vi and csi with in
that so instead of tegra-vi probably we can use media/tegra-video?