From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C69E3BFE3E for ; Thu, 8 Oct 2026 06:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791439823; cv=none; b=qGnp40EmP3RgOpzTWiWss8bXf5dxBNUQbQkxldL+ee76I12xCVd3UC++NtEwGeSCwk2T1KSyRRKS18eRjSJc0cvjvKyEI+mdgy7xQ+4xuDjcgFUHlCDf13MmxTxZaA8rxWFgNi+Mr4Qcw4PXAQZspHW6JrrMFUmpUuwYB4BuinQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791439823; c=relaxed/simple; bh=wNxN2LCMggRd7CtA2517GaI9Bsm/oZeFDoCQ3qU/flk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h1R61LAFsHQdeg+dGEHMxpt7GOPtDg7tStLB2JdNNSXFjJAqnpjqUwBXi0qnXFxvhBBlcu62F/RfrG/MyMPzAuOaCnAivDKx0h1+ErgKbQ/sWZ4SUk2lKalSJqjW+fUg+8DvrqlNLw4t9RlCTCJq6IKcyOm04YQW0lYqSgAq2dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SFki8Ecj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kge/4DMx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SFki8Ecj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kge/4DMx" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6984BUN41775343 for ; Thu, 8 Oct 2026 06:10:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E7NbTCcDpDJabqAVoHlppEnBCQ8nO+uP1Rh4RdDIQfw=; b=SFki8EcjVh/hhnd+ hw8bOPLPve/wMYu5Pt5d6YEqlWe8W48EV/ZQWOJGOfUH63ayf31w0+k/L21HI5jV M31wBYEWWj6jiNTuSS0cpXKCdo+6GFOBdLVvYBrxj8DxBrkKmV0Yuh/rpHueK/KM XCb/EFmOeEJbyxhEI72XHSdVdQ0bX7qwMYS4im4xGPbg+914JQvurSasgtIOHy2G zB3SnqRE4uYkhDEN0X79Hf4W3ONUHN4uevChk1ESE8hw4V7rUW59G/AoWJHpLPEb g7E/PUwCx4WmznWl4vOV/kHqAdWcZ3uNIC78n7Tf3hbCBsI+ctRv9DA+iaSOf4Ia yXWrZQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h5xe39bff-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Oct 2026 06:10:18 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93cc40759b2so1012246985a.1 for ; Wed, 07 Oct 2026 23:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791439817; x=1792044617; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E7NbTCcDpDJabqAVoHlppEnBCQ8nO+uP1Rh4RdDIQfw=; b=kge/4DMx0Rjp9MYw8VZzdYuCNyFI+7kE/yOxEtLCRULZqfbdhOHpXnAFIYMaj+rM6P FNRk5b4aEfuGNNRDdbF0BuoLJAFehiGg/6oCdsMsuuU7I2GZpELU6Ee4oUQBPbDc3B+/ cx9urhG6Fg1GjjBcSg+O1Xw8P/Qhq+o5amEN5Et1dBop4to7f3X/pUZqF4BVB8rp1R5W i9lp2RZM5PqslvMMt+UJx2dEyIYkQL6YHnWOaKICX5ge/F1+jW0O5NCnxRKRT5Jr8Qm3 0DedbRemFeDvp1w6ut6WFa/YA9BBvh8hqYZbU/ErkPZ454nS0hJ5zjuvzaSJ8liaL9QG +gCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791439817; x=1792044617; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E7NbTCcDpDJabqAVoHlppEnBCQ8nO+uP1Rh4RdDIQfw=; b=kr0X/kwYHQ0T/IyoLXf5FNP3iOlotL12//6WScPAauPXVmj7sgYpgXVqxAXzNSwBDm i5V3wll9vFXAS5cU4GRRc2dF0zanO/7qsQH+38ztQaRtR4HybNqBQIwjhij4ar7kckmx AWgYCQrrO60lnfS6SXfBTUBZMpu/JLkoFMu71t3kQ223uzaQ/hhJWMf7d7so7oLesL82 I6pqemcOzH5yu8fnrGlN6w8IkCeG/4Ydz2Ee+y8XDgGyBnd8g6RIo9Z9z+Kvef5B84LZ p/iR/v6+mM9nYigBtg/nylgpR3ESVAM9Yso0X1RpvkAwU1v0/VKSPAVP+z1wnW5xf8IW cjGg== X-Gm-Message-State: AFuF++lyjXYVarnHpFjd7xNb2qE2dIsBdcAzZb7WtBzjc+G8BYUXCo0d zmIghKdRJJ85m4sV2kvKk4n3EG/77LfeFQzNeu5C46JjmoL2W877qPUuM1Z0q3eoeUsQA6CLECF PzKegs5csDXkIC5d5/DWdMVO8KiU06UqRGJ/wO+UoK5ZCPTA39nECvcAsNau/Ev8g9g== X-Gm-Gg: AYBFou1yhZVWeErGXXe+LogSNGnXnsADCIzj0jXRDRZX4feBWnBVrdaeB91353UCQrk CpYzXJUQr2sSATp8a+shG2b6OCkD6YYfxayS2v9HtEHsoTUdCaaNg/9GJwaeBhgoIydyIn7JzjK xcqfwD6EYmHJHszgR6VH/5ySlV5iqU1TeG1ZpTd1bK+rbwYPT+RQxkteiRMkMBJllPtINfu2/NE gWX8zIvkNsHvRzQ9vG0bF+xH/3kgD5n7SpOU5wL+HrkUPl+ppGoJ6EAeq9HiPGPVTzrs1OSypvW I9SdbCRr4M0txAJA8C3P6G04btKbY73dC+EePLt6NFpnhDqT/V8GepgweuJ+43xiKzXw3pLkEFm RdTRXb6Hjp/ikqWWPqRmtCSPPSltm/jR6yMrmqdQ= X-Received: by 2002:a05:620a:4555:b0:93e:6c77:6fc7 with SMTP id af79cd13be357-93e9b7add20mr856254685a.42.1791439817503; Wed, 07 Oct 2026 23:10:17 -0700 (PDT) X-Received: by 2002:a05:620a:4555:b0:93e:6c77:6fc7 with SMTP id af79cd13be357-93e9b7add20mr856249685a.42.1791439816988; Wed, 07 Oct 2026 23:10:16 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48c7256434bsm9196324f8f.15.2026.10.07.23.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2026 23:10:16 -0700 (PDT) Message-ID: <035ae11f-0c69-415f-af9a-c7c903df3f14@oss.qualcomm.com> Date: Thu, 8 Oct 2026 09:10:13 +0300 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 31/74] media: qcom: camss: vfe: Add support for updating multiple write-masters within an output group To: Bryan O'Donoghue , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Jacopo Mondi , Daniel Scally , Keke Li , Richard Acayan , Hans Verkuil , Gjorgji Rosikopulos , Radoslav Tsvetkov , Robert Foss , Milen Mitkov Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-0-ed985aefd611@kernel.org> <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-31-ed985aefd611@kernel.org> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: <20261005-linux-mainline-7-2-sm8650-hdk-rfc-0-v1-31-ed985aefd611@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=J4s/fwnS c=1 sm=1 tr=0 ts=6ac733ca cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=7O-2GFc335GU3a1fVM4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA4MDAyNCBTYWx0ZWRfX3EB8vWdKdz8g oB1PxegY7taZn5LGpDey36aAqFy/a9CJdw3EPefEIjBCprBw8MSo+CVHd1rhVu51nkeCXWA6CaH hViEl6e6Qih2Dev7aqWEQO6mASNMRVE= X-Proofpoint-GUID: Uzp5zOLzfUFwvUHJ-jlOlRtyYr2I909j X-Proofpoint-ORIG-GUID: Uzp5zOLzfUFwvUHJ-jlOlRtyYr2I909j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA4MDAyNCBTYWx0ZWRfX7U4uJAAikuNg /3L0HS0dZySLnmTad/P5cg/bWyG2rO8N0NAwBLv05ycWl1vPbb0/DGOzTD7MegTWl5LW9uVRcGW frU0rBbZj3xLCLXyBAyWxI1yu92q6pzv5O6xOUL1Y78DATq+w15afGUKFAcI9407Po6rWRuqlfO QbPD5k+UHYuTCu84Sw4IGTMfTYt1Ne2sMTU2hiM5IeDzO5DtYoXtHFoX3yiifuq71Mn0utQIcVW 81EY9iCwWI0JVM5beLoEyRyMShrTAz6QWbI7qqznt/TeaZ3QNaQyfCZhmc97eCUBXuXNB7nUnUc 62cmPaqaOwD5RuTwK9mHSKVRZ3qbOnzML5vjTlET2zflN+3VCDMAxSZ4Q1VFbw5XeUSs4c+ueqj VbtGhnM/nDa6USmoapeJ5DRbX/PNjLas3scv5GLJ8p7pD+HU5TryWkF/CGuhKnETB4kd3tT3Rcu bK8cQZb17C8wMGnAetw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-08_02,2026-10-06_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610080024 I think that all the changes for new API should come in one patch not sure why are you spiting them, they will create room of bisect errors. ~Gjorgji On 10/5/2026 8:14 PM, Bryan O'Donoghue wrote: > Signed-off-by: Bryan O'Donoghue > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index c078af53b0758..20d8b3e1e4459 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -673,8 +673,11 @@ static int vfe_enable_one_output(struct vfe_line *line, struct vfe_output *outpu > if (!output->buf[i]) > break; > output->gen2.active_num++; > - ops->vfe_wm_update(vfe, output->wm[0].bus_client, > - output->buf[i]->addr[0], line); > + if (ops->vfe_output_update) > + ops->vfe_output_update(vfe, output, output->buf[i]); > + else > + ops->vfe_wm_update(vfe, output->wm[0].bus_client, > + output->buf[i]->addr[0], line); > ops->reg_update(vfe, line->id); > } > > @@ -741,8 +744,11 @@ int vfe_queue_buffer_v2(struct camss_video *vid, > if (output->state == VFE_OUTPUT_ON && > output->gen2.active_num < 2) { > output->buf[output->gen2.active_num++] = buf; > - ops->vfe_wm_update(vfe, output->wm[0].bus_client, > - buf->addr[0], line); > + if (ops->vfe_output_update) > + ops->vfe_output_update(vfe, output, buf); > + else > + ops->vfe_wm_update(vfe, output->wm[0].bus_client, > + buf->addr[0], line); > ops->reg_update(vfe, line->id); > } else { > vfe_buf_add_pending(output, buf); >