From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: moudy ho <moudy.ho@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Landley <rob@landley.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@chromium.org>,
tfiga@chromium.org, drinkcat@chromium.org, pihsun@chromium.org,
hsinyi@google.com, Maoguang Meng <maoguang.meng@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
menghui.lin@mediatek.com, sj.huang@mediatek.com,
allen-kh.cheng@mediatek.com, randy.wu@mediatek.com,
jason-jh.lin@mediatek.com, roy-cw.yeh@mediatek.com,
river.cheng@mediatek.com, srv_heupstream@mediatek.com
Subject: Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver
Date: Thu, 2 Dec 2021 13:07:42 +0100 [thread overview]
Message-ID: <038d4a24-7d61-ebb2-796f-63b59001ee54@collabora.com> (raw)
In-Reply-To: <0d3f33e26b67cabc82246c49c0e952194a9a88c1.camel@mediatek.com>
Il 02/12/21 04:35, moudy ho ha scritto:
> On Wed, 2021-12-01 at 11:37 +0100, AngeloGioacchino Del Regno wrote:
>> Il 01/12/21 10:50, Moudy Ho ha scritto:
>>> This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3).
>>> It provides the following functions:
>>> color transform, format conversion, resize, crop, rotate, flip
>>> and additional image quality enhancement.
>>>
>>> The MDP3 driver is mainly used for Google Chromebook products to
>>> import the new architecture to set the HW settings as shown below:
>>> User -> V4L2 framework
>>> -> MDP3 driver -> SCP (setting calculations)
>>> -> MDP3 driver -> CMDQ (GCE driver) -> HW
>>>
>>> Each modules' related operation control is sited in mtk-mdp3-comp.c
>>> Each modules' register table is defined in file with "mdp_reg_"
>>> prefix
>>> GCE related API, operation control sited in mtk-mdp3-cmdq.c
>>> V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c
>>> Probe, power, suspend/resume, system level functions are defined in
>>> mtk-mdp3-core.c
>>>
>>> Signed-off-by: Ping-Hsun Wu <ping-hsun.wu@mediatek.com>
>>> Signed-off-by: daoyuan huang <daoyuan.huang@mediatek.com>
>>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> ---
>>> drivers/media/platform/Kconfig | 19 +
>>> drivers/media/platform/Makefile | 2 +
>>> drivers/media/platform/mtk-mdp3/Makefile | 6 +
>>> .../media/platform/mtk-mdp3/mdp_reg_ccorr.h | 19 +
>>> drivers/media/platform/mtk-mdp3/mdp_reg_isp.h | 27 +
>>> .../media/platform/mtk-mdp3/mdp_reg_rdma.h | 65 +
>>> drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h | 39 +
>>> .../media/platform/mtk-mdp3/mdp_reg_wdma.h | 47 +
>>> .../media/platform/mtk-mdp3/mdp_reg_wrot.h | 55 +
>>> drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 280 ++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 514 +++++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.h | 46 +
>>> .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 1264
>>> +++++++++++++++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 147 ++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 338 +++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 76 +
>>> .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 789 ++++++++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-m2m.h | 49 +
>>> .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 737 ++++++++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 372 +++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-vpu.c | 312 ++++
>>> .../media/platform/mtk-mdp3/mtk-mdp3-vpu.h | 78 +
>>> 22 files changed, 5281 insertions(+)
>>> create mode 100644 drivers/media/platform/mtk-mdp3/Makefile
>>> create mode 100644 drivers/media/platform/mtk-
>>> mdp3/mdp_reg_ccorr.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_isp.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rdma.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wdma.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wrot.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> cmdq.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> cmdq.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> comp.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> comp.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> core.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> core.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> regs.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-
>>> regs.h
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c
>>> create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.h
>>>
>>
>> snip...
>>
>>> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
>>> b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
>>> new file mode 100644
>>> index 000000000000..a643f3ee928b
>>> --- /dev/null
>>> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
>>> @@ -0,0 +1,514 @@
>>
>> Looks like you forgot to check my review comments to this entire
>> file.
>> Can you please send a new version after applying the changes to this
>> file
>> suggested in my review of series v8?
> Hi Angelo,
>
> Thanks for the reminder and sorry for my carelessness. Considering the
> compatibility of subsequent chips and function independence, I plan to
> move those mutex mod definition to the corresponding driver, and
> release next version ASAP.
>
> Thanks & Regards,
> Moudy Ho
>> Thanks.
>
Hi Moudy,
Don't worry, we're humans, it happens to the best. We're always here to improve!
Thank you for sending the v10 by the way, I will review it as soon as I can.
Regards,
- Angelo
next prev parent reply other threads:[~2021-12-02 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 9:50 [PATCH v9 0/7] media: mediatek: support mdp3 on mt8183 platform Moudy Ho
2021-12-01 9:50 ` [PATCH v9 1/7] soc: mediatek: mmsys: add support for MDP Moudy Ho
2021-12-01 9:50 ` [PATCH v9 2/7] soc: mediatek: mmsys: add support for ISP control Moudy Ho
2021-12-01 10:29 ` AngeloGioacchino Del Regno
2021-12-01 9:50 ` [PATCH v9 3/7] soc: mediatek: mutex: add support for MDP Moudy Ho
2021-12-01 9:50 ` [PATCH v9 4/7] soc: mediatek: mutex: add functions that operate registers by CMDQ Moudy Ho
2021-12-01 10:30 ` AngeloGioacchino Del Regno
2021-12-01 9:50 ` [PATCH v9 5/7] dt-binding: mt8183: add Mediatek MDP3 dt-bindings Moudy Ho
2021-12-01 9:50 ` [PATCH v9 6/7] dts: arm64: mt8183: add Mediatek MDP3 nodes Moudy Ho
2021-12-01 9:50 ` [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver Moudy Ho
2021-12-01 10:37 ` AngeloGioacchino Del Regno
2021-12-02 3:35 ` moudy ho
2021-12-02 12:07 ` AngeloGioacchino Del Regno [this message]
2021-12-01 17:08 ` kernel test robot
2021-12-01 10:18 ` [PATCH v9 0/7] media: mediatek: support mdp3 on mt8183 platform AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038d4a24-7d61-ebb2-796f-63b59001ee54@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=acourbot@chromium.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=geert+renesas@glider.be \
--cc=hsinyi@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason-jh.lin@mediatek.com \
--cc=jernej.skrabec@siol.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=menghui.lin@mediatek.com \
--cc=moudy.ho@mediatek.com \
--cc=pihsun@chromium.org \
--cc=ping-hsun.wu@mediatek.com \
--cc=randy.wu@mediatek.com \
--cc=river.cheng@mediatek.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=roy-cw.yeh@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox