Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent

Jack Zhu
2023-03-07T06:41:13Z

On 2023/3/3 16:47, Krzysztof Kozlowski wrote:
> On 02/03/2023 10:19, jack.zhu wrote:
>> Add DT binding document for Starfive MIPI CSI2 receiver
>
> Ehh... you have entire commit msg to explain what you do here. Yet there
> is nothing mentioning that you actually have Cadence MIPI CSI here.
>
> Since you decided to add new bindings, you receive review matching new
> bindings. I don't think this is correct approach (duplicated bindings),
> but could work for me. However how are you going to solve all the points
> of my review?

Maybe I don't need to add the CSI yaml file, since it already exists on the Linux mainline.

>
> Best regards,
> Krzysztof
>