Re: [PATCH v1 11/11] media: starfive: enable building

Jack Zhu
2023-03-07T09:47:25Z

On 2023/3/3 16:43, Krzysztof Kozlowski wrote:
> On 02/03/2023 10:19, jack.zhu wrote:
>> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile
>> to enable building of the Starfive Camera subsystem driver.
>>
>> Signed-off-by: jack.zhu <jack.zhu@starfivetech.com>
>> ---
>> drivers/media/platform/Kconfig | 1 +
>> drivers/media/platform/Makefile | 1 +
>> drivers/media/platform/starfive/Kconfig | 18 ++++++++++++++++++
>> drivers/media/platform/starfive/Makefile | 14 ++++++++++++++
>
> This is not a separate commit. If it were, it would mean you just added
> dead code in previous commits, so why adding dead code in first place?
>

The previous patches are made according to the module function.I think
it is helpful to explain the composition of the code file.

stf_camss[patch 9] as a platform device manages all resources including
ISP and VIN. ISP/VIN [patch 7/8]as a sub-device needs to access other
resources managed by stf_camss.There is mutual reference between them.
Therefore, this patch is used for the overall compilation of the starfive
directory.

> Squash it.
>
> Best regards,
> Krzysztof
>