From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1D0C6FD1C for ; Thu, 9 Mar 2023 02:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjCICN2 (ORCPT ); Wed, 8 Mar 2023 21:13:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjCICN1 (ORCPT ); Wed, 8 Mar 2023 21:13:27 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EFFD5D46A; Wed, 8 Mar 2023 18:13:25 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id AEA9C24E18D; Thu, 9 Mar 2023 10:13:18 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:13:18 +0800 Received: from [192.168.60.132] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 10:13:18 +0800 Message-ID: <057ec81c-9b47-08b5-d572-a82ee1911ef8@starfivetech.com> Date: Thu, 9 Mar 2023 10:13:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 11/11] media: starfive: enable building Content-Language: en-US To: Krzysztof Kozlowski , "Mauro Carvalho Chehab" , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel CC: , , , References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-12-jack.zhu@starfivetech.com> <15b29a5b-29a1-8440-2b46-0c201c20defd@starfivetech.com> <05465184-5976-6cee-9925-e3712a1ea650@starfivetech.com> From: Jack Zhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 2023/3/8 19:07, Krzysztof Kozlowski wrote: > On 08/03/2023 12:03, Jack Zhu wrote: >> >> >> On 2023/3/8 18:33, Krzysztof Kozlowski wrote: >>> On 07/03/2023 10:46, Jack Zhu wrote: >>>> >>>> >>>> On 2023/3/3 16:43, Krzysztof Kozlowski wrote: >>>>> On 02/03/2023 10:19, jack.zhu wrote: >>>>>> Add Kconfig and Makefie, update platform/Kconfig and platform/Makefile >>>>>> to enable building of the Starfive Camera subsystem driver. >>>>>> >>>>>> Signed-off-by: jack.zhu >>>>>> --- >>>>>> drivers/media/platform/Kconfig | 1 + >>>>>> drivers/media/platform/Makefile | 1 + >>>>>> drivers/media/platform/starfive/Kconfig | 18 ++++++++++++++++++ >>>>>> drivers/media/platform/starfive/Makefile | 14 ++++++++++++++ >>>>> >>>>> This is not a separate commit. If it were, it would mean you just added >>>>> dead code in previous commits, so why adding dead code in first place? >>>>> >>>> >>>> The previous patches are made according to the module function.I think >>>> it is helpful to explain the composition of the code file. >>>> >>>> stf_camss[patch 9] as a platform device manages all resources including >>>> ISP and VIN. ISP/VIN [patch 7/8]as a sub-device needs to access other >>>> resources managed by stf_camss.There is mutual reference between them. >>>> Therefore, this patch is used for the overall compilation of the starfive >>>> directory. >>> >>> So previous code is dead? Again, what is the reason for adding dead >>> code? Mutual reference is not the answer. >>> >> >> Maybe I need to merge the previous patches[6-11] into one patch to submit? > > I gave you the recommendation in my first reply. What's wrong with it? > Thank you for your suggestion and the recommended action which I just confirmed it in detail in our previous messages.I agree with you that this is not a separate commit.I will merge them in the next version to be a single commit. This is my first time to submit code to the community.There are many things to learn. I sincerely thank you for your patient help and advice. > Best regards, > Krzysztof >