From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:32383 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932590Ab3GRP7P (ORCPT ); Thu, 18 Jul 2013 11:59:15 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQ500FZP328FG20@mailout1.w1.samsung.com> for linux-media@vger.kernel.org; Thu, 18 Jul 2013 16:59:13 +0100 (BST) From: Kamil Debski To: 'Sachin Kamat' , linux-media@vger.kernel.org Cc: Sylwester Nawrocki , patches@linaro.org, 'Hans Verkuil' References: <1373870183-28063-1-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1373870183-28063-1-git-send-email-sachin.kamat@linaro.org> Subject: RE: [PATCH 1/1] [media] s5p-g2d: Fix registration failure Date: Thu, 18 Jul 2013 17:59:06 +0200 Message-id: <061601ce83cf$bc4e9aa0$34ebcfe0$%debski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: pl Sender: linux-media-owner@vger.kernel.org List-ID: > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Monday, July 15, 2013 8:36 AM > > Commit 1c1d86a1ea ("[media] v4l2: always require v4l2_dev, rename > parent to dev_parent") expects v4l2_dev to be always set. > It converted most of the drivers using the parent field of video_device > to v4l2_dev field. G2D driver did not set the parent field. Hence it > got left out. Without this patch we get the following boot warning and > G2D driver fails to register the video device. > > WARNING: CPU: 0 PID: 1 at drivers/media/v4l2-core/v4l2-dev.c:775 > __video_register_device+0xfc0/0x1028() > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.11.0-rc1-00001-g1c3e372- > dirty #9 [] (unwind_backtrace+0x0/0xf4) from [] > (show_stack+0x10/0x14) [] (show_stack+0x10/0x14) from > [] (dump_stack+0x7c/0xb0) [] (dump_stack+0x7c/0xb0) > from [] (warn_slowpath_common+0x6c/0x88) [] > (warn_slowpath_common+0x6c/0x88) from [] > (warn_slowpath_null+0x1c/0x24) [] > (warn_slowpath_null+0x1c/0x24) from [] > (__video_register_device+0xfc0/0x1028) > [] (__video_register_device+0xfc0/0x1028) from [] > (g2d_probe+0x1f8/0x398) [] (g2d_probe+0x1f8/0x398) from > [] (platform_drv_probe+0x14/0x18) [] > (platform_drv_probe+0x14/0x18) from [] > (driver_probe_device+0x108/0x220) [] > (driver_probe_device+0x108/0x220) from [] > (__driver_attach+0x8c/0x90) [] (__driver_attach+0x8c/0x90) > from [] (bus_for_each_dev+0x60/0x94) [] > (bus_for_each_dev+0x60/0x94) from [] > (bus_add_driver+0x1c0/0x24c) [] (bus_add_driver+0x1c0/0x24c) > from [] (driver_register+0x78/0x140) [] > (driver_register+0x78/0x140) from [] > (do_one_initcall+0xf8/0x144) [] (do_one_initcall+0xf8/0x144) > from [] (kernel_init_freeable+0x13c/0x1d8) > [] (kernel_init_freeable+0x13c/0x1d8) from [] > (kernel_init+0xc/0x160) [] (kernel_init+0xc/0x160) from > [] (ret_from_fork+0x14/0x3c) ---[ end trace > 4e0ec028b0028e02 ]--- s5p-g2d 12800000.g2d: Failed to register video > device > s5p-g2d: probe of 12800000.g2d failed with error -22 > > Signed-off-by: Sachin Kamat > Cc: Hans Verkuil Acked-by: Kamil Debski > --- > drivers/media/platform/s5p-g2d/g2d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/s5p-g2d/g2d.c > b/drivers/media/platform/s5p-g2d/g2d.c > index 553d87e..fd6289d 100644 > --- a/drivers/media/platform/s5p-g2d/g2d.c > +++ b/drivers/media/platform/s5p-g2d/g2d.c > @@ -784,6 +784,7 @@ static int g2d_probe(struct platform_device *pdev) > } > *vfd = g2d_videodev; > vfd->lock = &dev->mutex; > + vfd->v4l2_dev = &dev->v4l2_dev; > ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0); > if (ret) { > v4l2_err(&dev->v4l2_dev, "Failed to register video > device\n"); > -- > 1.7.9.5