Re: [PATCH v2 0/4] vicodec: a couple fixes towards spec compliancy

Ezequiel Garcia
2019-06-18T03:28:50Z

On Mon, 2019-06-17 at 14:43 +0200, Hans Verkuil wrote:
> Hi Ezequiel,
>
> On 11/2/18 4:52 PM, Ezequiel Garcia wrote:
> > Given the stateful codec specification is still a moving target,
> > it doesn't make any sense to try to comply fully with it.
> >
> > On the other side, we can still comply with some basic userspace
> > expectations, with just a couple small changes.
> >
> > This series implements proper resolution changes propagation,
> > and fixes the CMD_STOP so it actually works.
> >
> > The intention of this series is to be able to test this driver
> > using already existing userspace, gstreamer in particular.
> > With this changes, it's possible to construct variations of
> > this pipeline:
> >
> > gst-launch-1.0 videotestsrc ! v4l2fwhtenc ! v4l2fwhtdec ! fakevideosink
> >
> > Also, as discussed in v1 feedback [1,2], I'm including pixel format
> > helpers, as RFC for now. Hans, Tomasz: is this what you had in mind?
> >
> > [1] https://www.spinics.net/lists/linux-media/msg141912.html
> > [2] https://www.spinics.net/lists/linux-media/msg142099.html
> >
> > v2:
> > * Add more info to commit logs
> > * Propagate changes on both encoders and decoders
> > * Add pixel format helpers
> >
> > Ezequiel Garcia (4):
> > media: Introduce helpers to fill pixel format structs
>
> This one has been applied (or probably a later version) already.
>
> > vicodec: Use pixel format helpers
>
> This doesn't apply anymore, but it would be useful to have.
>
> If you can rebase it, then that would be nice.
>

Sure.

> > vicodec: Propagate changes to the CAPTURE queue
> > vicodec: Implement spec-compliant stop command
>
> This two are obsolete as far as I know. The vicodec driver should handle
> this correctly now. If you think otherwise, please let me know.
>

Sure, let me re-test it.

Thanks,