From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FABF4FA for ; Mon, 11 Aug 2025 09:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754906072; cv=none; b=LkN+/hVsWUFx4ZagtjsnaLDCI1euXm0CiO6NGCFrmRZpbVYhlYlcnpNGHtyq5CSWa7CatoENrTWBewe2uZr1SK62eVgxjWxmgvFUv05I5+M0H+q1dm30dLy04nxoEH5rx28IYRrV7rRmZBYFnNsHNllnxhXToIp1LecX6kMXwdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754906072; c=relaxed/simple; bh=Nr/Zc96NOCXVBYCb5kWDyvXIpmXjObnc67hVK+GSoIE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iOafqrL4r/9DC2BFNjdqSnXo80mXQw/Q5cDLaHaC6Ztmt3opITEBoPVqfctKXAl5YglCbIHmdjsUpWMItToEBDrJoYz+relWm2hMgj7kxdzyhhw6PesKS04f9zzvty3iGnhQ1VU2P1rp0pPVXyh4SfLOsUJnVu+EzhHDZVEkLpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x26Xvxg4; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x26Xvxg4" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3b78d729bb8so2436269f8f.0 for ; Mon, 11 Aug 2025 02:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754906069; x=1755510869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SB4vnpXFiG3Tz1CHMP1RECPLWqu2Bxoslj8wFFWj+OA=; b=x26Xvxg4P6SxW8hHlwLOsDuJFxZNhLomHiRoZ0E/rp6JeYNCnRjQAhnbMUJzqdqn7R NgkS14VdPcHr9ZuKEOl5CzRj6JzErxLQ90WGJqNhfsfq2eWwHD56vIHoe2mwthVn0or5 p3nXkewtXvXhHTHRnxMJqQrz/9XLwJAsHces9Qay1lbXc378SpCtYSoOqlabxJAq/oRF TjxbV/FV5AfonX3T7BYVB9vQtHX1OsNaK3k+BqqodN9xn3Tibt3fhwg8PYLX4Dnc9aBh AAL05aOQGJuuKfZerm1O/kE6L0gPLApezhpVbK2COxa8ZqajoefzmFroMnllKmXRvDAj F3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754906069; x=1755510869; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SB4vnpXFiG3Tz1CHMP1RECPLWqu2Bxoslj8wFFWj+OA=; b=dh3tEzAqwdlI+brJOJ93rgsYazIkXs0H04DSX4RQ+FrRz4Dns7JzNB1ZN/+yT9Q5Iq atg4KsLeKeOxWIsIcpYj3umqujb9IiekLH+cLwivIx9yzLudWB6CJxYtk6Zo/daZhJpu xWZ77maeXo6FqO52LhbhY8XxWpTaqSKDdq8hS3mSN88yHFSQE9HVeIM5k6OGELOWu1uo 0UFqvKvs+ZnVsBOebzmo9Clp1jHfYLoTrS+M8R/kOpdiefuU13RbzI1FNSRlzRV2AmpB mMKQ0WxFQu0YqyYB7FfnYwdHitywUClWvipxgGt3fHxXxcWZioD7HVBoTtEkPenutzfT C7hQ== X-Gm-Message-State: AOJu0YxOjDqlcMZ4lTiZESwjmagcqYqt5gJUaJn660/y+CyeqVp0tzzO sKk0TnSoIGu+RzB0puOf0bBgq+ZNgDjujUgW/My/UPZjG9lpjppcI2MPLGsmgBcB1us= X-Gm-Gg: ASbGnctz1PWB5GASElZ3cCLHAECCW7HwRyQliopNDxrqdLfe9hGuOgdd0uVcRx/vTdu 0vd9FbboRYm9MokSmNdL2B1xiVTUZ8Q6qUhmMIwp/JMR2JUnd4ucjIZU0enzM2aLKCax5DMztK0 AMI0I6wH4Hywy2KnyLBBPOo3/jqpNiLhiTVbqCDzjfXUvNSkKQxd0vL4eRdcPXawMN7nxXFUDKa 8jyUk2NiEG3LEc52W2RmJlDK9sWHYUHE1auOuxLcE3jZavaT/q6cLICIzaIzOr8DEX00w0EdPoT Hao+i7OpBoDtLytq0/IlI5UeCrpPrTcMGShZTdAajRzv1WYFBYgXUPyoupwMzzmnQ6K3edFk9d/ 3v7TJOqDAcX5W3Rx8LTeqbnNTAvwLnTpVXj4iTV014i/3OauEK6uvhPdSdyFPXU9rb+AERY0uWg == X-Google-Smtp-Source: AGHT+IFLWaeyYt4QW6TcIL93toOpoOSpJi+FGEvUSeA8yqAuAWz6vKsBb7k0ryhdLbJ41J3PK6Tr+A== X-Received: by 2002:a05:6000:420e:b0:3b7:dd87:d741 with SMTP id ffacd0b85a97d-3b900b78c90mr9197547f8f.42.1754906068602; Mon, 11 Aug 2025 02:54:28 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459dcb86d6asm298162405e9.5.2025.08.11.02.54.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 02:54:28 -0700 (PDT) Message-ID: <06d96ac6-8006-4a46-8f55-e1988c0feb1d@linaro.org> Date: Mon, 11 Aug 2025 10:54:26 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/25] media: iris: Fix buffer count reporting in internal buffer check To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250704-iris-video-encoder-v1-0-b6ce24e273cf@quicinc.com> <20250704-iris-video-encoder-v1-1-b6ce24e273cf@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250704-iris-video-encoder-v1-1-b6ce24e273cf@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/07/2025 08:53, Dikshita Agarwal wrote: > Initialize the count variable to zero before counting unreleased > internal buffers in iris_check_num_queued_internal_buffers(). > This prevents stale values from previous iterations and ensures accurate > error reporting for each buffer type. Without this initialization, the > count could accumulate across types, leading to incorrect log messages. > > Fixes: d2abb1ff5a3c ("media: iris: Verify internal buffer release on close") > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_vidc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c > index c417e8c31f806e03555cd5e2a662a6efe5d58f3e..8285bdaf9466d4bea0f89a3b1943ed7d6c014b7d 100644 > --- a/drivers/media/platform/qcom/iris/iris_vidc.c > +++ b/drivers/media/platform/qcom/iris/iris_vidc.c > @@ -240,6 +240,7 @@ static void iris_check_num_queued_internal_buffers(struct iris_inst *inst, u32 p > > for (i = 0; i < internal_buffer_count; i++) { > buffers = &inst->buffers[internal_buf_type[i]]; > + count = 0; > list_for_each_entry_safe(buf, next, &buffers->list, list) > count++; > if (count) > Reviewed-by: Bryan O'Donoghue