public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge
@ 2023-03-03 18:15 bingbu.cao
  2023-03-06  9:34 ` Dan Scally
  0 siblings, 1 reply; 4+ messages in thread
From: bingbu.cao @ 2023-03-03 18:15 UTC (permalink / raw)
  To: linux-media, sakari.ailus, andriy.shevchenko, djrscally
  Cc: bingbu.cao, bingbu.cao

From: Bingbu Cao <bingbu.cao@intel.com>

Add more camera sensors into the supported camera sensors list
to make cio2-bridge to support more camera sensors.

Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
Changes from v1:
 - remove some sensors without available drivers
 - add .link_frequencies for each sensor

---
 drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
index dfefe0d8aa95..d59bec8a94e2 100644
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
@@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
 	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
 	/* Omnivision OV2680 */
 	CIO2_SENSOR_CONFIG("OVTI2680", 0),
+	/* Omnivision ov8856 */
+	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+	/* Omnivision ov2740 */
+	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
+	/* Hynix hi556 */
+	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
+	/* Omnivision ov13b10 */
+	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
 };
 
 static const struct cio2_property_names prop_names = {
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge
  2023-03-03 18:15 [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge bingbu.cao
@ 2023-03-06  9:34 ` Dan Scally
  2023-03-31 13:00   ` Bingbu Cao
  0 siblings, 1 reply; 4+ messages in thread
From: Dan Scally @ 2023-03-06  9:34 UTC (permalink / raw)
  To: bingbu.cao, linux-media, sakari.ailus, andriy.shevchenko,
	djrscally
  Cc: bingbu.cao

Good morning Bingbu

On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> Add more camera sensors into the supported camera sensors list
> to make cio2-bridge to support more camera sensors.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>

Thanks; this looks ok to me now:


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
> Changes from v1:
>   - remove some sensors without available drivers
>   - add .link_frequencies for each sensor
>
> ---
>   drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> index dfefe0d8aa95..d59bec8a94e2 100644
> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> @@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
>   	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
>   	/* Omnivision OV2680 */
>   	CIO2_SENSOR_CONFIG("OVTI2680", 0),
> +	/* Omnivision ov8856 */
> +	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
> +	/* Omnivision ov2740 */
> +	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
> +	/* Hynix hi556 */
> +	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
> +	/* Omnivision ov13b10 */
> +	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
>   };
>   
>   static const struct cio2_property_names prop_names = {

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge
  2023-03-06  9:34 ` Dan Scally
@ 2023-03-31 13:00   ` Bingbu Cao
  2023-03-31 13:03     ` Sakari Ailus
  0 siblings, 1 reply; 4+ messages in thread
From: Bingbu Cao @ 2023-03-31 13:00 UTC (permalink / raw)
  To: Dan Scally, bingbu.cao, linux-media, sakari.ailus,
	andriy.shevchenko, djrscally


On 3/6/23 5:34 PM, Dan Scally wrote:
> Good morning Bingbu
> 
> On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
>> From: Bingbu Cao <bingbu.cao@intel.com>
>>
>> Add more camera sensors into the supported camera sensors list
>> to make cio2-bridge to support more camera sensors.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> 
> Thanks; this looks ok to me now:
> 
> 
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> 
Sakari, 

Will you pick this change?

>> ---
>> Changes from v1:
>>   - remove some sensors without available drivers
>>   - add .link_frequencies for each sensor
>>
>> ---
>>   drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> index dfefe0d8aa95..d59bec8a94e2 100644
>> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> @@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
>>       CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
>>       /* Omnivision OV2680 */
>>       CIO2_SENSOR_CONFIG("OVTI2680", 0),
>> +    /* Omnivision ov8856 */
>> +    CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
>> +    /* Omnivision ov2740 */
>> +    CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
>> +    /* Hynix hi556 */
>> +    CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
>> +    /* Omnivision ov13b10 */
>> +    CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
>>   };
>>     static const struct cio2_property_names prop_names = {

-- 
Best regards,
Bingbu Cao

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge
  2023-03-31 13:00   ` Bingbu Cao
@ 2023-03-31 13:03     ` Sakari Ailus
  0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2023-03-31 13:03 UTC (permalink / raw)
  To: Bingbu Cao
  Cc: Dan Scally, bingbu.cao, linux-media, andriy.shevchenko, djrscally

Hi Bingbu,

On Fri, Mar 31, 2023 at 09:00:09PM +0800, Bingbu Cao wrote:
> 
> On 3/6/23 5:34 PM, Dan Scally wrote:
> > Good morning Bingbu
> > 
> > On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
> >> From: Bingbu Cao <bingbu.cao@intel.com>
> >>
> >> Add more camera sensors into the supported camera sensors list
> >> to make cio2-bridge to support more camera sensors.
> >>
> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> > 
> > Thanks; this looks ok to me now:
> > 
> > 
> > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> > 
> Sakari, 
> 
> Will you pick this change?

Thanks for the ping. I must have mistakenly mark this as "under review" in
patchwork earlier. It's in my tree now.

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-31 13:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-03 18:15 [PATCH v2] media: ipu3-cio2: support more camera sensors in cio2-bridge bingbu.cao
2023-03-06  9:34 ` Dan Scally
2023-03-31 13:00   ` Bingbu Cao
2023-03-31 13:03     ` Sakari Ailus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox