From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:30250 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753572AbaIVQ24 (ORCPT ); Mon, 22 Sep 2014 12:28:56 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NCB003BL9X19I40@mailout1.w1.samsung.com> for linux-media@vger.kernel.org; Mon, 22 Sep 2014 17:31:49 +0100 (BST) From: Kamil Debski To: 'ayaka' , linux-media@vger.kernel.org Cc: kyungmin.park@samsung.com, jtp.park@samsung.com, m.chehab@samsung.com References: <1406132104-6430-1-git-send-email-ayaka@soulik.info> <1406132104-6430-2-git-send-email-ayaka@soulik.info> In-reply-to: <1406132104-6430-2-git-send-email-ayaka@soulik.info> Subject: RE: [PATCH] s5p-mfc: correct the formats info for encoder Date: Mon, 22 Sep 2014 18:28:53 +0200 Message-id: <072d01cfd682$4cf2b220$e6d81660$%debski@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: pl Sender: linux-media-owner@vger.kernel.org List-ID: Hi Ayaka, Sorry for such a late reply - I just noticed this patch. > From: ayaka [mailto:ayaka@soulik.info] > Sent: Wednesday, July 23, 2014 6:15 PM > To: linux-media@vger.kernel.org > Cc: kyungmin.park@samsung.com; k.debski@samsung.com; > jtp.park@samsung.com; m.chehab@samsung.com; ayaka > Subject: [PATCH] s5p-mfc: correct the formats info for encoder > > The NV12M is supported by all the version of MFC, so it is better to > use it as default OUTPUT format. > MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is > not supported either. A proper Sign-off is missing here. According to the documentation of MFC v5 I have non-tiled format is supported. Which documentation were you looking at? >>From my documentation: ++++++++++++++ ENC_MAP_FOR_CUR 0xC51C Memory structure setting register of the current frame. R/W 0x00000000 Bits Name Description Reset Value [31:2] RESERVED Reserved 0 [1:0] ENC_MAP_FOR_CUR Memory structure of the current frame 0 : Linear mode 3 : 64x32 tiled mode 0 ++++++++++++++ Best wishes, -- Kamil Debski Samsung R&D Institute Poland > --- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > index d26b248..4ea3796 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > @@ -32,7 +32,7 @@ > #include "s5p_mfc_intr.h" > #include "s5p_mfc_opr.h" > > -#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT > +#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M > #define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264 > > static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static > struct s5p_mfc_fmt formats[] = { > .codec_mode = S5P_MFC_CODEC_NONE, > .type = MFC_FMT_RAW, > .num_planes = 2, > - .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT | > - MFC_V8_BIT, > + .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT, > }, > { > .name = "H264 Encoded Stream", > -- > 1.9.3