From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Dan Scally <djrscally@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hao Yao <hao.yao@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Duane <duanek@chorus.net>,
platform-driver-x86@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 5/9] platform/x86: int3472: Make regulator supply name configurable
Date: Wed, 23 Apr 2025 16:58:15 +0300 (EEST) [thread overview]
Message-ID: <09254093-8962-3d53-bf56-78eebb23fdd5@linux.intel.com> (raw)
In-Reply-To: <aAErdSgr_F8L7Sgw@smile.fi.intel.com>
On Thu, 17 Apr 2025, Andy Shevchenko wrote:
> On Thu, Apr 17, 2025 at 01:13:33PM +0200, Hans de Goede wrote:
> > This is a preparation patch for registering multiple regulators, which
> > requires a different supply-name for each regulator. Make supply-name
> > a parameter to skl_int3472_register_regulator() and use con-id to set it
> > so that the existing int3472_gpio_map remapping can be used with it.
> >
> > Since supply-name is a parameter now, drop the fixed
> > skl_int3472_regulator_map_supplies[] array and instead add lower- and
> > upper-case mappings of the passed-in supply-name to the regulator.
>
> With a comment and static_assert() LGTM now,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
Hi Andy,
In the lack of context what this refers to exactly, can you confirm those
are already present so no updates are required to v4? Thanks.
--
i.
next prev parent reply other threads:[~2025-04-23 13:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 11:13 [PATCH v4 0/9] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-04-17 11:13 ` [PATCH v4 1/9] platform/x86: int3472: Add skl_int3472_register_clock() helper Hans de Goede
2025-04-17 12:59 ` Ilpo Järvinen
2025-04-17 11:13 ` [PATCH v4 2/9] platform/x86: int3472: Stop setting a supply-name for GPIO regulators Hans de Goede
2025-04-17 11:13 ` [PATCH v4 3/9] platform/x86: int3472: Drop unused gpio field from struct int3472_gpio_regulator Hans de Goede
2025-04-17 11:13 ` [PATCH v4 4/9] platform/x86: int3472: Rework AVDD second sensor quirk handling Hans de Goede
2025-04-17 11:13 ` [PATCH v4 5/9] platform/x86: int3472: Make regulator supply name configurable Hans de Goede
2025-04-17 16:25 ` Andy Shevchenko
2025-04-23 13:58 ` Ilpo Järvinen [this message]
2025-04-23 15:38 ` Andy Shevchenko
2025-04-24 14:06 ` Ilpo Järvinen
2025-04-25 9:06 ` Hans de Goede
2025-04-17 11:13 ` [PATCH v4 6/9] platform/x86: int3472: Avoid GPIO regulator spikes Hans de Goede
2025-04-17 11:13 ` [PATCH v4 7/9] platform/x86: int3472: Prepare for registering more than 1 GPIO regulator Hans de Goede
2025-04-17 11:13 ` [PATCH v4 8/9] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-04-17 11:13 ` [PATCH v4 9/9] platform/x86: int3472: Debug log when remapping pins Hans de Goede
2025-04-18 15:47 ` [PATCH v4 0/9] platform/x86: int3472: Add handshake pin support David Heidelberg
2025-04-23 9:46 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09254093-8962-3d53-bf56-78eebb23fdd5@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=duanek@chorus.net \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox