Re: [PATCH 2/4] drm/sched: Add callback and enable signaling on debug

Christian König
2022-09-05T15:33:58Z

Am 05.09.22 um 15:46 schrieb Yadav, Arvind:
> On 9/5/2022 4:55 PM, Christian König wrote:
>> [SNIP]
>>
>> Am 05.09.22 um 12:56 schrieb Arvind Yadav:
>>>       .release = drm_sched_fence_release_finished,
>>>   };
>>>   diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>>> b/drivers/gpu/drm/scheduler/sched_main.c
>>> index e0ab14e0fb6b..140e3d8646e2 100644
>>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>>> @@ -961,7 +961,9 @@ static int drm_sched_main(void *param)
>>>               s_fence->parent = dma_fence_get(fence);
>>>               /* Drop for original kref_init of the fence */
>>>               dma_fence_put(fence);
>>
>> Uff, not related to your patch but that looks wrong to me. The
>> reference can only be dropped after the call to
>> dma_fence_add_callback().
>>
> Shall I take care with this patch or I will submit separate one ?

Separate one. It's probably no big deal since we grab another reference
right before, but still quite some broken coding.

Thanks,
Christian.

>
>>> -
>>> +#ifdef CONFIG_DEBUG_FS
>>> + dma_fence_enable_sw_signaling(&s_fence->finished);
>>> +#endif
>>
>> This should always be called, independent of the config options set.
>>
>> Christian.
>
> sure, I will remove the Config check.
>
> ~arvind
>
>>
>>>               r = dma_fence_add_callback(fence, &sched_job->cb,
>>>                              drm_sched_job_done_cb);
>>>               if (r == -ENOENT)
>>