From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C4E28B513; Mon, 30 Jun 2025 13:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288973; cv=none; b=H5aKviqaYQQYP8mZpcXDD1yayBKt8Au6M2hqnhBnvCOKDTpE4lvA51gvzKvv698qbLITlEtxltz0QN54Ldz3PoGlDYdMAffprgudX6FAGkWtEfszZIavc/ZeQBr0L9q6TjTSMV/2zTi21L1dcZDryOaRHIxidn8m57CxLFfDPjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288973; c=relaxed/simple; bh=dv3wBh5m+HW3Nx0rDQr4GPsSr/bsd0g+Sqa6i3BgbZM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=n/Q+B8JjQfLpIQlbxPVlK9CsQeg6lekIcHEM2kG+E6oBWHsaOKG1mr4HYeApKQPUwYW/QvpDCwSyqNv65RHxJtX1M7LD8cqNvBxDxSh7/RFqJim1CWijCChPfvn2TzxLE3+uX912EvY7mW8csFcdMX3HqBf6IAPJouVAVpu0bnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=UaJlchgA; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="UaJlchgA" Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55UAxWXY001329; Mon, 30 Jun 2025 15:09:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= +gPiTecoRPlnJ7Fm5WOws1ntoipek0S7ruHePGX3IMk=; b=UaJlchgAJfu5jbwv xXTiLCcPL8RYmS8Jgjxawh24Elz5ge9gN2ap04aErAnLM9OfMtvwOjbHxktjizaJ 1ed/Y5EGLxsfF5OWihCiDgkpBrxyZf0wIBokFNu64lqvLep52pXLlG8A3Iv6OyDX 7SgL/J46RE4hNbsh3maton4NGSSKjQ7tf77CZRgSq/vzW9BTFOurv91W/8P8yURM R2QLztwEjYAWz7pNjDls+HN3fwNFVcsYpVYXYkWddSkzrVklhYRTPGZj+pNzHWpu dml5KaZkaaGw9dvwDMDhxxU2KX/Xv46AI6NILcr31U4PELoqigVf6LQwyI2zLx7V tksNJA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 47j5tm0402-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jun 2025 15:09:13 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id CFD5F4004C; Mon, 30 Jun 2025 15:07:49 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B8DFAB4A79D; Mon, 30 Jun 2025 15:06:56 +0200 (CEST) Received: from [10.252.14.13] (10.252.14.13) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Jun 2025 15:06:55 +0200 Message-ID: <117094db-1b6d-4284-917a-ac69cfaa4d96@foss.st.com> Date: Mon, 30 Jun 2025 15:06:54 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] i2c: stm32f7: unmap DMA mapped buffer To: =?UTF-8?Q?Cl=C3=A9ment_Le_Goffic?= , "Alain Volmat" , Andi Shyti , "Maxime Coquelin" , Alexandre Torgue , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , "M'boumba Cedric Madianga" , Wolfram Sang CC: Pierre-Yves MORDRET , , , , , , , References: <20250630-i2c-upstream-v3-0-7a23ab26683a@foss.st.com> <20250630-i2c-upstream-v3-2-7a23ab26683a@foss.st.com> Content-Language: en-US From: Pierre Yves MORDRET In-Reply-To: <20250630-i2c-upstream-v3-2-7a23ab26683a@foss.st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-30_03,2025-06-27_01,2025-03-28_01 Hi Clement, On 6/30/25 14:55, Clément Le Goffic wrote: > Fix an issue where the mapped DMA buffer was not unmapped. > > Fixes: 7ecc8cfde553 ("i2c: i2c-stm32f7: Add DMA support") > Acked-by: Alain Volmat > Signed-off-by: Clément Le Goffic > --- > drivers/i2c/busses/i2c-stm32f7.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index e4aaeb2262d0..042386b4cabe 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1554,6 +1554,8 @@ static irqreturn_t stm32f7_i2c_handle_isr_errs(struct stm32f7_i2c_dev *i2c_dev, > if (i2c_dev->use_dma) { > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > } > > i2c_dev->master_mode = false; > @@ -1622,6 +1624,8 @@ static irqreturn_t stm32f7_i2c_isr_event_thread(int irq, void *data) > if (i2c_dev->use_dma) { > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > } > f7_msg->result = -ENXIO; > } > @@ -1642,6 +1646,8 @@ static irqreturn_t stm32f7_i2c_isr_event_thread(int irq, void *data) > dev_dbg(i2c_dev->dev, "<%s>: Timed out\n", __func__); > stm32f7_i2c_disable_dma_req(i2c_dev); > dmaengine_terminate_async(dma->chan_using); > + dma_unmap_single(i2c_dev->dev, dma->dma_buf, dma->dma_len, > + dma->dma_data_dir); > f7_msg->result = -ETIMEDOUT; > } > } > Thx for this V3 submission Reviewed-by: Pierre-Yves MORDRET Regards -- -- ~ Py MORDRET --