public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: hermann pitton <hermann-pitton@arcor.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: video4linux-list@redhat.com, Michael Krufky <mkrufky@linuxtv.org>,
	linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] TT S-1401 problem with kernel 2.6.24 ???
Date: Fri, 04 Apr 2008 04:19:05 +0200	[thread overview]
Message-ID: <1207275545.3365.26.camel@pc08.localdom.local> (raw)
In-Reply-To: <20080403221833.34d3c4d6@gaivota>

Am Donnerstag, den 03.04.2008, 22:18 -0300 schrieb Mauro Carvalho
Chehab:
> On Fri, 04 Apr 2008 01:23:22 +0200
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> > Am Donnerstag, den 03.04.2008, 01:38 +0200 schrieb hermann pitton:
> > > Hi again,
> > > 
> > > Am Mittwoch, den 02.04.2008, 22:47 +0400 schrieb Andrew Junev:
> > > > Hello Hermann,
> > > > 
> > > > Thanks a lot for this detailed explanation!
> > > > I really appreciate your help!
> > > > 
> > > > One small question: does it mean that kernels 2.6.24.5 or 2.6.24.6
> > > > _should_ have this patch already included?
> > > > 
> > > 
> > > seems we hang in current stable kernel rules.
> > > 
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=Documentation/stable_kernel_rules.txt;hb=HEAD
> > > 
> > > If we go back to 2.6.23 level, that patch might have less than 100 lines
> > > with context, but we break the
> > > 
> > >  - It must fix only one thing
> > > 
> > > rule, since we break the 2.6.24 LifeView Trio DVB-S support too then.
> > > 
> > > Seems sombody with such a device should reopen the bug on Bugzilla ...
> > > 
> > 
> > Hi Guys,
> > 
> > should we really let hang it like this on 2.6.24?
> > 
> > I'm not that happy with a recommendation for the distributions to pick
> > something out of it.
> > 
> > If we should go back to 2.6.23 level, so far nobody seems to have
> > realized a improvement for the LifeView Trio stuff, I'm not against it.
> > 
> > The changeset in question to revert is mercurial 6579.
> > 
> > If nobody else is interested and no comments, I also don't care anymore.
> 
> I don't see why to revert changeset 6579. On changeset 7186, an option were added at the frontend structure, to allow specify if diseqc requires a modulated signal or not. It is just a matter of changing the struct. Something like:
> 
>  static struct tda10086_config dvbs_card1 = {
>         .demod_address = 0x0e,
>         .invert = 0,
>         .diseqc_tone = 0,	/* Non-modulated tone - The default behavior after changeset 6579 */
>  };
> 
>  static struct tda10086_config dvbs_card2 = {
>         .demod_address = 0x0e,
>         .invert = 0,
>         .diseqc_tone = 1,	/* modulated tone - The default behavior before changeset 6579 */
>  };
> 
> The problem seems to be related to this struct:
> 
> static struct tda10086_config flydvbs = {
>         .demod_address = 0x0e,
>         .invert = 0,
>         .diseqc_tone = 0,
> };
> 
> is currently in use by several variants:
> 	SAA7134_BOARD_FLYDVB_TRIO,
> 	SAA7134_BOARD_MEDION_MD8800_QUADRO,
> 	SAA7134_BOARD_FLYDVBS_LR300,
> 	SAA7134_BOARD_PHILIPS_SNAKE,
> 	SAA7134_BOARD_MD7134_BRIDGE_2.
> 
> Probably, some of those boards need .diseqc_tone=1 while others require .diseqc_tone=0.
> 
> What are the boards that are currently broken?
> 
> Cheers,
> Mauro

Mauro,

as far I can see on v4l-dvb master, none. On 2.6.25 none. On 2.6.26 we
will have some new fun.

What Hartmut added is fully sufficient.

The problen is only on 2.6.24.something currently.

We can't add the necessarry fix currently, because above 100 lines
including context are not allowed bullshit we have to face. To go below
it, 2.6.23, means to break the Trio DVB-S stuff you took in from
Bugzilla. It is not the first time that something goes wrong here and I
really don't like the _pisszilla_ ;;) at all.

Too much comes easily in to just please and do a favour, but not on
devel and crosschecked level.

We have the right point I think, we can't accept some idiotic 100 lines
restriction including context here for a fix.

Cheers,
Hermann




--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  parent reply	other threads:[~2008-04-04  2:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 20:36 [linux-dvb] TT S-1401 problem with kernel 2.6.24 ??? Andrew Junev
2008-03-19 23:48 ` Oliver Endriss
2008-03-20 18:23   ` Andrew Junev
2008-03-21  2:37   ` hermann pitton
2008-03-21  6:42     ` Oliver Endriss
2008-03-21 18:29       ` Andrew Junev
     [not found]       ` <1206912674.3520.58.camel@pc08.localdom.local>
     [not found]         ` <1063704330.20080331082850@a-j.ru>
     [not found]           ` <1206999694.7762.41.camel@pc08.localdom.local>
     [not found]             ` <1112443057.20080402224744@a-j.ru>
2008-04-02 23:38               ` hermann pitton
2008-04-03 23:23                 ` hermann pitton
2008-04-04  0:32                   ` Oliver Endriss
2008-04-04  0:43                     ` hermann pitton
     [not found]                       ` <20080403222937.3b234a40@gaivota>
2008-04-04  2:56                         ` Oliver Endriss
2008-04-04  4:14                           ` Michael Krufky
2008-04-04 11:44                             ` Mauro Carvalho Chehab
2008-04-04 12:56                               ` Michael Krufky
2008-04-04 13:23                                 ` Michael Krufky
2008-04-04 17:59                                   ` Oliver Endriss
2008-04-04 23:08                                     ` hermann pitton
2008-04-08 21:01                                       ` mkrufky
2008-04-08 22:10                                         ` hermann pitton
2008-04-08 22:27                                         ` Oliver Endriss
2008-04-08 22:36                                           ` Mauro Carvalho Chehab
2008-04-04 12:02                             ` Oliver Endriss
     [not found]                   ` <20080403221833.34d3c4d6@gaivota>
2008-04-04  2:19                     ` hermann pitton [this message]
     [not found]                       ` <1076827621.20080406215420@a-j.ru>
     [not found]                         ` <1207522685.6334.29.camel@pc08.localdom.local>
     [not found]                           ` <1135983778.20080408193408@a-j.ru>
2008-04-09  0:56                             ` hermann pitton
2008-04-09  6:17                               ` Andrew Junev
2008-04-09 23:03                                 ` hermann pitton
2008-05-13 15:55                                   ` Andrew Junev
2008-05-15  0:23                                     ` hermann pitton
2008-04-04 14:15                   ` ldvb
2008-04-04 14:17                     ` ldvb
2008-04-04 23:20                       ` hermann pitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207275545.3365.26.camel@pc08.localdom.local \
    --to=hermann-pitton@arcor.de \
    --cc=linux-dvb@linuxtv.org \
    --cc=mchehab@infradead.org \
    --cc=mkrufky@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox