* Re: gspca_zc3xx oops - 2.6.27-rc1 [not found] ` <20080803073705.GA2754@debian> @ 2008-08-03 8:04 ` Jean-Francois Moine [not found] ` <20080803091303.GA3721@debian> 0 siblings, 1 reply; 2+ messages in thread From: Jean-Francois Moine @ 2008-08-03 8:04 UTC (permalink / raw) To: Rabin Vincent; +Cc: video4linux-list, Parag Warudkar On Sun, 2008-08-03 at 13:07 +0530, Rabin Vincent wrote: [snip] > Now sd->gamma shouldn't be zero because in sd_ctrls, the minimum value for it > is set to 1. This range should be checked by vidioc_s_ctrl in gspca.c, and we > have this there: > > if (ctrl->value < ctrls->qctrl.minimum > && ctrl->value > ctrls->qctrl.maximum) > return -ERANGE; > > There's a typo in this check, so userspace is able to set gamma to zero, and > the crash happens when streaming is started. Thank you! I did see the gamma was null, but I was searching for some array overflow... > Could you please try the patch below? > > >From 6827a2973d512479c8cf61d4a7ae1b6c4099b65b Mon Sep 17 00:00:00 2001 > From: Rabin Vincent <rabin@rab.in> > Date: Sun, 3 Aug 2008 12:00:04 +0530 > Subject: [PATCH] gspca: Fix ioctl range checking [snip] In which list did you post? Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20080803091303.GA3721@debian>]
* Re: gspca_zc3xx oops - 2.6.27-rc1 [not found] ` <20080803091303.GA3721@debian> @ 2008-08-03 8:50 ` Jean-Francois Moine 0 siblings, 0 replies; 2+ messages in thread From: Jean-Francois Moine @ 2008-08-03 8:50 UTC (permalink / raw) To: Rabin Vincent; +Cc: video4linux-list, Parag Warudkar On Sun, 2008-08-03 at 14:43 +0530, Rabin Vincent wrote: [snip] > This patch wasn't posted before (I just copy/pasted the > git-format-patch generated email here). I'm assuming you can just grab > it from this email and I don't need to post it separately? I am rather new to kernel development and I am not in the kernel mailing list. I may put your patch in the v4l-dvb repository via Mauro. Is it enough? BTW, Parag, Rabin's patch fixes the problem. May you cancel your own patch? Thank you again. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-03 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <82e4877d0808020922x64177318j6f8fe15955704521@mail.gmail.com>
[not found] ` <20080803073705.GA2754@debian>
2008-08-03 8:04 ` gspca_zc3xx oops - 2.6.27-rc1 Jean-Francois Moine
[not found] ` <20080803091303.GA3721@debian>
2008-08-03 8:50 ` Jean-Francois Moine
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox