Re: [patch] radio-mr800: remove warn- and err- messages

[Alexey Klimov <klimov.linux@gmail.com>]

Hello, all

On Wed, 2008-10-29 at 13:12 -0400, David Ellingsworth wrote:
> > you want my ack, you have the following options:
> >
> > 1. Use the same name used in the usb_driver struct
> > 2. Remove the name altogether
> >
> > If I were writing it, I'd do the following:
> >
> > #define DRVNAME "radio-mr800"
> > #define amradio_dev_err(dev, fmt, arg...) dev_err(dev, DRVNAME fmt, ##arg)
> > #define amradio_dev_warn(dev, fmt, arg...) dev_warn(dev, DRVNAME fmt, ##arg)
> Minor correction here ^^^^^
> 
> It should be:
> #define amradio_dev_err(dev, fmt, arg...) dev_err(dev, DRVNAME ": " fmt, ##arg)
> #define amradio_dev_warn(dev, fmt, arg...) dev_warn(dev, DRVNAME ": "
> fmt, ##arg)
> 
> - David Ellingsworth

You idea is great. I made patch, but have few questions.

May i use " - " in amradio_dev_info for example, instead of
using ..DRVNAME ": " fmt.. in defined macros? There are a lot of ":" in
messages if using ":".

May i use amradio_dev_info for cases where i want
&radio->videodev->dev ? And may i use usual dev_warn where intf->dev is
more apropriate ? Or you want me to use amradio_dev_warn macroses
everywhere ?

David, what do you think ?

Best regards,
Alexey Klimov

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list