Re: [PATCH] Add support for OmniVision OV534 based USB cameras.

[Jean-Francois Moine <moinejf@free.fr>]

On Wed, 2008-11-12 at 19:17 +0100, Antonio Ospite wrote:
> Well, with my hacks to gspca.c the ov534 driver has become really
> trivial. The source has shrunk from 33K to 13K. But these hacks could
> not be accepted though :) But, yes, the opinion on gspca is positive.

Hello Antonio,

Thank you for your opinion.

I looked again at your subdriver, and it seems good to me. So forget
about mine which is too buggy.

About your hacks to gspca, there are good and bad ideas. The good idea
is to have the bulk_nurbs parameter. The bad idea is to force it to one
when no set. To preserve the compatibility, the bulk_nurbs may be set to
some value for webcams which accept permanent bulk read, the submit
being done by gspca. For the other webcams, as those in finepix, a null
bulk_nurbs will indicate that the bulk read requests are done by the
subdriver. Is it OK for you?

Also, I saw a little problem in your subdriver: in pkt_scan, you use a
static variable (count). This does not work with many active webcams and
also after stop / restart streaming. Instead, you may know the current
byte count using the frame values data and data_end.

> The improvement that I always dream to see is to have bridge and
> sensor
> drivers split, so sensor drivers can be shared, a-la soc_camera, I
> mean.

There were many threads about this subject, but I could not find many
common values for a same sensor with different bridges in gspca...

> Bringing that idea to the extreme, one could think even to share
> sensor
> drivers with the soc_camera framework itself, but I only have this
> abstract suggestion, no idea at all about how it can be done, sorry.
> Could it be a GSoC project for next summer?

Why not?

-- 
Ken ar c'hentañ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list