Re: [PATCH] gspca: ov534 camera driver - Jean-Francois Moine

From: Jean-Francois Moine <moinejf@free.fr>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: video4linux-list@redhat.com
Subject: Re: [PATCH] gspca: ov534 camera driver
Date: Wed, 19 Nov 2008 20:37:13 +0100	[thread overview]
Message-ID: <1227123433.1709.39.camel@localhost> (raw)
In-Reply-To: <20081119181018.bf483949.ospite@studenti.unina.it>

On Wed, 2008-11-19 at 18:10 +0100, Antonio Ospite wrote:
> On Wed, 19 Nov 2008 16:50:20 +0100
> "Erik Andrén" <erik.andren@gmail.com> wrote:
	[snip]
> > I would collect all the data to be written in tables and loop over
> > them instead of having large sets of write calls.
> 
> I'd do that way too, normally.
> But I wanted to respect the original form of the reverse engineered
> code. If the driver really needs to be revolutionized, then it may be
> worth copying/sharing stuff with the (non-gspca) ov772x driver.
> 
> I know that the driver is in a suboptimal state, the bridge chip
> datasheet is not available, so I thought that as a first version it
> could be still accepted.

I think so. We have the original working driver. It may be optimized
later.

	[snip]
> > When would you not like to have the maximum frame rate?
> 
> I just thought that capturing at 25fps is a typical case, and using a
> default frame_rate near to that value would be sane, but please give
> advices here.

It seems fine to me.

Cheers.

-- 
Ken ar c'hentañ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list