Re: [PATCH] gspca_ov534: Print only frame_rate actually used.

[Jean-Francois Moine <moinejf@free.fr>]

On Thu, 2008-11-27 at 12:05 +0100, Antonio Ospite wrote:
> > The patch also includes removing the bulk_size setting at streamon time:
> > the value is already used at this time, and also, there is only one
> > resolution.
> We will add this again when we add other resolutions, OK.

The bulk_size must be set at the max resolution because it is used for
buffer allocation before stream on.

	[snip]
> >  /* V4L2 controls supported by the driver */
> > @@ -59,7 +58,7 @@
> >  	{640, 480, V4L2_PIX_FMT_YUYV, V4L2_FIELD_NONE,
> >  	 .bytesperline = 640 * 2,
> >  	 .sizeimage = 640 * 480 * 2,
> > -	 .colorspace = V4L2_COLORSPACE_JPEG,
> > +	 .colorspace = V4L2_COLORSPACE_SRGB,
> >  	 .priv = 0},
> >  };
> >
> 
> Can you explain this one, please?

I think the JPEG images embed colorspace information, and here, it is
simple RGB.

> [snip]
> > @@ -433,7 +429,6 @@
> >  	int framesize = gspca_dev->cam.bulk_size;
> >  
> >  	if (len == framesize - 4) {
> > -		frame =
> >  		    gspca_frame_add(gspca_dev, FIRST_PACKET, frame, data, len);
> 
> This change is just to follow the convention used by other drivers,
> right? You could also adjust indentation on following line, then.

If you look carefully, the frame returned by gspca_frame_add() is
changed only when the packet type is LAST_PACKET. OK for the
indentation.

Cheers.

-- 
Ken ar c'hentañ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list