* [PATCH] si470x: Support for DealExtreme
@ 2008-12-03 18:29 Tobias Lorenz
2008-12-06 23:40 ` Alexey Klimov
[not found] ` <208cbae30812301524w8750a60xd3085ebc8134d865@mail.gmail.com>
0 siblings, 2 replies; 3+ messages in thread
From: Tobias Lorenz @ 2008-12-03 18:29 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: video4linux-list, mm-commits, greg, mlord, lkml,
v4l-dvb-maintainer
Mauro,
Please pull from http://linuxtv.org/hg/~tlorenz/v4l-dvb
for the following changeset:
01/01: Add USB ID for the Sil4701 radio from DealExtreme.
http://linuxtv.org/hg/~tlorenz/v4l-dvb?cmd=changeset;node=42f57f457d9d3a91d5f3966b59bfa87679ecb1c7
Documentation/video4linux/si470x.txt | 1 +
drivers/media/radio/radio-si470x.c | 4 ++++
2 files changed, 5 insertions(+)
Thanks,
Tobias
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] si470x: Support for DealExtreme
2008-12-03 18:29 [PATCH] si470x: Support for DealExtreme Tobias Lorenz
@ 2008-12-06 23:40 ` Alexey Klimov
[not found] ` <208cbae30812301524w8750a60xd3085ebc8134d865@mail.gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Klimov @ 2008-12-06 23:40 UTC (permalink / raw)
To: Tobias Lorenz, Mark Lord, Jiri Kosina, Jiri Slaby
Cc: greg, video4linux-list, Mauro Carvalho Chehab
On Wed, 2008-12-03 at 19:29 +0100, Tobias Lorenz wrote:
> Mauro,
>
> Please pull from http://linuxtv.org/hg/~tlorenz/v4l-dvb
> for the following changeset:
>
> 01/01: Add USB ID for the Sil4701 radio from DealExtreme.
> http://linuxtv.org/hg/~tlorenz/v4l-dvb?cmd=changeset;node=42f57f457d9d3a91d5f3966b59bfa87679ecb1c7
> Documentation/video4linux/si470x.txt | 1 +
> drivers/media/radio/radio-si470x.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> Thanks,
> Tobias
> --
Hello, all
This patch changes only radio driver. As we know, usbhid module creates
hiddev-device, binds device and doesn't allow si470x module to probe()
device. I contacted to Mark and he confirmed that usbhid module
disallowed si470x to work normally. So, i did patch that makes
usb-hidqurks in hid-subsystem.
Mauro, don't you mind if it goes through Jiri's tree ?
Jiri, can you take it to your hid-tree ?
(actually, i don't who should be placed in Cc section of patch; patch
can be applied well against 28-rc7-git4)
---
HID: Don't allow DealExtreme usb-radio be handled by usb hid driver
This device is already handled by radio-si470x driver, and we
therefore want usbhid to ignore it. Patch places usb ids of that device
in ignore section of hid-core.c
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
---
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 40df3e1..0ac2b66 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1420,6 +1420,7 @@ static const struct hid_device_id hid_ignore_list[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM109) },
{ HID_USB_DEVICE(USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_HIDCOM) },
{ HID_USB_DEVICE(USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_ULTRAMOUSE) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_DEALEXTREAME, USB_DEVICE_ID_DEALEXTREAME_RADIO_SI4701) },
{ HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EARTHMATE) },
{ HID_USB_DEVICE(USB_VENDOR_ID_DELORME, USB_DEVICE_ID_DELORME_EM_LT20) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 3928969..1fe0b8b 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -141,6 +141,9 @@
#define USB_DEVICE_ID_CYPRESS_BARCODE_1 0xde61
#define USB_DEVICE_ID_CYPRESS_BARCODE_2 0xde64
+#define USB_VENDOR_ID_DEALEXTREAME 0x10c5
+#define USB_DEVICE_ID_DEALEXTREAME_RADIO_SI4701 0x819a
+
#define USB_VENDOR_ID_DELL 0x413c
#define USB_DEVICE_ID_DELL_W7658 0x2005
#define USB_DEVICE_ID_DELL_SK8115 0x2105
--
Best regards, Klimov Alexey
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v4l-dvb-maintainer] [PATCH] si470x: Support for DealExtreme
[not found] ` <49679F6B.1070903@iki.fi>
@ 2009-01-09 21:24 ` Alexey Klimov
0 siblings, 0 replies; 3+ messages in thread
From: Alexey Klimov @ 2009-01-09 21:24 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Tobias Lorenz, Linux Media Mailing List
(added linux-media mailing list)
On Fri, Jan 9, 2009 at 10:03 PM, Antti Palosaari <crope@iki.fi> wrote:
> Alexey Klimov wrote:
>>
>> Hello, Antti
>>
>> On Fri, Jan 9, 2009 at 8:16 PM, Antti Palosaari <crope@iki.fi> wrote:
>>>
>>> Antti Palosaari wrote:
>>>>
>>>> hello,
>>>> I bought this stick and I did not get it working. This is my very first
>>>> FM
>>>> radio device thus I am not sure if I did something wrong. I did some
>>>> googling and I got understood that analogue radio devices should create
>>>> deivice /dev/radio - but it does not. My distribution is Fedora 9 x86
>>>> and
>>>> v4l-dvb-master is very fresh.
>>
>> Well, i'm confused (may be i understand your English in wrong way).
>> Did you bought DealExtreme Radio ? Looks like your device called RDing
>> PCear FM Radio. But they have same IDs.
>
> yes
> Bus 002 Device 012: ID 10c5:819a Sanei Electric, Inc.
> I ordered that one: http://dealextreme.com/details.dx/sku.1929
> Device is 100% similar except that no external antenna (from comments I
> think it is rolled inside).
>
>> We have two devices with different names ?
>
> Looks like. I will attach lsusb.
Thanks, probably comments (and may be documentation file) should be fixed.
>> Which kernel version do you use ?
>
> Linux localhost.localdomain 2.6.27.9-73.fc9.x86_64 #1 SMP Tue Dec 16
> 14:54:03 EST 2008 x86_64 x86_64 x86_64 GNU/Linux
> I will update Fedora 10 today.
This kernel doesn't have patch(described below) for usbhid.
>> I have small suggestion that usbhid driver binds this device and didnt
>> allow probe-function of si470x driver to be called. We have patch for
>> hid-subsystem that should cover this issue. This patch still not in
>> 2.6.28-git13. I hope in 2.6.28-rc1 we see this patch.
>> If not we should ask Jiri what happened with patch.
Well, after answering first time i checked again and find that patch
for usbhid that forces usbhid not to touch this device already in
upstream kernel.
It is "HID: don't allow DealExtreme usb-radio be handled by usb hid driver".
> Lets see if Fedora 10 have newer Kernel, if not I will try to install it
> from delvel system (rawhide).
I dont know how fast changes reach Fedora kernel package.
>> So, you can use bind-unbind approach to deal with problem or you can
>> make rmmod usbhid; modprobe radio-si470x and then plug device in. Feel
>> free to ask more if something wrong.
>
> [root@localhost ~]# rmmod usbhid; modprobe radio-si470x
> ERROR: Module usbhid does not exist in /proc/modules
May be i understand you in wrong way ?
Let's check again. You plug device in, make rmmod radio-si470x, then
you unplug radio and plug again ?
Dmesg shows you that radio-si470x is loaded ? But you have no sound, right ?
There is also should be snd-usb-audio module loaded. Please read
Documentation/video4linux/si470x.txt.
Please, tell us problem in more clear way and let's wait Tobias or
others answer.
>> Tobias, what do you think about this issue ?
>>
>
> regards
> Antti
> --
> http://palosaari.fi/
>
>
> Bus 002 Device 014: ID 10c5:819a Sanei Electric, Inc.
> Device Descriptor:
> bLength 18
> bDescriptorType 1
> bcdUSB 1.10
> bDeviceClass 0 (Defined at Interface level)
> bDeviceSubClass 0
> bDeviceProtocol 0
> bMaxPacketSize0 64
> idVendor 0x10c5 Sanei Electric, Inc.
> idProduct 0x819a
> bcdDevice 1.00
> iManufacturer 1 www.rding.cn
> iProduct 2
> iSerial 0
> bNumConfigurations 1
> Configuration Descriptor:
> bLength 9
> bDescriptorType 2
> wTotalLength 145
> bNumInterfaces 3
> bConfigurationValue 1
> iConfiguration 0
> bmAttributes 0x80
> (Bus Powered)
> MaxPower 100mA
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 0
> bAlternateSetting 0
> bNumEndpoints 0
> bInterfaceClass 1 Audio
> bInterfaceSubClass 1 Control Device
> bInterfaceProtocol 0
> iInterface 0
> AudioControl Interface Descriptor:
> bLength 9
> bDescriptorType 36
> bDescriptorSubtype 1 (HEADER)
> bcdADC 1.00
> wTotalLength 43
> bInCollection 1
> baInterfaceNr( 0) 1
> AudioControl Interface Descriptor:
> bLength 12
> bDescriptorType 36
> bDescriptorSubtype 2 (INPUT_TERMINAL)
> bTerminalID 1
> wTerminalType 0x0710 Radio Receiver
> bAssocTerminal 0
> bNrChannels 2
> wChannelConfig 0x0003
> Left Front (L)
> Right Front (R)
> iChannelNames 0
> iTerminal 0
> AudioControl Interface Descriptor:
> bLength 13
> bDescriptorType 36
> bDescriptorSubtype 6 (FEATURE_UNIT)
> bUnitID 2
> bSourceID 1
> bControlSize 2
> bmaControls( 0) 0x01
> bmaControls( 0) 0x00
> Mute
> bmaControls( 1) 0x00
> bmaControls( 1) 0x00
> bmaControls( 2) 0x00
> bmaControls( 2) 0x00
> iFeature 0
> AudioControl Interface Descriptor:
> bLength 9
> bDescriptorType 36
> bDescriptorSubtype 3 (OUTPUT_TERMINAL)
> bTerminalID 3
> wTerminalType 0x0101 USB Streaming
> bAssocTerminal 0
> bSourceID 2
> iTerminal 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 1
> bAlternateSetting 0
> bNumEndpoints 0
> bInterfaceClass 1 Audio
> bInterfaceSubClass 2 Streaming
> bInterfaceProtocol 0
> iInterface 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 1
> bAlternateSetting 1
> bNumEndpoints 1
> bInterfaceClass 1 Audio
> bInterfaceSubClass 2 Streaming
> bInterfaceProtocol 0
> iInterface 0
> AudioStreaming Interface Descriptor:
> bLength 7
> bDescriptorType 36
> bDescriptorSubtype 1 (AS_GENERAL)
> bTerminalLink 3
> bDelay 0 frames
> wFormatTag 1 PCM
> AudioStreaming Interface Descriptor:
> bLength 11
> bDescriptorType 36
> bDescriptorSubtype 2 (FORMAT_TYPE)
> bFormatType 1 (FORMAT_TYPE_I)
> bNrChannels 2
> bSubframeSize 2
> bBitResolution 16
> bSamFreqType 1 Discrete
> tSamFreq[ 0] 96000
> Endpoint Descriptor:
> bLength 9
> bDescriptorType 5
> bEndpointAddress 0x83 EP 3 IN
> bmAttributes 5
> Transfer Type Isochronous
> Synch Type Asynchronous
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 1
> bRefresh 0
> bSynchAddress 0
> AudioControl Endpoint Descriptor:
> bLength 7
> bDescriptorType 37
> bDescriptorSubtype 1 (EP_GENERAL)
> bmAttributes 0x00
> bLockDelayUnits 2 Decoded PCM samples
> wLockDelay 0 Decoded PCM samples
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 2
> bAlternateSetting 0
> bNumEndpoints 2
> bInterfaceClass 3 Human Interface Device
> bInterfaceSubClass 0 No Subclass
> bInterfaceProtocol 0 None
> iInterface 0
> HID Device Descriptor:
> bLength 9
> bDescriptorType 33
> bcdHID 1.11
> bCountryCode 0 Not supported
> bNumDescriptors 1
> bDescriptorType 34 Report
> wDescriptorLength 203
> Report Descriptors:
> ** UNAVAILABLE **
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x81 EP 1 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 10
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x02 EP 2 OUT
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 1
> Device Status: 0x0000
> (Bus Powered)
P.S. I think you don't mind I have cc linux-media maillist to share this case.
--
Best regards, Klimov Alexey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-09 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-03 18:29 [PATCH] si470x: Support for DealExtreme Tobias Lorenz
2008-12-06 23:40 ` Alexey Klimov
[not found] ` <208cbae30812301524w8750a60xd3085ebc8134d865@mail.gmail.com>
[not found] ` <496784B6.8090104@iki.fi>
[not found] ` <49678678.60506@iki.fi>
[not found] ` <208cbae30901091043y771b2387p858015513736c109@mail.gmail.com>
[not found] ` <49679F6B.1070903@iki.fi>
2009-01-09 21:24 ` [v4l-dvb-maintainer] " Alexey Klimov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox