Re: [PATCH] Add support for sq905 based cameras to gspca

[Alexey Klimov <klimov.linux@gmail.com>]

Hello, Adam
May i add small note if you don't mind ?

On Mon, 2009-01-19 at 23:22 +0000, Adam Baker wrote:

<snip>

> +/* -- module insert / remove -- */
> +static int __init sd_mod_init(void)
> +{
> +	if (usb_register(&sd_driver) < 0)
> +		return -1;
> +	PDEBUG(D_PROBE, "registered");
> +	return 0;
> +}
> +static void __exit sd_mod_exit(void)
> +{
> +	usb_deregister(&sd_driver);
> +	PDEBUG(D_PROBE, "deregistered");
> +}

May be it's better for CodingStyle if sd_mod_init will look like this:

static int __init sd_mod_init(void) 
{ 
	int ret; 
	ret = usb_register(&sd_driver); 
	if (ret < 0) 
		return ret; 
	PDEBUG(D_PROBE, "registered"); 
	return 0; 
}

?


> +module_init(sd_mod_init);
> +module_exit(sd_mod_exit);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Best regards, Klimov Alexey