public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "figo.zhang" <figo.zhang@kolorific.com>
To: kraxel@bytesex.org, Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: g.liakhovetski@gmx.de, linux-media@vger.kernel.org, figo1802@126.com
Subject: [PATCH][RESEND]saa7134-video.c: fix the block bug
Date: Fri, 08 May 2009 10:31:02 +0800	[thread overview]
Message-ID: <1241749862.3420.21.camel@myhost> (raw)

when re-open or re-start (video_streamon), the q->curr would not be NULL in saa7134_buffer_queue(),
and all the qbuf will add to q->queue list,no one to do activate to start DMA,and then no interrupt 
would happened,so it will be block. 

In VIDEOBUF_NEEDS_INIT state , inital the curr pointer to be NULL int  the buffer_prepare().

Signed-off-by: Figo.zhang <figo.zhang@kolorific.com>
---
 drivers/media/video/saa7134/saa7134-video.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index 493cad9..550d6ce 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1057,6 +1057,7 @@ static int buffer_prepare(struct videobuf_queue *q,
 		buf->vb.field  = field;
 		buf->fmt       = fh->fmt;
 		buf->pt        = &fh->pt_cap;
+		dev->video_q.curr = NULL;
 
 		err = videobuf_iolock(q,&buf->vb,&dev->ovbuf);
 		if (err)



             reply	other threads:[~2009-05-08  2:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08  2:31 figo.zhang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-08  2:48 [PATCH][RESEND]saa7134-video.c: fix the block bug figo.zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241749862.3420.21.camel@myhost \
    --to=figo.zhang@kolorific.com \
    --cc=figo1802@126.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=kraxel@bytesex.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox