* [PATCH][RESEND]saa7134-video.c: fix the block bug
@ 2009-05-08 2:48 figo.zhang
0 siblings, 0 replies; 2+ messages in thread
From: figo.zhang @ 2009-05-08 2:48 UTC (permalink / raw)
To: kraxel, Hans Verkuil, Mauro Carvalho Chehab
Cc: g.liakhovetski, linux-media, figo1802
when re-open or re-start (video_streamon), the q->curr would not be NULL in saa7134_buffer_queue(),
and all the qbuf will add to q->queue list,no one to do activate to start DMA,and then no interrupt
would happened,so it will be block.
In VIDEOBUF_NEEDS_INIT state , initial the curr pointer to be NULL in the buffer_prepare() function.
Signed-off-by: Figo.zhang <figo.zhang@kolorific.com>
---
drivers/media/video/saa7134/saa7134-video.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index 493cad9..550d6ce 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1057,6 +1057,7 @@ static int buffer_prepare(struct videobuf_queue *q,
buf->vb.field = field;
buf->fmt = fh->fmt;
buf->pt = &fh->pt_cap;
+ dev->video_q.curr = NULL;
err = videobuf_iolock(q,&buf->vb,&dev->ovbuf);
if (err)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH][RESEND]saa7134-video.c: fix the block bug
@ 2009-05-08 2:31 figo.zhang
0 siblings, 0 replies; 2+ messages in thread
From: figo.zhang @ 2009-05-08 2:31 UTC (permalink / raw)
To: kraxel, Hans Verkuil, Mauro Carvalho Chehab
Cc: g.liakhovetski, linux-media, figo1802
when re-open or re-start (video_streamon), the q->curr would not be NULL in saa7134_buffer_queue(),
and all the qbuf will add to q->queue list,no one to do activate to start DMA,and then no interrupt
would happened,so it will be block.
In VIDEOBUF_NEEDS_INIT state , inital the curr pointer to be NULL int the buffer_prepare().
Signed-off-by: Figo.zhang <figo.zhang@kolorific.com>
---
drivers/media/video/saa7134/saa7134-video.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c
index 493cad9..550d6ce 100644
--- a/drivers/media/video/saa7134/saa7134-video.c
+++ b/drivers/media/video/saa7134/saa7134-video.c
@@ -1057,6 +1057,7 @@ static int buffer_prepare(struct videobuf_queue *q,
buf->vb.field = field;
buf->fmt = fh->fmt;
buf->pt = &fh->pt_cap;
+ dev->video_q.curr = NULL;
err = videobuf_iolock(q,&buf->vb,&dev->ovbuf);
if (err)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-08 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-08 2:48 [PATCH][RESEND]saa7134-video.c: fix the block bug figo.zhang
-- strict thread matches above, loose matches on Subject: below --
2009-05-08 2:31 figo.zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox