* [patch review 1/4] dsbr100: remove radio->users counter
@ 2009-05-28 20:44 Alexey Klimov
0 siblings, 0 replies; only message in thread
From: Alexey Klimov @ 2009-05-28 20:44 UTC (permalink / raw)
To: Linux Media; +Cc: Douglas Schilling Landgraf
Patch removes radio->users counter because it is not in use.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r 315bc4b65b4f linux/drivers/media/radio/dsbr100.c
--- a/linux/drivers/media/radio/dsbr100.c Sun May 17 12:28:55 2009 +0000
+++ b/linux/drivers/media/radio/dsbr100.c Tue May 19 15:05:02 2009 +0400
@@ -146,7 +146,6 @@
struct mutex lock; /* buffer locking */
int curfreq;
int stereo;
- int users;
int removed;
int muted;
};
@@ -552,14 +551,12 @@
int retval;
lock_kernel();
- radio->users = 1;
radio->muted = 1;
retval = dsbr100_start(radio);
if (retval < 0) {
dev_warn(&radio->usbdev->dev,
"Radio did not start up properly\n");
- radio->users = 0;
unlock_kernel();
return -EIO;
}
@@ -581,10 +578,6 @@
if (!radio)
return -ENODEV;
- mutex_lock(&radio->lock);
- radio->users = 0;
- mutex_unlock(&radio->lock);
-
if (!radio->removed) {
retval = dsbr100_stop(radio);
if (retval < 0) {
@@ -698,7 +691,6 @@
mutex_init(&radio->lock);
radio->removed = 0;
- radio->users = 0;
radio->usbdev = interface_to_usbdev(intf);
radio->curfreq = FREQ_MIN * FREQ_MUL;
--
Best regards, Klimov Alexey
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-28 20:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-28 20:44 [patch review 1/4] dsbr100: remove radio->users counter Alexey Klimov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox