From: "Figo.zhang" <figo1802@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, kraxel@bytesex.org,
Hans Verkuil <hverkuil@xs4all.nl>,
mark@alpha.dyndns.org, Mark McClelland <mark@alpha.dyndns.org>,
cpbotha@ieee.org, claudio@conectiva.com
Subject: [PATCH] ov511.c: video_register_device() return zero on success
Date: Sun, 31 May 2009 14:41:52 +0800 [thread overview]
Message-ID: <1243752113.3425.12.camel@myhost> (raw)
video_register_device() return zero on success, it would not return a positive integer.
Signed-off-by: Figo.zhang <figo1802@gmail.com>
---
drivers/media/video/ov511.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/ov511.c b/drivers/media/video/ov511.c
index 9af5532..816427e 100644
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
@@ -5851,7 +5851,7 @@ ov51x_probe(struct usb_interface *intf, const struct usb_device_id *id)
break;
if (video_register_device(ov->vdev, VFL_TYPE_GRABBER,
- unit_video[i]) >= 0) {
+ unit_video[i]) == 0) {
break;
}
}
next reply other threads:[~2009-05-31 6:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 6:41 Figo.zhang [this message]
2009-06-11 1:39 ` [PATCH] ov511.c: video_register_device() return zero on success Mauro Carvalho Chehab
2009-06-11 4:40 ` Mauro Carvalho Chehab
2009-06-11 6:36 ` Hans Verkuil
2009-06-11 11:32 ` Mauro Carvalho Chehab
2009-06-11 6:39 ` Figo.zhang
2009-06-11 22:51 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2009-06-11 11:51 Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243752113.3425.12.camel@myhost \
--to=figo1802@gmail.com \
--cc=claudio@conectiva.com \
--cc=cpbotha@ieee.org \
--cc=hverkuil@xs4all.nl \
--cc=kraxel@bytesex.org \
--cc=linux-media@vger.kernel.org \
--cc=mark@alpha.dyndns.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox