From: Alexey Klimov <klimov.linux@gmail.com>
To: "Jean-Francois Moine" <moinejf@free.fr>,
"Erik Andrén" <erik.andren@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: [patch review] gspca - stv06xx: remove needless if check and goto
Date: Tue, 09 Jun 2009 14:59:40 +0400 [thread overview]
Message-ID: <1244545180.28249.8.camel@tux.localhost> (raw)
Hello, Jean-Francois and Erik André
What do you think about such small change?
Looks like the code doesn't need if-check and goto here in stv06xx_stopN
function. The code after label "out" does this.
--
Patch removes needless if check and goto.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
--- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400
+++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400
@@ -293,8 +293,6 @@
goto out;
err = sd->sensor->stop(sd);
- if (err < 0)
- goto out;
out:
if (err < 0)
--
Best regards, Klimov Alexey
next reply other threads:[~2009-06-09 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 10:59 Alexey Klimov [this message]
2009-06-09 11:37 ` [patch review] gspca - stv06xx: remove needless if check and goto Erik Andrén
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244545180.28249.8.camel@tux.localhost \
--to=klimov.linux@gmail.com \
--cc=erik.andren@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox