* [patch review] gspca - stv06xx: remove needless if check and goto
@ 2009-06-09 10:59 Alexey Klimov
2009-06-09 11:37 ` Erik Andrén
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Klimov @ 2009-06-09 10:59 UTC (permalink / raw)
To: Jean-Francois Moine, Erik Andrén; +Cc: linux-media
Hello, Jean-Francois and Erik André
What do you think about such small change?
Looks like the code doesn't need if-check and goto here in stv06xx_stopN
function. The code after label "out" does this.
--
Patch removes needless if check and goto.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
--- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400
+++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400
@@ -293,8 +293,6 @@
goto out;
err = sd->sensor->stop(sd);
- if (err < 0)
- goto out;
out:
if (err < 0)
--
Best regards, Klimov Alexey
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch review] gspca - stv06xx: remove needless if check and goto
2009-06-09 10:59 [patch review] gspca - stv06xx: remove needless if check and goto Alexey Klimov
@ 2009-06-09 11:37 ` Erik Andrén
0 siblings, 0 replies; 2+ messages in thread
From: Erik Andrén @ 2009-06-09 11:37 UTC (permalink / raw)
To: Alexey Klimov; +Cc: Jean-Francois Moine, linux-media
2009/6/9 Alexey Klimov <klimov.linux@gmail.com>:
> Hello, Jean-Francois and Erik André
>
> What do you think about such small change?
> Looks like the code doesn't need if-check and goto here in stv06xx_stopN
> function. The code after label "out" does this.
>
> --
> Patch removes needless if check and goto.
>
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Looks sane.
Thank you for reporting.
Best regards,
Erik
Reviewed-by: Erik Andrén <erik.andren@gmail.com>
> --
> diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
> --- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400
> +++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400
> @@ -293,8 +293,6 @@
> goto out;
>
> err = sd->sensor->stop(sd);
> - if (err < 0)
> - goto out;
>
> out:
> if (err < 0)
>
>
> --
> Best regards, Klimov Alexey
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-09 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-09 10:59 [patch review] gspca - stv06xx: remove needless if check and goto Alexey Klimov
2009-06-09 11:37 ` Erik Andrén
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox