From: Alexey Klimov <klimov.linux@gmail.com>
To: Douglas Schilling Landgraf <dougsland@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: [patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel
Date: Sat, 08 Aug 2009 21:45:33 +0400 [thread overview]
Message-ID: <1249753533.15160.241.camel@tux.localhost> (raw)
Remove redundant lock/unlock_kernel() calls from usb_amradio_open/close
functions.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r ee6cf88cb5d3 linux/drivers/media/radio/radio-mr800.c
--- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 01:42:02 2009 -0300
+++ b/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 10:44:02 2009 +0400
@@ -540,8 +540,6 @@
struct amradio_device *radio = video_get_drvdata(video_devdata(file));
int retval;
- lock_kernel();
-
radio->users = 1;
radio->muted = 1;
@@ -550,7 +548,6 @@
amradio_dev_warn(&radio->videodev->dev,
"radio did not start up properly\n");
radio->users = 0;
- unlock_kernel();
return -EIO;
}
@@ -564,7 +561,6 @@
amradio_dev_warn(&radio->videodev->dev,
"set frequency failed\n");
- unlock_kernel();
return 0;
}
--
Best regards, Klimov Alexey
next reply other threads:[~2009-08-08 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 17:45 Alexey Klimov [this message]
2009-08-10 21:43 ` [patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel David Ellingsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249753533.15160.241.camel@tux.localhost \
--to=klimov.linux@gmail.com \
--cc=dougsland@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox