From: Alexey Klimov <klimov.linux@gmail.com>
To: Douglas Schilling Landgraf <dougsland@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: [patch review 3/6] radio-mr800: no need to pass curfreq value to amradio_setfreq()
Date: Sat, 08 Aug 2009 21:46:04 +0400 [thread overview]
Message-ID: <1249753564.15160.248.camel@tux.localhost> (raw)
Small cleanup of amradio_setfreq(). No need to pass radio->curfreq value
to this function.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r 5f3329bebfe4 linux/drivers/media/radio/radio-mr800.c
--- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 12:36:46 2009 +0400
+++ b/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 12:41:51 2009 +0400
@@ -202,11 +202,11 @@
}
/* set a frequency, freq is defined by v4l's TUNER_LOW, i.e. 1/16th kHz */
-static int amradio_setfreq(struct amradio_device *radio, int freq)
+static int amradio_setfreq(struct amradio_device *radio)
{
int retval;
int size;
- unsigned short freq_send = 0x10 + (freq >> 3) / 25;
+ unsigned short freq_send = 0x10 + (radio->curfreq >> 3) / 25;
/* safety check */
if (radio->removed)
@@ -413,7 +413,7 @@
radio->curfreq = f->frequency;
mutex_unlock(&radio->lock);
- retval = amradio_setfreq(radio, radio->curfreq);
+ retval = amradio_setfreq(radio);
if (retval < 0)
amradio_dev_warn(&radio->videodev->dev,
"set frequency failed\n");
--
Best regards, Klimov Alexey
next reply other threads:[~2009-08-08 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 17:46 Alexey Klimov [this message]
2009-08-10 21:53 ` [patch review 3/6] radio-mr800: no need to pass curfreq value to amradio_setfreq() David Ellingsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249753564.15160.248.camel@tux.localhost \
--to=klimov.linux@gmail.com \
--cc=dougsland@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox