From: Shine Liu <shinel@foxmail.com>
To: linux-media@vger.kernel.org
Cc: dheitmueller@kernellabs.com
Subject: [PATCH] em28xx: Don't call em28xx_ir_init when disable_ir is true
Date: Fri, 21 Aug 2009 10:49:26 +0800 [thread overview]
Message-ID: <1250822966.5248.6.camel@shinel> (raw)
I think we should call em28xx_ir_init(dev) when disable_ir is true.
Following patch will fix the bug.
Cheers,
Shine
Signed-off-by: Shine Liu <shinel@foxmail.com>
-----------------------------------------------------
--- a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-14 06:43:34.000000000 +0800
+++ a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-21 10:39:23.000000000 +0800
@@ -2367,7 +2367,9 @@
}
em28xx_tuner_setup(dev);
- em28xx_ir_init(dev);
+
+ if(!disable_ir)
+ em28xx_ir_init(dev);
}
next reply other threads:[~2009-08-21 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 2:49 Shine Liu [this message]
2009-08-21 3:03 ` [PATCH] em28xx: Don't call em28xx_ir_init when disable_ir is true Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250822966.5248.6.camel@shinel \
--to=shinel@foxmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox