From: Daniel Walker <dwalker@fifo99.com>
To: iceberg <strakh@ispras.ru>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c
Date: Thu, 10 Sep 2009 07:48:44 -0700 [thread overview]
Message-ID: <1252594124.30578.181.camel@desktop> (raw)
In-Reply-To: <200909101837.34472.strakh@ispras.ru>
On Thu, 2009-09-10 at 18:37 +0000, iceberg wrote:
> In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe:
> Mutex must be unlocked before exit
> 1. On paths starting with mutex lock in line 1912, then continuing in lines:
> 1929, 1936 (goto unreg) and 1940 (goto iounmap) .
> 2. On path starting in line 1971 mutex lock, and then continuing in line 1978
> (goto out_smbus) mutex.
>
> Fix lock imbalances in function cafe_pci_probe.
> Found by Linux Driver Verification project.
Could you run this through checkpatch and fix any issues you find? It
looks like you need to use tabs for indentation in a couple places.
Daniel
next prev parent reply other threads:[~2009-09-10 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 18:37 [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c iceberg
2009-09-10 14:48 ` Daniel Walker [this message]
2009-09-10 15:30 ` Jonathan Corbet
2009-09-10 19:05 ` Steven Rostedt
2009-09-11 17:47 ` iceberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252594124.30578.181.camel@desktop \
--to=dwalker@fifo99.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=strakh@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox